You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "maskit (via GitHub)" <gi...@apache.org> on 2023/11/02 22:13:45 UTC
[PR] Remove the direct dependency for HttpCacheSM from iocore/cache [trafficserver]
maskit opened a new pull request, #10721:
URL: https://github.com/apache/trafficserver/pull/10721
This PR changes the way of telling `HttpCacheSM` that cache will be RWW. The new way use an event instead of calling `HttpCacheSM::set_readwhilewrite_inprogress()` directly, and that removes the necessity of knowing `HttpCacheSM`. Although an event is used, the event is dispatched by calling `handleEvent` so it's still processed instantly.
test_RWW needed a bit of adjustment to handle the new event, so the new event won't be caught by `default` case which make tests fail. In other words, the new event is dispatched to the intended continuation / event handler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove the direct dependency for HttpCacheSM from iocore/cache [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #10721:
URL: https://github.com/apache/trafficserver/pull/10721#issuecomment-1811601106
[approve ci osx]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove the direct dependency for HttpCacheSM from iocore/cache [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #10721:
URL: https://github.com/apache/trafficserver/pull/10721#issuecomment-1812840466
[approve ci format]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove the direct dependency for HttpCacheSM from iocore/cache [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #10721:
URL: https://github.com/apache/trafficserver/pull/10721#issuecomment-1811517210
[approve ci osx]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove the direct dependency for HttpCacheSM from iocore/cache [trafficserver]
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit merged PR #10721:
URL: https://github.com/apache/trafficserver/pull/10721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org