You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Joe Bohn (JIRA)" <ji...@apache.org> on 2007/11/06 21:21:50 UTC
[jira] Created: (GERONIMO-3587) Move TomcatWebConnector stats
objects from under o/a/g/management to o/a/g/tomcat/stats
Move TomcatWebConnector stats objects from under o/a/g/management to o/a/g/tomcat/stats
---------------------------------------------------------------------------------------
Key: GERONIMO-3587
URL: https://issues.apache.org/jira/browse/GERONIMO-3587
Project: Geronimo
Issue Type: Improvement
Security Level: public (Regular issues)
Components: management, Tomcat
Affects Versions: 2.1
Reporter: Joe Bohn
Priority: Minor
There are currently Tomcat specific implementations under o/a/g/management. These should be included under tomcat. We're trying to get things more modular so that tomcat specific elements are only included if tomcat itself is installed. Likewise for Jetty. Having these elements under management pulls Tomcat specific items into the image when Tomcat itself is not included.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3587) Move TomcatWebConnector stats
objects from under o/a/g/management to o/a/g/tomcat/stats
Posted by "Anita Kulshreshtha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540740 ]
Anita Kulshreshtha commented on GERONIMO-3587:
----------------------------------------------
Joe,
Please see https://issues.apache.org/jira/browse/GERONIMO-3586#action_12540569.
> Move TomcatWebConnector stats objects from under o/a/g/management to o/a/g/tomcat/stats
> ---------------------------------------------------------------------------------------
>
> Key: GERONIMO-3587
> URL: https://issues.apache.org/jira/browse/GERONIMO-3587
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: management, Tomcat
> Affects Versions: 2.1
> Reporter: Joe Bohn
> Priority: Minor
>
> There are currently Tomcat specific implementations under o/a/g/management. These should be included under tomcat. We're trying to get things more modular so that tomcat specific elements are only included if tomcat itself is installed. Likewise for Jetty. Having these elements under management pulls Tomcat specific items into the image when Tomcat itself is not included.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3587) Move TomcatWebConnector stats
objects from under o/a/g/management to o/a/g/tomcat/stats
Posted by "Anita Kulshreshtha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540550 ]
Anita Kulshreshtha commented on GERONIMO-3587:
----------------------------------------------
I strongly disagree with this. These stats DO NOT pull anything specific to tomcat in a Jetty
image.
> Move TomcatWebConnector stats objects from under o/a/g/management to o/a/g/tomcat/stats
> ---------------------------------------------------------------------------------------
>
> Key: GERONIMO-3587
> URL: https://issues.apache.org/jira/browse/GERONIMO-3587
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: management, Tomcat
> Affects Versions: 2.1
> Reporter: Joe Bohn
> Priority: Minor
>
> There are currently Tomcat specific implementations under o/a/g/management. These should be included under tomcat. We're trying to get things more modular so that tomcat specific elements are only included if tomcat itself is installed. Likewise for Jetty. Having these elements under management pulls Tomcat specific items into the image when Tomcat itself is not included.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (GERONIMO-3587) Move TomcatWebConnector stats
objects from under o/a/g/management to o/a/g/tomcat/stats
Posted by "Joe Bohn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Bohn closed GERONIMO-3587.
------------------------------
Resolution: Won't Fix
I'm canceling this issue. See comments in GERONIMO-3586
> Move TomcatWebConnector stats objects from under o/a/g/management to o/a/g/tomcat/stats
> ---------------------------------------------------------------------------------------
>
> Key: GERONIMO-3587
> URL: https://issues.apache.org/jira/browse/GERONIMO-3587
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: management, Tomcat
> Affects Versions: 2.1
> Reporter: Joe Bohn
> Priority: Minor
>
> There are currently Tomcat specific implementations under o/a/g/management. These should be included under tomcat. We're trying to get things more modular so that tomcat specific elements are only included if tomcat itself is installed. Likewise for Jetty. Having these elements under management pulls Tomcat specific items into the image when Tomcat itself is not included.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3587) Move TomcatWebConnector stats
objects from under o/a/g/management to o/a/g/tomcat/stats
Posted by "Joe Bohn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540611 ]
Joe Bohn commented on GERONIMO-3587:
------------------------------------
Ok, so it's not as bad as it could be ... but I still don't understand why you want to have classes that are specific to either tomcat or jetty living in a common geronimo management package? Why do you feel so strongly that they should be located there?
In general it seems cleaner and more consistent to me to have these under packages with their respective containers as we have done with the container stats and the jetty connector stats. IMO it just keeps things organized better.
> Move TomcatWebConnector stats objects from under o/a/g/management to o/a/g/tomcat/stats
> ---------------------------------------------------------------------------------------
>
> Key: GERONIMO-3587
> URL: https://issues.apache.org/jira/browse/GERONIMO-3587
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: management, Tomcat
> Affects Versions: 2.1
> Reporter: Joe Bohn
> Priority: Minor
>
> There are currently Tomcat specific implementations under o/a/g/management. These should be included under tomcat. We're trying to get things more modular so that tomcat specific elements are only included if tomcat itself is installed. Likewise for Jetty. Having these elements under management pulls Tomcat specific items into the image when Tomcat itself is not included.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.