You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@storm.apache.org by sr...@apache.org on 2016/06/07 02:57:17 UTC
[2/4] storm git commit: STORM-1864 log messages with format
STORM-1864 log messages with format
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/fbcd0ab7
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/fbcd0ab7
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/fbcd0ab7
Branch: refs/heads/master
Commit: fbcd0ab780b9c3047de2f522e4286ec5321cba09
Parents: b5fe05a
Author: Satish Duggana <sd...@hortonworks.com>
Authored: Wed May 25 12:35:26 2016 +0530
Committer: Satish Duggana <sd...@hortonworks.com>
Committed: Wed May 25 15:01:25 2016 +0530
----------------------------------------------------------------------
storm-core/src/jvm/org/apache/storm/StormSubmitter.java | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/storm/blob/fbcd0ab7/storm-core/src/jvm/org/apache/storm/StormSubmitter.java
----------------------------------------------------------------------
diff --git a/storm-core/src/jvm/org/apache/storm/StormSubmitter.java b/storm-core/src/jvm/org/apache/storm/StormSubmitter.java
index 077c577..9766740 100644
--- a/storm-core/src/jvm/org/apache/storm/StormSubmitter.java
+++ b/storm-core/src/jvm/org/apache/storm/StormSubmitter.java
@@ -273,13 +273,18 @@ public class StormSubmitter {
if (stormConf.containsKey(Config.STORM_TOPOLOGY_SUBMISSION_NOTIFIER_PLUGIN)) {
submissionNotifierClassName = stormConf.get(Config.STORM_TOPOLOGY_SUBMISSION_NOTIFIER_PLUGIN).toString();
LOG.info("Initializing the registered ISubmitterHook [{}]", submissionNotifierClassName);
+
+ if(submissionNotifierClassName == null || submissionNotifierClassName.isEmpty()) {
+ throw new IllegalArgumentException(Config.STORM_TOPOLOGY_SUBMISSION_NOTIFIER_PLUGIN + " property must be a non empty string.");
+ }
+
ISubmitterHook submitterHook = (ISubmitterHook) Class.forName(submissionNotifierClassName).newInstance();
TopologyInfo topologyInfo = Utils.getTopologyInfo(name, asUser, stormConf);
LOG.info("Invoking the registered ISubmitterHook [{}]", submissionNotifierClassName);
submitterHook.notify(topologyInfo, stormConf, topology);
}
} catch (Exception e) {
- LOG.warn("Error occurred in invoking submitter hook: "+submissionNotifierClassName, e);
+ LOG.warn("Error occurred in invoking submitter hook:[{}] ",submissionNotifierClassName, e);
throw new SubmitterHookException(e);
}
}