You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2017/01/19 02:06:39 UTC
Review Request 55699: Stout: Added `host_default_path`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55699/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
Repository: mesos
Description
-------
Stout: Added `host_default_path`.
Diffs
-----
3rdparty/stout/include/stout/posix/os.hpp 397c2d6b06ddb607d254eae8258da5151c5f57e0
3rdparty/stout/include/stout/windows/os.hpp b4a66ba8ddbc60f7bcc9aad7fef4e158ae3a96d6
Diff: https://reviews.apache.org/r/55699/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 55699: Stout: Added `host_default_path`.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55699/#review162524
-----------------------------------------------------------
Ship it!
Just for completeness, I'm going to augment the commit message with:
```
This function returns a host-specific value that can be put into the
`PATH` environment variable. On POSIX, this is a hard-coded string
pointing to several binary directories. On Windows, this returns
the location of the OS's root directory.
```
- Joseph Wu
On Jan. 18, 2017, 6:06 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55699/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2017, 6:06 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Stout: Added `host_default_path`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/posix/os.hpp 397c2d6b06ddb607d254eae8258da5151c5f57e0
> 3rdparty/stout/include/stout/windows/os.hpp b4a66ba8ddbc60f7bcc9aad7fef4e158ae3a96d6
>
> Diff: https://reviews.apache.org/r/55699/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>