[GitHub] [incubator-superset] villebro opened a new pull request #8080: [bugfix] Fix CTEs for engines that don't support LIMIT expression

[GitBox <gi...@apache.org>]

villebro opened a new pull request #8080: [bugfix] Fix CTEs for engines that don't support LIMIT expression
URL: https://github.com/apache/incubator-superset/pull/8080
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [x] Add tests
   - [ ] Build / Development Environment
   - [x] Documentation
   
   ### SUMMARY
   In SQL Lab, CTEs were failing for engines that don't support LIMIT expressions. This removes limits for those engines and adds tests.
   
   ### TEST PLAN
   - Test CTE on MSSQL and Oracle
   - CI
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: Closes #8074
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @abhinavsood @mistercrunch 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org