You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "leaderli (via GitHub)" <gi...@apache.org> on 2023/10/27 04:20:29 UTC
[PR] when in one listening period, if the file has been removed or deleted… [commons-io]
leaderli opened a new pull request, #507:
URL: https://github.com/apache/commons-io/pull/507
…,and a new file with content large than read position, it should reopen the file and read from beginning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] when in one listening period, if the file has been removed or deleted… [commons-io]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory closed pull request #507: when in one listening period, if the file has been removed or deleted…
URL: https://github.com/apache/commons-io/pull/507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] when in one listening period, if the file has been removed or deleted… [commons-io]
Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF commented on code in PR #507:
URL: https://github.com/apache/commons-io/pull/507#discussion_r1374252911
##########
src/test/java/org/apache/commons/io/input/TailerTest.java:
##########
@@ -711,7 +739,9 @@ private void validateTailer(final TestTailerListener listener, final File file)
assertEquals(listener.getLines(), Arrays.asList("foo"), "lines");
}
- /** Appends lines to a file */
+ /**
+ * Appends lines to a file
+ */
Review Comment:
Please don't change unrelated code
##########
src/test/java/org/apache/commons/io/input/TailerTest.java:
##########
@@ -720,7 +750,9 @@ private void write(final File file, final String... lines) throws IOException {
}
}
- /** Appends strings to a file */
+ /**
+ * Appends strings to a file
+ */
Review Comment:
Unrelated code should be left alone
##########
src/test/java/org/apache/commons/io/input/TailerTest.java:
##########
@@ -425,7 +453,7 @@ public void testMultiByteBreak() throws Exception {
thread.start();
try (Writer out = new OutputStreamWriter(Files.newOutputStream(file.toPath()), charsetUTF8);
- BufferedReader reader = new BufferedReader(new InputStreamReader(Files.newInputStream(origin.toPath()), charsetUTF8))) {
+ BufferedReader reader = new BufferedReader(new InputStreamReader(Files.newInputStream(origin.toPath()), charsetUTF8))) {
Review Comment:
Spurious change - please don't change unrelated code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] when in one listening period, if the file has been removed or deleted… [commons-io]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #507:
URL: https://github.com/apache/commons-io/pull/507#issuecomment-1824527224
Closing: No reply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] when in one listening period, if the file has been removed or deleted… [commons-io]
Posted by "monster12137 (via GitHub)" <gi...@apache.org>.
monster12137 commented on code in PR #507:
URL: https://github.com/apache/commons-io/pull/507#discussion_r1394090319
##########
src/test/java/org/apache/commons/io/input/TailerTest.java:
##########
@@ -425,7 +453,7 @@ public void testMultiByteBreak() throws Exception {
thread.start();
try (Writer out = new OutputStreamWriter(Files.newOutputStream(file.toPath()), charsetUTF8);
- BufferedReader reader = new BufferedReader(new InputStreamReader(Files.newInputStream(origin.toPath()), charsetUTF8))) {
+ BufferedReader reader = new BufferedReader(new InputStreamReader(Files.newInputStream(origin.toPath()), charsetUTF8))) {
Review Comment:
shawanyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org