[jira] [Commented] (KAFKA-1836) metadata.fetch.timeout.ms set to zero blocks forever

["Ewen Cheslack-Postava (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14268178#comment-14268178 ] 

Ewen Cheslack-Postava commented on KAFKA-1836:
----------------------------------------------

A couple of notes on the current patch:

* I don't think we need to change the config limits -- 0 should be an acceptable setting, it just isn't behaving properly right now.
* You can get the right behavior just by adding an if statement as Jay suggested -- don't call wait() if maxWaitMs is 0. The subsequent check that generates the TimeoutException should then work.
* Checking for the invalid value < 0 is ok, but the code that calls it guarantees it won't since the config is already validated to have a value >= 0.
* In the test, maybe check that the timeout is correct rather than whether you got the right metadata back since the test is supposed to focus on the timeouts.

> metadata.fetch.timeout.ms set to zero blocks forever
> ----------------------------------------------------
>
>                 Key: KAFKA-1836
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1836
>             Project: Kafka
>          Issue Type: Bug
>          Components: clients
>    Affects Versions: 0.8.2
>            Reporter: Paul Pearcy
>            Priority: Minor
>              Labels: newbie
>             Fix For: 0.8.3
>
>         Attachments: KAFKA-1836.patch
>
>
> You can easily work around this by setting the timeout value to 1ms, but 0ms should mean 0ms or at least have the behavior documented. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)