You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jay Guo <gu...@gmail.com> on 2017/01/25 18:06:33 UTC
Review Request 55946: Added agent capabilities as part of agent
(re-)registration process.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55946/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
WIP.
Diffs
-----
src/master/master.hpp cb1b82d93919edf910bfbece8ef1a33cade9dc8b
src/master/master.cpp 2432ed4844dcf52f26ef5b4132d5ad429d1b4317
Diff: https://reviews.apache.org/r/55946/diff/
Testing
-------
Thanks,
Jay Guo
Re: Review Request 55946: Added agent capabilities as part of agent
(re-)registration process.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55946/#review163160
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Jan. 26, 2017, 11:46 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55946/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2017, 11:46 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Agent capabilities are communicated during registration and stored
> in `Slave` struct in master. Upon agent reregistration, capabilities
> are updated.
>
>
> Diffs
> -----
>
> src/master/master.hpp cb1b82d93919edf910bfbece8ef1a33cade9dc8b
> src/master/master.cpp 2432ed4844dcf52f26ef5b4132d5ad429d1b4317
>
> Diff: https://reviews.apache.org/r/55946/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 55946: Added agent capabilities as part of agent
(re-)registration process.
Posted by Jay Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55946/
-----------------------------------------------------------
(Updated Jan. 26, 2017, 7:46 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
rebase
Repository: mesos
Description (updated)
-------
Agent capabilities are communicated during registration and stored
in `Slave` struct in master. Upon agent reregistration, capabilities
are updated.
Diffs (updated)
-----
src/master/master.hpp cb1b82d93919edf910bfbece8ef1a33cade9dc8b
src/master/master.cpp 2432ed4844dcf52f26ef5b4132d5ad429d1b4317
Diff: https://reviews.apache.org/r/55946/diff/
Testing
-------
Thanks,
Jay Guo
Re: Review Request 55946: Added agent capabilities as part of agent
(re-)registration process.
Posted by Jay Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55946/
-----------------------------------------------------------
(Updated Jan. 26, 2017, 12:40 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Left `Capability` in `SlaveInfo` rather than creating `AgentCapability`.
Repository: mesos
Description
-------
WIP.
Diffs (updated)
-----
src/master/master.hpp cb1b82d93919edf910bfbece8ef1a33cade9dc8b
src/master/master.cpp 2432ed4844dcf52f26ef5b4132d5ad429d1b4317
Diff: https://reviews.apache.org/r/55946/diff/
Testing
-------
Thanks,
Jay Guo
Re: Review Request 55946: Added agent capabilities as part of agent
(re-)registration process.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55946/#review163032
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55943, 55944, 55945, 55946]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Jan. 25, 2017, 6:06 p.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55946/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2017, 6:06 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> WIP.
>
>
> Diffs
> -----
>
> src/master/master.hpp cb1b82d93919edf910bfbece8ef1a33cade9dc8b
> src/master/master.cpp 2432ed4844dcf52f26ef5b4132d5ad429d1b4317
>
> Diff: https://reviews.apache.org/r/55946/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Guo
>
>