[GitHub] [nifi] ChrisSamo632 commented on a diff in pull request #6712: NIFI-10870 Wrapped debug logger statements with if statements in the …

[GitBox <gi...@apache.org>]

ChrisSamo632 commented on code in PR #6712:
URL: https://github.com/apache/nifi/pull/6712#discussion_r1030835309


##########
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/QueryElasticsearchHttp.java:
##########
@@ -462,7 +463,9 @@ private int getPage(final Response getResponse, final URL url, final ProcessCont
                 page.add(documentFlowFile);
             }
 
-            logger.debug("Elasticsearch retrieved " + responseJson.size() + " documents, routing to success");
+            if (logger.isDebugEnabled()) {
+                logger.debug("Elasticsearch retrieved " + responseJson.size() + " documents, routing to success");

Review Comment:
   Should use a log formatting String instead, like other logger calls (rther than String concatenation)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org