You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "Sandeep More (JIRA)" <ji...@apache.org> on 2017/06/06 18:25:18 UTC
[jira] [Comment Edited] (KNOX-940) Support REST access exposing
metrics
[ https://issues.apache.org/jira/browse/KNOX-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16039075#comment-16039075 ]
Sandeep More edited comment on KNOX-940 at 6/6/17 6:25 PM:
-----------------------------------------------------------
Hello [~kamrul]
Looks like we have a test failure (DeploymentFactoryFuncTest.testWebXmlGeneration).
Also, I noticed that the patch does not have tests, can you also add tests (about health and ping rest api) for the functionality.
{code}
[exec] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.708 sec - in org.apache.hadoop.gateway.OozieServiceDefinitionTest
[exec]
[exec] Results :
[exec]
[exec] Failed tests:
[exec] DeploymentFactoryFuncTest.testWebXmlGeneration:381->createAndTestDeployment:400
[exec] Expected: an XML document with XPath /web-app/listener[3]/listener-class "org.apache.hadoop.gateway.ha.provider.HaServletContextListener"
[exec] but: was "org.apache.hadoop.gateway.services.GatewayMetricsServletContextListener"
[exec]
[exec] Tests run: 43, Failures: 1, Errors: 0, Skipped: 0
{code}
Thanks !
was (Author: smore):
Hello [~kamrul]
Looks like we have a test failure (DeploymentFactoryFuncTest.testWebXmlGeneration).
Also, I noticed that the patch does not have tests, can you also add tests for the functionality.
{code}
[exec] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.708 sec - in org.apache.hadoop.gateway.OozieServiceDefinitionTest
[exec]
[exec] Results :
[exec]
[exec] Failed tests:
[exec] DeploymentFactoryFuncTest.testWebXmlGeneration:381->createAndTestDeployment:400
[exec] Expected: an XML document with XPath /web-app/listener[3]/listener-class "org.apache.hadoop.gateway.ha.provider.HaServletContextListener"
[exec] but: was "org.apache.hadoop.gateway.services.GatewayMetricsServletContextListener"
[exec]
[exec] Tests run: 43, Failures: 1, Errors: 0, Skipped: 0
{code}
Thanks !
> Support REST access exposing metrics
> ------------------------------------
>
> Key: KNOX-940
> URL: https://issues.apache.org/jira/browse/KNOX-940
> Project: Apache Knox
> Issue Type: Task
> Affects Versions: 0.11.0
> Reporter: Mohammad Kamrul Islam
> Assignee: Mohammad Kamrul Islam
> Fix For: 0.13.0
>
> Attachments: KNOX-940.2.patch, KNOX-940.patch
>
>
> KNOX-643 added the support to publish metrics. However, the metrics are not accessible through REST. This JIRA is to add REST support.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)