You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/03/15 06:04:09 UTC
[GitHub] [ozone] bshashikant commented on a change in pull request #1685: HDDS-4552. Read data from chunk into ByteBuffer[] instead of single ByteBuffer.
bshashikant commented on a change in pull request #1685:
URL: https://github.com/apache/ozone/pull/1685#discussion_r594065241
##########
File path: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/ChunkInputStream.java
##########
@@ -87,7 +105,8 @@
ChunkInputStream(ChunkInfo chunkInfo, BlockID blockId,
XceiverClientFactory xceiverClientFactory,
Supplier<Pipeline> pipelineSupplier,
- boolean verifyChecksum, Token<? extends TokenIdentifier> token) {
+ boolean verifyChecksum,
+ Token<? extends TokenIdentifier> token) {
Review comment:
Unintended change?
##########
File path: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/OzoneClientConfig.java
##########
@@ -109,13 +109,13 @@
private String checksumType = ChecksumType.CRC32.name();
@Config(key = "bytes.per.checksum",
- defaultValue = "1MB",
+ defaultValue = "256KB",
Review comment:
Let's not change the default for now. We can change once we do some tests and analyze performance .
##########
File path: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/ChunkInputStream.java
##########
@@ -66,13 +76,21 @@
// Index of the buffers corresponding to the current position of the buffers
private int bufferIndex;
+ // bufferOffsets[i] stores the index of the first data byte in buffer i
+ // (buffers.get(i)) w.r.t first byte in the buffers.
+ // Let's each buffer has a capacity of 40 bytes. The bufferOffset for
Review comment:
Let's -> "Let's say"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org