You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/11/28 17:33:09 UTC
[GitHub] [cloudstack] stephankruggg opened a new pull request, #6925: Add and improve logs in snapshot scheduling
stephankruggg opened a new pull request, #6925:
URL: https://github.com/apache/cloudstack/pull/6925
### Description
This PR adds and improves logs in the snapshot scheduling process in order to facilitate troubleshooting, as current logs are scarce.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
### How Has This Been Tested?
I applied the changes in a local lab and checked if the messages were being correctly logged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #6925: Add and improve logs in snapshot scheduling
Posted by "GutoVeronezi (via GitHub)" <gi...@apache.org>.
GutoVeronezi commented on PR #6925:
URL: https://github.com/apache/cloudstack/pull/6925#issuecomment-1714591018
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6925: Add and improve logs in snapshot scheduling
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6925:
URL: https://github.com/apache/cloudstack/pull/6925#issuecomment-1714593052
@GutoVeronezi a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6925: Add and improve logs in snapshot scheduling
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6925:
URL: https://github.com/apache/cloudstack/pull/6925#issuecomment-1331724699
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] stephankruggg commented on pull request #6925: Add and improve logs in snapshot scheduling
Posted by GitBox <gi...@apache.org>.
stephankruggg commented on PR #6925:
URL: https://github.com/apache/cloudstack/pull/6925#issuecomment-1353577257
> @stephankruggg , i still oppose to unguarded logging with string evaluation in parameters. i have not seen arguments to counter the downside of it yet. So please look at #6973 it implements a uitlity available in log4j2 and other frameworks that will help compromise between our point of views. What do you think?
Okay, I will take a look at it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6925: Add and improve logs in snapshot scheduling
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6925:
URL: https://github.com/apache/cloudstack/pull/6925#issuecomment-1558754963
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6925: Add and improve logs in snapshot scheduling
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6925:
URL: https://github.com/apache/cloudstack/pull/6925#issuecomment-1714654078
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7018
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #6925: Add and improve logs in snapshot scheduling
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on code in PR #6925:
URL: https://github.com/apache/cloudstack/pull/6925#discussion_r1035595830
##########
server/src/main/java/com/cloud/storage/snapshot/SnapshotSchedulerImpl.java:
##########
@@ -264,45 +264,29 @@ protected void deleteExpiredVMSnapshots() {
@DB
protected void scheduleSnapshots() {
String displayTime = DateUtil.displayDateInTimezone(DateUtil.GMT_TIMEZONE, _currentTimestamp);
- s_logger.debug("Snapshot scheduler.poll is being called at " + displayTime);
+ s_logger.trace(String.format("Snapshot scheduler is being called at [%s].", displayTime));
Review Comment:
may be debug is more helpful to know when the scheduler has started !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #6925: Add and improve logs in snapshot scheduling
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #6925:
URL: https://github.com/apache/cloudstack/pull/6925
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6925: Add and improve logs in snapshot scheduling
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6925:
URL: https://github.com/apache/cloudstack/pull/6925#issuecomment-1331744973
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 4693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6925: Add and improve logs in snapshot scheduling
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6925:
URL: https://github.com/apache/cloudstack/pull/6925#issuecomment-1724470969
<b>[SF] Trillian test result (tid-7670)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42042 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6925-t7670-kvm-centos7.zip
Smoke tests completed. 113 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6925: Add and improve logs in snapshot scheduling
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #6925:
URL: https://github.com/apache/cloudstack/pull/6925#issuecomment-1558548249
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6925: Add and improve logs in snapshot scheduling
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #6925:
URL: https://github.com/apache/cloudstack/pull/6925#issuecomment-1723032199
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6925: Add and improve logs in snapshot scheduling
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6925:
URL: https://github.com/apache/cloudstack/pull/6925#issuecomment-1346446696
@stephankruggg , i still oppose to unguarded logging with string evaluation in parameters. i have not seen arguments to counter the downside of it yet. So please look at #6973 it implements a uitlity available in log4j2 and other frameworks that will help compromise between our point of views. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] stephankruggg commented on pull request #6925: Add and improve logs in snapshot scheduling
Posted by GitBox <gi...@apache.org>.
stephankruggg commented on PR #6925:
URL: https://github.com/apache/cloudstack/pull/6925#issuecomment-1367934902
@DaanHoogland, sorry for the delay. I took a look at your proposal, and as @GutoVeronezi pointed out (https://github.com/apache/cloudstack/pull/6973#issuecomment-1347285676), we are already working on a Log4j upgrade. Therefore, I do not think applying an extra step is the best option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6925: Add and improve logs in snapshot scheduling
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6925:
URL: https://github.com/apache/cloudstack/pull/6925#issuecomment-1329572483
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6925?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6925](https://codecov.io/gh/apache/cloudstack/pull/6925?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (35810b7) into [main](https://codecov.io/gh/apache/cloudstack/commit/adec8110521b0f93458d411dc689c91fd5a59004?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (adec811) will **increase** coverage by `0.01%`.
> The diff coverage is `70.27%`.
```diff
@@ Coverage Diff @@
## main #6925 +/- ##
============================================
+ Coverage 10.87% 10.89% +0.01%
- Complexity 7117 7135 +18
============================================
Files 2485 2485
Lines 245507 245528 +21
Branches 38334 38335 +1
============================================
+ Hits 26699 26748 +49
+ Misses 215538 215510 -28
Partials 3270 3270
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6925?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../cloud/storage/snapshot/SnapshotSchedulerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6925/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3N0b3JhZ2Uvc25hcHNob3QvU25hcHNob3RTY2hlZHVsZXJJbXBsLmphdmE=) | `16.51% <70.27%> (+16.51%)` | :arrow_up: |
| [.../main/java/com/cloud/storage/SnapshotPolicyVO.java](https://codecov.io/gh/apache/cloudstack/pull/6925/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9zdG9yYWdlL1NuYXBzaG90UG9saWN5Vk8uamF2YQ==) | `94.73% <0.00%> (+7.89%)` | :arrow_up: |
| [...ain/java/com/cloud/storage/SnapshotScheduleVO.java](https://codecov.io/gh/apache/cloudstack/pull/6925/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9zdG9yYWdlL1NuYXBzaG90U2NoZWR1bGVWTy5qYXZh) | `32.14% <0.00%> (+32.14%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6925: Add and improve logs in snapshot scheduling
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6925:
URL: https://github.com/apache/cloudstack/pull/6925#issuecomment-1329584333
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6925)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6925&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6925&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6925&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6925&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6925&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6925&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6925&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6925&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6925&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6925&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6925&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6925&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6925&metric=new_coverage&view=list) [59.8% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6925&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6925&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6925&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6925: Add and improve logs in snapshot scheduling
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6925:
URL: https://github.com/apache/cloudstack/pull/6925#issuecomment-1331724879
@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6925: Add and improve logs in snapshot scheduling
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6925:
URL: https://github.com/apache/cloudstack/pull/6925#issuecomment-1558549686
@rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6925: Add and improve logs in snapshot scheduling
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6925:
URL: https://github.com/apache/cloudstack/pull/6925#issuecomment-1723033717
@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org