You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "Grant Ingersoll (Created) (JIRA)" <ji...@apache.org> on 2011/11/12 09:14:51 UTC
[jira] [Created] (MAHOUT-882) TopItems.getTopUsers ignores
rescoring
TopItems.getTopUsers ignores rescoring
--------------------------------------
Key: MAHOUT-882
URL: https://issues.apache.org/jira/browse/MAHOUT-882
Project: Mahout
Issue Type: Bug
Reporter: Grant Ingersoll
Assignee: Grant Ingersoll
Priority: Minor
Fix For: 0.6
I believe TopUsers.getTopUsers() is not properly handling the rescoredSimilarity:
{code}
TopItems.getTopUsers:
double rescoredSimilarity = rescorer == null ? similarity : rescorer.rescore(userID, similarity);
if (!Double.isNaN(rescoredSimilarity) && (!full || rescoredSimilarity > lowestTopValue)) {
topUsers.add(new SimilarUser(userID, similarity));
{code}
It is checking rescoredSimilarity for everything, but then not passing it in like getTopItems does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MAHOUT-882) TopItems.getTopUsers ignores
rescoring
Posted by "Sean Owen (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sean Owen resolved MAHOUT-882.
------------------------------
Resolution: Fixed
> TopItems.getTopUsers ignores rescoring
> --------------------------------------
>
> Key: MAHOUT-882
> URL: https://issues.apache.org/jira/browse/MAHOUT-882
> Project: Mahout
> Issue Type: Bug
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Minor
> Fix For: 0.6
>
>
> I believe TopUsers.getTopUsers() is not properly handling the rescoredSimilarity:
> {code}
> TopItems.getTopUsers:
> double rescoredSimilarity = rescorer == null ? similarity : rescorer.rescore(userID, similarity);
> if (!Double.isNaN(rescoredSimilarity) && (!full || rescoredSimilarity > lowestTopValue)) {
> topUsers.add(new SimilarUser(userID, similarity));
> {code}
> It is checking rescoredSimilarity for everything, but then not passing it in like getTopItems does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAHOUT-882) TopItems.getTopUsers ignores
rescoring
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149082#comment-13149082 ]
Hudson commented on MAHOUT-882:
-------------------------------
Integrated in Mahout-Quality #1171 (See [https://builds.apache.org/job/Mahout-Quality/1171/])
MAHOUT-882 Actually used rescored value in one TopItems method. Also, fix SimilarUser issue along the way from MAHOUT-881
srowen : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1201248
Files :
* /mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/recommender/SimilarUser.java
* /mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/recommender/TopItems.java
* /mahout/trunk/core/src/test/java/org/apache/mahout/cf/taste/impl/recommender/GenericUserBasedRecommenderTest.java
> TopItems.getTopUsers ignores rescoring
> --------------------------------------
>
> Key: MAHOUT-882
> URL: https://issues.apache.org/jira/browse/MAHOUT-882
> Project: Mahout
> Issue Type: Bug
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Minor
> Fix For: 0.6
>
>
> I believe TopUsers.getTopUsers() is not properly handling the rescoredSimilarity:
> {code}
> TopItems.getTopUsers:
> double rescoredSimilarity = rescorer == null ? similarity : rescorer.rescore(userID, similarity);
> if (!Double.isNaN(rescoredSimilarity) && (!full || rescoredSimilarity > lowestTopValue)) {
> topUsers.add(new SimilarUser(userID, similarity));
> {code}
> It is checking rescoredSimilarity for everything, but then not passing it in like getTopItems does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAHOUT-882) TopItems.getTopUsers ignores
rescoring
Posted by "Sean Owen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149039#comment-13149039 ]
Sean Owen commented on MAHOUT-882:
----------------------------------
Ugh, that's been there for ages. I'll fix it and SimilarUser and adjust tests.
> TopItems.getTopUsers ignores rescoring
> --------------------------------------
>
> Key: MAHOUT-882
> URL: https://issues.apache.org/jira/browse/MAHOUT-882
> Project: Mahout
> Issue Type: Bug
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Minor
> Fix For: 0.6
>
>
> I believe TopUsers.getTopUsers() is not properly handling the rescoredSimilarity:
> {code}
> TopItems.getTopUsers:
> double rescoredSimilarity = rescorer == null ? similarity : rescorer.rescore(userID, similarity);
> if (!Double.isNaN(rescoredSimilarity) && (!full || rescoredSimilarity > lowestTopValue)) {
> topUsers.add(new SimilarUser(userID, similarity));
> {code}
> It is checking rescoredSimilarity for everything, but then not passing it in like getTopItems does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira