You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "sandyfog (via GitHub)" <gi...@apache.org> on 2023/02/08 08:53:25 UTC
[GitHub] [hudi] sandyfog opened a new pull request, #7894: [HUDI-5729]Fix RowDataKeyGen method getRecordKey
sandyfog opened a new pull request, #7894:
URL: https://github.com/apache/hudi/pull/7894
### Change Logs
When recordKey contains timestamp field , bulkInsert mode generated recordKey like “id:11,ts:2022-10-12T18:30:03”.
But upsert mode according to config “hoodie.datasource.write.keygenerator.consistent.logical.timestamp.enabled” generated recordKey is “id:11,ts:2022-10-12T18:30:03” or “id:11,ts:167462460000”.
In this case upsert aflter bulkInsert ,recordKey is different can cause duplicate data。
### Impact
_Describe any public API or user-facing feature change or any performance impact._
### Risk level (write none, low medium or high below)
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7894: [HUDI-5729]Fix RowDataKeyGen method getRecordKey
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7894:
URL: https://github.com/apache/hudi/pull/7894#issuecomment-1426703623
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15037",
"triggerID" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"triggerType" : "PUSH"
}, {
"hash" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15087",
"triggerID" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"triggerType" : "PUSH"
}, {
"hash" : "a12f34765d09b2acd59e2186362ef24132f21607",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a12f34765d09b2acd59e2186362ef24132f21607",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 536d75665ed7d98b9cd9477f776748b68a855e6b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15087)
* a12f34765d09b2acd59e2186362ef24132f21607 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #7894: [HUDI-5729] Fix RowDataKeyGen method getRecordKey
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #7894:
URL: https://github.com/apache/hudi/pull/7894#discussion_r1104160893
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bulk/RowDataKeyGen.java:
##########
@@ -138,9 +142,11 @@ public static RowDataKeyGen instance(Configuration conf, RowType rowType) {
throw new HoodieKeyException("Initialize TimestampBasedAvroKeyGenerator error", e);
}
}
+ boolean consistentLogicalTimestampEnabled = conf.getBoolean(KeyGeneratorOptions.KEYGENERATOR_CONSISTENT_LOGICAL_TIMESTAMP_ENABLED.key(),
+ Boolean.parseBoolean(KeyGeneratorOptions.KEYGENERATOR_CONSISTENT_LOGICAL_TIMESTAMP_ENABLED.defaultValue()));
Review Comment:
Can move the decision to `OptionsResolver`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7894: [HUDI-5729] Fix RowDataKeyGen method getRecordKey
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7894:
URL: https://github.com/apache/hudi/pull/7894#issuecomment-1431379719
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15037",
"triggerID" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"triggerType" : "PUSH"
}, {
"hash" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15087",
"triggerID" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"triggerType" : "PUSH"
}, {
"hash" : "a12f34765d09b2acd59e2186362ef24132f21607",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15110",
"triggerID" : "a12f34765d09b2acd59e2186362ef24132f21607",
"triggerType" : "PUSH"
}, {
"hash" : "3d5313695087d4198d4439201cdb2588b6df5e41",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15133",
"triggerID" : "3d5313695087d4198d4439201cdb2588b6df5e41",
"triggerType" : "PUSH"
}, {
"hash" : "7576ed9c5b6208a497a55cfbf4c7ba463a34cc4a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15134",
"triggerID" : "7576ed9c5b6208a497a55cfbf4c7ba463a34cc4a",
"triggerType" : "PUSH"
}, {
"hash" : "6d1ea73414d1ff772c402746dcb554257492ad97",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15186",
"triggerID" : "6d1ea73414d1ff772c402746dcb554257492ad97",
"triggerType" : "PUSH"
}, {
"hash" : "ddc28f53801f2e11401738d1c6acb74eec9c8fab",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15195",
"triggerID" : "ddc28f53801f2e11401738d1c6acb74eec9c8fab",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ddc28f53801f2e11401738d1c6acb74eec9c8fab Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15195)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7894: [HUDI-5729] Fix RowDataKeyGen method getRecordKey
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7894:
URL: https://github.com/apache/hudi/pull/7894#issuecomment-1434519394
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15037",
"triggerID" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"triggerType" : "PUSH"
}, {
"hash" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15087",
"triggerID" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"triggerType" : "PUSH"
}, {
"hash" : "a12f34765d09b2acd59e2186362ef24132f21607",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15110",
"triggerID" : "a12f34765d09b2acd59e2186362ef24132f21607",
"triggerType" : "PUSH"
}, {
"hash" : "3d5313695087d4198d4439201cdb2588b6df5e41",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15133",
"triggerID" : "3d5313695087d4198d4439201cdb2588b6df5e41",
"triggerType" : "PUSH"
}, {
"hash" : "7576ed9c5b6208a497a55cfbf4c7ba463a34cc4a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15134",
"triggerID" : "7576ed9c5b6208a497a55cfbf4c7ba463a34cc4a",
"triggerType" : "PUSH"
}, {
"hash" : "6d1ea73414d1ff772c402746dcb554257492ad97",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15186",
"triggerID" : "6d1ea73414d1ff772c402746dcb554257492ad97",
"triggerType" : "PUSH"
}, {
"hash" : "ddc28f53801f2e11401738d1c6acb74eec9c8fab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15195",
"triggerID" : "ddc28f53801f2e11401738d1c6acb74eec9c8fab",
"triggerType" : "PUSH"
}, {
"hash" : "3cb6100b26cc838b555ad8ddd979408d52c98ecb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15260",
"triggerID" : "3cb6100b26cc838b555ad8ddd979408d52c98ecb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3cb6100b26cc838b555ad8ddd979408d52c98ecb Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15260)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #7894: [HUDI-5729] Fix RowDataKeyGen method getRecordKey
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #7894:
URL: https://github.com/apache/hudi/pull/7894#issuecomment-1432819212
We are ready to land once the conflict is resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] sandyfog commented on pull request #7894: [HUDI-5729] Fix RowDataKeyGen method getRecordKey
Posted by "sandyfog (via GitHub)" <gi...@apache.org>.
sandyfog commented on PR #7894:
URL: https://github.com/apache/hudi/pull/7894#issuecomment-1430633349
>
> There is a test failure: `TestRowDataKeyGen.testRecoredKeyContainsTimestamp:201`
May be the default timezone is different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7894: [HUDI-5729] Fix RowDataKeyGen method getRecordKey
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7894:
URL: https://github.com/apache/hudi/pull/7894#issuecomment-1430664990
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15037",
"triggerID" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"triggerType" : "PUSH"
}, {
"hash" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15087",
"triggerID" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"triggerType" : "PUSH"
}, {
"hash" : "a12f34765d09b2acd59e2186362ef24132f21607",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15110",
"triggerID" : "a12f34765d09b2acd59e2186362ef24132f21607",
"triggerType" : "PUSH"
}, {
"hash" : "3d5313695087d4198d4439201cdb2588b6df5e41",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15133",
"triggerID" : "3d5313695087d4198d4439201cdb2588b6df5e41",
"triggerType" : "PUSH"
}, {
"hash" : "7576ed9c5b6208a497a55cfbf4c7ba463a34cc4a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15134",
"triggerID" : "7576ed9c5b6208a497a55cfbf4c7ba463a34cc4a",
"triggerType" : "PUSH"
}, {
"hash" : "6d1ea73414d1ff772c402746dcb554257492ad97",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15186",
"triggerID" : "6d1ea73414d1ff772c402746dcb554257492ad97",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7576ed9c5b6208a497a55cfbf4c7ba463a34cc4a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15134)
* 6d1ea73414d1ff772c402746dcb554257492ad97 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15186)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #7894: [HUDI-5729] Fix RowDataKeyGen method getRecordKey
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #7894:
URL: https://github.com/apache/hudi/pull/7894#issuecomment-1427565957
The CI tests failures seems not related, but let's re-trigger the tests again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #7894: [HUDI-5729]Fix RowDataKeyGen method getRecordKey
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #7894:
URL: https://github.com/apache/hudi/pull/7894#discussion_r1103538269
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bulk/RowDataKeyGen.java:
##########
@@ -153,10 +159,10 @@ public String getRecordKey(RowData rowData) {
// for e.g, fileId + auto inc integer
return EMPTY_RECORDKEY_PLACEHOLDER;
} else if (this.simpleRecordKey) {
- return getRecordKey(recordKeyFieldGetter.getFieldOrNull(rowData), this.recordKeyFields[0]);
+ return getRecordKey(recordKeyFieldGetter.getFieldOrNull(rowData), this.recordKeyFields[0],consistentLogicalTimestampEnabled);
} else {
Object[] keyValues = this.recordKeyProjection.projectAsValues(rowData);
- return getRecordKey(keyValues, this.recordKeyFields);
+ return getRecordKey(keyValues, this.recordKeyFields,consistentLogicalTimestampEnabled);
}
Review Comment:
Remember to add ` ` before all the `,`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #7894: [HUDI-5729]Fix RowDataKeyGen method getRecordKey
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #7894:
URL: https://github.com/apache/hudi/pull/7894#discussion_r1103538356
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bulk/RowDataKeyGen.java:
##########
@@ -173,12 +179,14 @@ public String getPartitionPath(RowData rowData) {
}
// reference: org.apache.hudi.keygen.KeyGenUtils.getRecordPartitionPath
- private static String getRecordKey(Object[] keyValues, String[] keyFields) {
+ private static String getRecordKey(Object[] keyValues, String[] keyFields,boolean consistentLogicalTimestampEnabled) {
Review Comment:
```suggestion
private static String getRecordKey(Object[] keyValues, String[] keyFields, boolean consistentLogicalTimestampEnabled) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7894: [HUDI-5729]Fix RowDataKeyGen method getRecordKey
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7894:
URL: https://github.com/apache/hudi/pull/7894#issuecomment-1425408235
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15037",
"triggerID" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"triggerType" : "PUSH"
}, {
"hash" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15087",
"triggerID" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f5abcc66d670acbf7543915f127c96bd7622e01e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15037)
* 536d75665ed7d98b9cd9477f776748b68a855e6b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15087)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7894: [HUDI-5729]Fix RowDataKeyGen method getRecordKey
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7894:
URL: https://github.com/apache/hudi/pull/7894#issuecomment-1423564610
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15037",
"triggerID" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f5abcc66d670acbf7543915f127c96bd7622e01e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15037)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7894: [HUDI-5729] Fix RowDataKeyGen method getRecordKey
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7894:
URL: https://github.com/apache/hudi/pull/7894#issuecomment-1434015997
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15037",
"triggerID" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"triggerType" : "PUSH"
}, {
"hash" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15087",
"triggerID" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"triggerType" : "PUSH"
}, {
"hash" : "a12f34765d09b2acd59e2186362ef24132f21607",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15110",
"triggerID" : "a12f34765d09b2acd59e2186362ef24132f21607",
"triggerType" : "PUSH"
}, {
"hash" : "3d5313695087d4198d4439201cdb2588b6df5e41",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15133",
"triggerID" : "3d5313695087d4198d4439201cdb2588b6df5e41",
"triggerType" : "PUSH"
}, {
"hash" : "7576ed9c5b6208a497a55cfbf4c7ba463a34cc4a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15134",
"triggerID" : "7576ed9c5b6208a497a55cfbf4c7ba463a34cc4a",
"triggerType" : "PUSH"
}, {
"hash" : "6d1ea73414d1ff772c402746dcb554257492ad97",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15186",
"triggerID" : "6d1ea73414d1ff772c402746dcb554257492ad97",
"triggerType" : "PUSH"
}, {
"hash" : "ddc28f53801f2e11401738d1c6acb74eec9c8fab",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15195",
"triggerID" : "ddc28f53801f2e11401738d1c6acb74eec9c8fab",
"triggerType" : "PUSH"
}, {
"hash" : "3cb6100b26cc838b555ad8ddd979408d52c98ecb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15260",
"triggerID" : "3cb6100b26cc838b555ad8ddd979408d52c98ecb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ddc28f53801f2e11401738d1c6acb74eec9c8fab Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15195)
* 3cb6100b26cc838b555ad8ddd979408d52c98ecb Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15260)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] sandyfog commented on a diff in pull request #7894: [HUDI-5729] Fix RowDataKeyGen method getRecordKey
Posted by "sandyfog (via GitHub)" <gi...@apache.org>.
sandyfog commented on code in PR #7894:
URL: https://github.com/apache/hudi/pull/7894#discussion_r1106708076
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/sink/bulk/TestRowDataKeyGen.java:
##########
@@ -191,6 +192,8 @@ void testPrimaryKeylessWrite() {
@Test
void testRecoredKeyContainsTimestamp() {
+ TimeZone timeZone = TimeZone.getTimeZone("GMT+8");
+ TimeZone.setDefault(timeZone);
Configuration conf = TestConfigurations.getDefaultConf("path1");
Review Comment:
GET.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7894: [HUDI-5729]Fix RowDataKeyGen method getRecordKey
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7894:
URL: https://github.com/apache/hudi/pull/7894#issuecomment-1422282713
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15037",
"triggerID" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f5abcc66d670acbf7543915f127c96bd7622e01e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15037)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7894: [HUDI-5729]Fix RowDataKeyGen method getRecordKey
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7894:
URL: https://github.com/apache/hudi/pull/7894#issuecomment-1426780267
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15037",
"triggerID" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"triggerType" : "PUSH"
}, {
"hash" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15087",
"triggerID" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"triggerType" : "PUSH"
}, {
"hash" : "a12f34765d09b2acd59e2186362ef24132f21607",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15110",
"triggerID" : "a12f34765d09b2acd59e2186362ef24132f21607",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a12f34765d09b2acd59e2186362ef24132f21607 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15110)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #7894: [HUDI-5729] Fix RowDataKeyGen method getRecordKey
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #7894:
URL: https://github.com/apache/hudi/pull/7894#issuecomment-1429484584
There is a test failure: `TestRowDataKeyGen.testRecoredKeyContainsTimestamp:201`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7894: [HUDI-5729] Fix RowDataKeyGen method getRecordKey
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7894:
URL: https://github.com/apache/hudi/pull/7894#issuecomment-1427631370
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15037",
"triggerID" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"triggerType" : "PUSH"
}, {
"hash" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15087",
"triggerID" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"triggerType" : "PUSH"
}, {
"hash" : "a12f34765d09b2acd59e2186362ef24132f21607",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15110",
"triggerID" : "a12f34765d09b2acd59e2186362ef24132f21607",
"triggerType" : "PUSH"
}, {
"hash" : "3d5313695087d4198d4439201cdb2588b6df5e41",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15133",
"triggerID" : "3d5313695087d4198d4439201cdb2588b6df5e41",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a12f34765d09b2acd59e2186362ef24132f21607 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15110)
* 3d5313695087d4198d4439201cdb2588b6df5e41 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15133)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7894: [HUDI-5729]Fix RowDataKeyGen method getRecordKey
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7894:
URL: https://github.com/apache/hudi/pull/7894#issuecomment-1425399784
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15037",
"triggerID" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"triggerType" : "PUSH"
}, {
"hash" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f5abcc66d670acbf7543915f127c96bd7622e01e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15037)
* 536d75665ed7d98b9cd9477f776748b68a855e6b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7894: [HUDI-5729]Fix RowDataKeyGen method getRecordKey
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7894:
URL: https://github.com/apache/hudi/pull/7894#issuecomment-1425952715
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15037",
"triggerID" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"triggerType" : "PUSH"
}, {
"hash" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15087",
"triggerID" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 536d75665ed7d98b9cd9477f776748b68a855e6b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15087)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7894: [HUDI-5729] Fix RowDataKeyGen method getRecordKey
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7894:
URL: https://github.com/apache/hudi/pull/7894#issuecomment-1427620313
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15037",
"triggerID" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"triggerType" : "PUSH"
}, {
"hash" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15087",
"triggerID" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"triggerType" : "PUSH"
}, {
"hash" : "a12f34765d09b2acd59e2186362ef24132f21607",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15110",
"triggerID" : "a12f34765d09b2acd59e2186362ef24132f21607",
"triggerType" : "PUSH"
}, {
"hash" : "3d5313695087d4198d4439201cdb2588b6df5e41",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3d5313695087d4198d4439201cdb2588b6df5e41",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a12f34765d09b2acd59e2186362ef24132f21607 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15110)
* 3d5313695087d4198d4439201cdb2588b6df5e41 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #7894: [HUDI-5729] Fix RowDataKeyGen method getRecordKey
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #7894:
URL: https://github.com/apache/hudi/pull/7894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7894: [HUDI-5729] Fix RowDataKeyGen method getRecordKey
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7894:
URL: https://github.com/apache/hudi/pull/7894#issuecomment-1427712679
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15037",
"triggerID" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"triggerType" : "PUSH"
}, {
"hash" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15087",
"triggerID" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"triggerType" : "PUSH"
}, {
"hash" : "a12f34765d09b2acd59e2186362ef24132f21607",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15110",
"triggerID" : "a12f34765d09b2acd59e2186362ef24132f21607",
"triggerType" : "PUSH"
}, {
"hash" : "3d5313695087d4198d4439201cdb2588b6df5e41",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15133",
"triggerID" : "3d5313695087d4198d4439201cdb2588b6df5e41",
"triggerType" : "PUSH"
}, {
"hash" : "7576ed9c5b6208a497a55cfbf4c7ba463a34cc4a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15134",
"triggerID" : "7576ed9c5b6208a497a55cfbf4c7ba463a34cc4a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3d5313695087d4198d4439201cdb2588b6df5e41 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15133)
* 7576ed9c5b6208a497a55cfbf4c7ba463a34cc4a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15134)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7894: [HUDI-5729] Fix RowDataKeyGen method getRecordKey
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7894:
URL: https://github.com/apache/hudi/pull/7894#issuecomment-1433987598
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15037",
"triggerID" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"triggerType" : "PUSH"
}, {
"hash" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15087",
"triggerID" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"triggerType" : "PUSH"
}, {
"hash" : "a12f34765d09b2acd59e2186362ef24132f21607",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15110",
"triggerID" : "a12f34765d09b2acd59e2186362ef24132f21607",
"triggerType" : "PUSH"
}, {
"hash" : "3d5313695087d4198d4439201cdb2588b6df5e41",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15133",
"triggerID" : "3d5313695087d4198d4439201cdb2588b6df5e41",
"triggerType" : "PUSH"
}, {
"hash" : "7576ed9c5b6208a497a55cfbf4c7ba463a34cc4a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15134",
"triggerID" : "7576ed9c5b6208a497a55cfbf4c7ba463a34cc4a",
"triggerType" : "PUSH"
}, {
"hash" : "6d1ea73414d1ff772c402746dcb554257492ad97",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15186",
"triggerID" : "6d1ea73414d1ff772c402746dcb554257492ad97",
"triggerType" : "PUSH"
}, {
"hash" : "ddc28f53801f2e11401738d1c6acb74eec9c8fab",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15195",
"triggerID" : "ddc28f53801f2e11401738d1c6acb74eec9c8fab",
"triggerType" : "PUSH"
}, {
"hash" : "3cb6100b26cc838b555ad8ddd979408d52c98ecb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3cb6100b26cc838b555ad8ddd979408d52c98ecb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ddc28f53801f2e11401738d1c6acb74eec9c8fab Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15195)
* 3cb6100b26cc838b555ad8ddd979408d52c98ecb UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7894: [HUDI-5729]Fix RowDataKeyGen method getRecordKey
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7894:
URL: https://github.com/apache/hudi/pull/7894#issuecomment-1426705043
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15037",
"triggerID" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"triggerType" : "PUSH"
}, {
"hash" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15087",
"triggerID" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"triggerType" : "PUSH"
}, {
"hash" : "a12f34765d09b2acd59e2186362ef24132f21607",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15110",
"triggerID" : "a12f34765d09b2acd59e2186362ef24132f21607",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 536d75665ed7d98b9cd9477f776748b68a855e6b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15087)
* a12f34765d09b2acd59e2186362ef24132f21607 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15110)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] sandyfog commented on a diff in pull request #7894: [HUDI-5729]Fix RowDataKeyGen method getRecordKey
Posted by "sandyfog (via GitHub)" <gi...@apache.org>.
sandyfog commented on code in PR #7894:
URL: https://github.com/apache/hudi/pull/7894#discussion_r1103599741
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bulk/RowDataKeyGen.java:
##########
@@ -153,10 +159,10 @@ public String getRecordKey(RowData rowData) {
// for e.g, fileId + auto inc integer
return EMPTY_RECORDKEY_PLACEHOLDER;
} else if (this.simpleRecordKey) {
- return getRecordKey(recordKeyFieldGetter.getFieldOrNull(rowData), this.recordKeyFields[0]);
+ return getRecordKey(recordKeyFieldGetter.getFieldOrNull(rowData), this.recordKeyFields[0],consistentLogicalTimestampEnabled);
} else {
Object[] keyValues = this.recordKeyProjection.projectAsValues(rowData);
- return getRecordKey(keyValues, this.recordKeyFields);
+ return getRecordKey(keyValues, this.recordKeyFields,consistentLogicalTimestampEnabled);
}
Review Comment:
Thanks！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7894: [HUDI-5729]Fix RowDataKeyGen method getRecordKey
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7894:
URL: https://github.com/apache/hudi/pull/7894#issuecomment-1422271809
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f5abcc66d670acbf7543915f127c96bd7622e01e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7894: [HUDI-5729] Fix RowDataKeyGen method getRecordKey
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7894:
URL: https://github.com/apache/hudi/pull/7894#issuecomment-1430635877
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15037",
"triggerID" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"triggerType" : "PUSH"
}, {
"hash" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15087",
"triggerID" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"triggerType" : "PUSH"
}, {
"hash" : "a12f34765d09b2acd59e2186362ef24132f21607",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15110",
"triggerID" : "a12f34765d09b2acd59e2186362ef24132f21607",
"triggerType" : "PUSH"
}, {
"hash" : "3d5313695087d4198d4439201cdb2588b6df5e41",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15133",
"triggerID" : "3d5313695087d4198d4439201cdb2588b6df5e41",
"triggerType" : "PUSH"
}, {
"hash" : "7576ed9c5b6208a497a55cfbf4c7ba463a34cc4a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15134",
"triggerID" : "7576ed9c5b6208a497a55cfbf4c7ba463a34cc4a",
"triggerType" : "PUSH"
}, {
"hash" : "6d1ea73414d1ff772c402746dcb554257492ad97",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6d1ea73414d1ff772c402746dcb554257492ad97",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7576ed9c5b6208a497a55cfbf4c7ba463a34cc4a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15134)
* 6d1ea73414d1ff772c402746dcb554257492ad97 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #7894: [HUDI-5729] Fix RowDataKeyGen method getRecordKey
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #7894:
URL: https://github.com/apache/hudi/pull/7894#discussion_r1106606144
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/sink/bulk/TestRowDataKeyGen.java:
##########
@@ -191,6 +192,8 @@ void testPrimaryKeylessWrite() {
@Test
void testRecoredKeyContainsTimestamp() {
+ TimeZone timeZone = TimeZone.getTimeZone("GMT+8");
+ TimeZone.setDefault(timeZone);
Configuration conf = TestConfigurations.getDefaultConf("path1");
Review Comment:
Don't think we should do this `TimeZone.setDefault(timeZone);`, the code affects the entire JVM process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7894: [HUDI-5729] Fix RowDataKeyGen method getRecordKey
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7894:
URL: https://github.com/apache/hudi/pull/7894#issuecomment-1430844941
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15037",
"triggerID" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"triggerType" : "PUSH"
}, {
"hash" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15087",
"triggerID" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"triggerType" : "PUSH"
}, {
"hash" : "a12f34765d09b2acd59e2186362ef24132f21607",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15110",
"triggerID" : "a12f34765d09b2acd59e2186362ef24132f21607",
"triggerType" : "PUSH"
}, {
"hash" : "3d5313695087d4198d4439201cdb2588b6df5e41",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15133",
"triggerID" : "3d5313695087d4198d4439201cdb2588b6df5e41",
"triggerType" : "PUSH"
}, {
"hash" : "7576ed9c5b6208a497a55cfbf4c7ba463a34cc4a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15134",
"triggerID" : "7576ed9c5b6208a497a55cfbf4c7ba463a34cc4a",
"triggerType" : "PUSH"
}, {
"hash" : "6d1ea73414d1ff772c402746dcb554257492ad97",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15186",
"triggerID" : "6d1ea73414d1ff772c402746dcb554257492ad97",
"triggerType" : "PUSH"
}, {
"hash" : "ddc28f53801f2e11401738d1c6acb74eec9c8fab",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15195",
"triggerID" : "ddc28f53801f2e11401738d1c6acb74eec9c8fab",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6d1ea73414d1ff772c402746dcb554257492ad97 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15186)
* ddc28f53801f2e11401738d1c6acb74eec9c8fab Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15195)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7894: [HUDI-5729] Fix RowDataKeyGen method getRecordKey
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7894:
URL: https://github.com/apache/hudi/pull/7894#issuecomment-1430840211
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15037",
"triggerID" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"triggerType" : "PUSH"
}, {
"hash" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15087",
"triggerID" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"triggerType" : "PUSH"
}, {
"hash" : "a12f34765d09b2acd59e2186362ef24132f21607",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15110",
"triggerID" : "a12f34765d09b2acd59e2186362ef24132f21607",
"triggerType" : "PUSH"
}, {
"hash" : "3d5313695087d4198d4439201cdb2588b6df5e41",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15133",
"triggerID" : "3d5313695087d4198d4439201cdb2588b6df5e41",
"triggerType" : "PUSH"
}, {
"hash" : "7576ed9c5b6208a497a55cfbf4c7ba463a34cc4a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15134",
"triggerID" : "7576ed9c5b6208a497a55cfbf4c7ba463a34cc4a",
"triggerType" : "PUSH"
}, {
"hash" : "6d1ea73414d1ff772c402746dcb554257492ad97",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15186",
"triggerID" : "6d1ea73414d1ff772c402746dcb554257492ad97",
"triggerType" : "PUSH"
}, {
"hash" : "ddc28f53801f2e11401738d1c6acb74eec9c8fab",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ddc28f53801f2e11401738d1c6acb74eec9c8fab",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7576ed9c5b6208a497a55cfbf4c7ba463a34cc4a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15134)
* 6d1ea73414d1ff772c402746dcb554257492ad97 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15186)
* ddc28f53801f2e11401738d1c6acb74eec9c8fab UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7894: [HUDI-5729] Fix RowDataKeyGen method getRecordKey
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7894:
URL: https://github.com/apache/hudi/pull/7894#issuecomment-1427702503
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15037",
"triggerID" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"triggerType" : "PUSH"
}, {
"hash" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15087",
"triggerID" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"triggerType" : "PUSH"
}, {
"hash" : "a12f34765d09b2acd59e2186362ef24132f21607",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15110",
"triggerID" : "a12f34765d09b2acd59e2186362ef24132f21607",
"triggerType" : "PUSH"
}, {
"hash" : "3d5313695087d4198d4439201cdb2588b6df5e41",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15133",
"triggerID" : "3d5313695087d4198d4439201cdb2588b6df5e41",
"triggerType" : "PUSH"
}, {
"hash" : "7576ed9c5b6208a497a55cfbf4c7ba463a34cc4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7576ed9c5b6208a497a55cfbf4c7ba463a34cc4a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a12f34765d09b2acd59e2186362ef24132f21607 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15110)
* 3d5313695087d4198d4439201cdb2588b6df5e41 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15133)
* 7576ed9c5b6208a497a55cfbf4c7ba463a34cc4a UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] sandyfog commented on a diff in pull request #7894: [HUDI-5729] Fix RowDataKeyGen method getRecordKey
Posted by "sandyfog (via GitHub)" <gi...@apache.org>.
sandyfog commented on code in PR #7894:
URL: https://github.com/apache/hudi/pull/7894#discussion_r1104272567
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bulk/RowDataKeyGen.java:
##########
@@ -138,9 +142,11 @@ public static RowDataKeyGen instance(Configuration conf, RowType rowType) {
throw new HoodieKeyException("Initialize TimestampBasedAvroKeyGenerator error", e);
}
}
+ boolean consistentLogicalTimestampEnabled = conf.getBoolean(KeyGeneratorOptions.KEYGENERATOR_CONSISTENT_LOGICAL_TIMESTAMP_ENABLED.key(),
+ Boolean.parseBoolean(KeyGeneratorOptions.KEYGENERATOR_CONSISTENT_LOGICAL_TIMESTAMP_ENABLED.defaultValue()));
Review Comment:
Get.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] sandyfog commented on pull request #7894: [HUDI-5729]Fix RowDataKeyGen method getRecordKey
Posted by "sandyfog (via GitHub)" <gi...@apache.org>.
sandyfog commented on PR #7894:
URL: https://github.com/apache/hudi/pull/7894#issuecomment-1425580592
@danny0405 PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #7894: [HUDI-5729]Fix RowDataKeyGen method getRecordKey
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #7894:
URL: https://github.com/apache/hudi/pull/7894#discussion_r1103538332
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bulk/RowDataKeyGen.java:
##########
@@ -153,10 +159,10 @@ public String getRecordKey(RowData rowData) {
// for e.g, fileId + auto inc integer
return EMPTY_RECORDKEY_PLACEHOLDER;
} else if (this.simpleRecordKey) {
- return getRecordKey(recordKeyFieldGetter.getFieldOrNull(rowData), this.recordKeyFields[0]);
+ return getRecordKey(recordKeyFieldGetter.getFieldOrNull(rowData), this.recordKeyFields[0],consistentLogicalTimestampEnabled);
Review Comment:
```suggestion
return getRecordKey(recordKeyFieldGetter.getFieldOrNull(rowData), this.recordKeyFields[0], consistentLogicalTimestampEnabled);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7894: [HUDI-5729] Fix RowDataKeyGen method getRecordKey
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7894:
URL: https://github.com/apache/hudi/pull/7894#issuecomment-1427882316
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15037",
"triggerID" : "f5abcc66d670acbf7543915f127c96bd7622e01e",
"triggerType" : "PUSH"
}, {
"hash" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15087",
"triggerID" : "536d75665ed7d98b9cd9477f776748b68a855e6b",
"triggerType" : "PUSH"
}, {
"hash" : "a12f34765d09b2acd59e2186362ef24132f21607",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15110",
"triggerID" : "a12f34765d09b2acd59e2186362ef24132f21607",
"triggerType" : "PUSH"
}, {
"hash" : "3d5313695087d4198d4439201cdb2588b6df5e41",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15133",
"triggerID" : "3d5313695087d4198d4439201cdb2588b6df5e41",
"triggerType" : "PUSH"
}, {
"hash" : "7576ed9c5b6208a497a55cfbf4c7ba463a34cc4a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15134",
"triggerID" : "7576ed9c5b6208a497a55cfbf4c7ba463a34cc4a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7576ed9c5b6208a497a55cfbf4c7ba463a34cc4a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15134)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org