[GitHub] [iceberg] kbendick commented on a diff in pull request #4665: Docs:Modify the flink version from 0.11.1 to 0.15.0 and fix several errors.

[GitBox <gi...@apache.org>]

kbendick commented on code in PR #4665:
URL: https://github.com/apache/iceberg/pull/4665#discussion_r895292998


##########
docs/flink/flink-getting-started.md:
##########
@@ -44,14 +43,14 @@ Iceberg integration for Apache Flink is available for Flink versions 1.12, 1.13,
 
 ## Preparation when using Flink SQL Client
 
-To create iceberg table in flink, we recommend to use [Flink SQL Client](https://ci.apache.org/projects/flink/flink-docs-stable/dev/table/sqlClient.html) because it's easier for users to understand the concepts.
+To create iceberg table in flink, we recommend to use [Flink SQL Client](https://nightlies.apache.org/flink/flink-docs-release-1.15/docs/dev/table/sqlclient/) because it's easier for users to understand the concepts.

Review Comment:
   +1 to not using nightlies.
   
   Like Flink, we template our docs based on the Iceberg version now so it might be possible to do the same.
   
   Otherwise, it used to be the case that the “latest” version (latest Spark version supported etc) could be automatically updated when the site was deployed.
   
   So we might see if we can link to the correct version of the Flink docs, but otherwise the stable latest is better than nightlies imo.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org