[jira] [Commented] (MINIFICPP-513) RVO causing seg fault due to taking reference to transient

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MINIFICPP-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492733#comment-16492733 ] 

ASF GitHub Bot commented on MINIFICPP-513:
------------------------------------------

GitHub user phrocker opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/346

    MINIFICPP-513: Avoid rvalue ref and move semantics. let compiler take…

    … care of movement optimization
    
    Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    
    - [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] If applicable, have you updated the LICENSE file?
    - [ ] If applicable, have you updated the NOTICE file?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-513

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/346.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #346
    
----
commit e4e826dec56902bd7dabbb084e48a0bd35684a8c
Author: Marc Parisi <ph...@...>
Date:   2018-05-28T14:17:50Z

    MINIFICPP-513: Avoid rvalue ref and move semantics. let compiler take care of movement optimization

----


> RVO causing seg fault due to taking reference to transient 
> -----------------------------------------------------------
>
>                 Key: MINIFICPP-513
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-513
>             Project: NiFi MiNiFi C++
>          Issue Type: Bug
>            Reporter: marco polo
>            Assignee: marco polo
>            Priority: Major
>
> RVO causing seg fault due to taking reference to transient on certain compilers. Additionally, during profiling found that elision was prevented, so we should avoid using the rvalue reference for the return and move semantics and let the compiler take care of the optimization. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)