You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Madhuvanthi Radhakrishnan <mr...@hortonworks.com> on 2017/03/20 22:02:05 UTC
Review Request 57795: While generating hash for ambari-server to fill
agent cache, all the symlinks should be traversed too.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57795/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit Mohanty.
Bugs: AMBARI-20512
https://issues.apache.org/jira/browse/AMBARI-20512
Repository: ambari
Description
-------
the archive.zip and .hash is not getting generated on the server side when the package folder is under
stacks/<stack-name>/<stack-version>/services/<service-name>/package
instead of common-services/<service-name>/<service-version>/package
On closer look, the issue was that when the directories are being traversed to look for hooks and package folders that need to be hashed/archived for having it in the agent cache, those directories that were symlinks were being skipped.
Fix is to include them.
Diffs
-----
ambari-server/src/main/python/ambari_server/resourceFilesKeeper.py baf8179
Diff: https://reviews.apache.org/r/57795/diff/1/
Testing
-------
Tested using a management pack
Thanks,
Madhuvanthi Radhakrishnan
Re: Review Request 57795: While generating hash for ambari-server to
fill agent cache, all the symlinks should be traversed too.
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57795/#review169517
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/main/python/ambari_server/resourceFilesKeeper.py
Line 79 (original), 79 (patched)
<https://reviews.apache.org/r/57795/#comment241876>
Small nitpick, put a space after the comma
- Alejandro Fernandez
On March 20, 2017, 10:02 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57795/
> -----------------------------------------------------------
>
> (Updated March 20, 2017, 10:02 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20512
> https://issues.apache.org/jira/browse/AMBARI-20512
>
>
> Repository: ambari
>
>
> Description
> -------
>
> the archive.zip and .hash is not getting generated on the server side when the package folder is under
> stacks/<stack-name>/<stack-version>/services/<service-name>/package
> instead of common-services/<service-name>/<service-version>/package
> On closer look, the issue was that when the directories are being traversed to look for hooks and package folders that need to be hashed/archived for having it in the agent cache, those directories that were symlinks were being skipped.
> Fix is to include them.
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari_server/resourceFilesKeeper.py baf8179
>
>
> Diff: https://reviews.apache.org/r/57795/diff/1/
>
>
> Testing
> -------
>
> Tested using a management pack
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 57795: While generating hash for ambari-server to
fill agent cache, all the symlinks should be traversed too.
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57795/#review169578
-----------------------------------------------------------
Ship it!
Ship It!
- Jayush Luniya
On March 21, 2017, 12:27 a.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57795/
> -----------------------------------------------------------
>
> (Updated March 21, 2017, 12:27 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20512
> https://issues.apache.org/jira/browse/AMBARI-20512
>
>
> Repository: ambari
>
>
> Description
> -------
>
> the archive.zip and .hash is not getting generated on the server side when the package folder is under
> stacks/<stack-name>/<stack-version>/services/<service-name>/package
> instead of common-services/<service-name>/<service-version>/package
> On closer look, the issue was that when the directories are being traversed to look for hooks and package folders that need to be hashed/archived for having it in the agent cache, those directories that were symlinks were being skipped.
> Fix is to include them.
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari_server/resourceFilesKeeper.py baf8179
>
>
> Diff: https://reviews.apache.org/r/57795/diff/2/
>
>
> Testing
> -------
>
> Tested using a management pack
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 57795: While generating hash for ambari-server to
fill agent cache, all the symlinks should be traversed too.
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57795/
-----------------------------------------------------------
(Updated March 21, 2017, 12:27 a.m.)
Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit Mohanty.
Bugs: AMBARI-20512
https://issues.apache.org/jira/browse/AMBARI-20512
Repository: ambari
Description
-------
the archive.zip and .hash is not getting generated on the server side when the package folder is under
stacks/<stack-name>/<stack-version>/services/<service-name>/package
instead of common-services/<service-name>/<service-version>/package
On closer look, the issue was that when the directories are being traversed to look for hooks and package folders that need to be hashed/archived for having it in the agent cache, those directories that were symlinks were being skipped.
Fix is to include them.
Diffs (updated)
-----
ambari-server/src/main/python/ambari_server/resourceFilesKeeper.py baf8179
Diff: https://reviews.apache.org/r/57795/diff/2/
Changes: https://reviews.apache.org/r/57795/diff/1-2/
Testing
-------
Tested using a management pack
Thanks,
Madhuvanthi Radhakrishnan