You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "devmadhuu (via GitHub)" <gi...@apache.org> on 2023/11/24 07:09:43 UTC
[PR] HDDS-3438. Enable TestContainerServer test cases. [ozone]
devmadhuu opened a new pull request, #5667:
URL: https://github.com/apache/ozone/pull/5667
## What changes were proposed in this pull request?
This PR is to allow running test cases of `TestContainerServer` class, as they were marked `slow` and some `unhealthy`. In earlier written test case, some of the inputs to `testClientServerWithContainerDispatcher` like volumeSet and config like `hdds.datanode.dir` were not set correctly due to which the test was failing and it was failing after running and retrying for more than 2 mins. This PR has improved that corrected the test case.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3438
## How was this patch tested?
Since this PR is to allow and enable running of test cases of `TestContainerServer` class, the test class has been tested using running multiple times and it passed successfully without any significant delay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-3438. Enable TestContainerServer test cases. [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5667:
URL: https://github.com/apache/ozone/pull/5667#issuecomment-1826841471
@devmadhuu can you please post link to repeated CI runs of `TestContainerServer` for reference?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-3438. Fix and enable TestContainerServer#testClientServerWithContainerDispatcher [ozone]
Posted by "devmadhuu (via GitHub)" <gi...@apache.org>.
devmadhuu commented on code in PR #5667:
URL: https://github.com/apache/ozone/pull/5667#discussion_r1406260230
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/container/server/TestContainerServer.java:
##########
@@ -74,7 +80,6 @@
import org.apache.ozone.test.tag.Slow;
Review Comment:
Thanks @adoroszlai for review. I have removed the `@Slow` annotation and re-run repeated flaky flow. Here is the [link](https://github.com/devmadhuu/ozone/actions/runs/7005783846)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-3438. Fix and enable TestContainerServer#testClientServerWithContainerDispatcher [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #5667:
URL: https://github.com/apache/ozone/pull/5667#discussion_r1406037075
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/container/server/TestContainerServer.java:
##########
@@ -74,7 +80,6 @@
import org.apache.ozone.test.tag.Slow;
Review Comment:
To fully enable this test class, we also need to remove `@Slow` (and its import). It doesn't seem to be slow anymore (runs in ~30 seconds in CI and locally).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-3438. Fix and enable TestContainerServer#testClientServerWithContainerDispatcher [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #5667:
URL: https://github.com/apache/ozone/pull/5667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-3438. Enable TestContainerServer test cases. [ozone]
Posted by "devmadhuu (via GitHub)" <gi...@apache.org>.
devmadhuu commented on PR #5667:
URL: https://github.com/apache/ozone/pull/5667#issuecomment-1825234057
@adoroszlai pls review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-3438. Enable TestContainerServer test cases. [ozone]
Posted by "devmadhuu (via GitHub)" <gi...@apache.org>.
devmadhuu commented on PR #5667:
URL: https://github.com/apache/ozone/pull/5667#issuecomment-1827089487
> @devmadhuu can you please post link to repeated CI runs of `TestContainerServer` for reference?
Thanks @adoroszlai for review. Here is the [link](https://github.com/devmadhuu/ozone/actions/runs/6971115590) for repeated CI runs of `TestContainerServer`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org