[GitHub] rhtyd commented on a change in pull request #2454: CLOUDSTACK-10283: Sudo to setup agent keystore, fail on host add failure

[GitBox <gi...@apache.org>]

rhtyd commented on a change in pull request #2454: CLOUDSTACK-10283: Sudo to setup agent keystore, fail on host add failure
URL: https://github.com/apache/cloudstack/pull/2454#discussion_r171580645
 
 

 ##########
 File path: agent/src/com/cloud/agent/Agent.java
 ##########
 @@ -647,7 +647,7 @@ public Answer setupAgentKeystore(final SetupKeyStoreCommand cmd) {
             _shell.setPersistentProperty(null, KeyStoreUtils.passphrasePropertyName, storedPassword);
         }
 
-        Script script = new Script(_keystoreSetupPath, 60000, s_logger);
+        Script script = new Script(true, _keystoreSetupPath, 60000, s_logger);
 
 Review comment:
   @krissterckx this runs the script with sudo (when true is passed). It allows admins to add a KVM host using a non-root sudoer user (see for details https://cwiki.apache.org/confluence/display/CLOUDSTACK/Allow+non-root+user+to+add+KVM+hypervisor)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services