You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2018/12/25 13:50:53 UTC

[GitHub] xuanyuanking opened a new pull request #23378: [SPARK-26225][SQL] Track decoding time for each record in scan node

xuanyuanking opened a new pull request #23378: [SPARK-26225][SQL] Track decoding time for each record in scan node
URL: https://github.com/apache/spark/pull/23378
 
 
   ## What changes were proposed in this pull request?
   
   Considering code and logic clean as well as overhead minimize, here we report total decoding time of all records in the current scan node by wrapping FileFormat.buildReaderWithPartitionValues. Detailed scenario list in the [Jira comment](https://issues.apache.org/jira/browse/SPARK-26225?focusedCommentId=16728620&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16728620).
   
   ## How was this patch tested?
   New test in SQLMetricsSuite for record decoding time metric.
   Manually test locally:
   ![image](https://user-images.githubusercontent.com/4833765/50423316-b9f91d80-088e-11e9-8fd8-ae03ecdf9938.png)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org