You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "justinpark (via GitHub)" <gi...@apache.org> on 2023/06/13 00:37:44 UTC
[GitHub] [superset] justinpark opened a new pull request, #24371: chore(sqllab): Remove table metadata from state
justinpark opened a new pull request, #24371:
URL: https://github.com/apache/superset/pull/24371
### SUMMARY
Similar to https://github.com/apache/superset/pull/23488, https://github.com/apache/superset/pull/23257 and https://github.com/apache/superset/pull/24082, this commit migrates the table metadata(and extra metadata) state from redux to rdk-query to reduce the complexity of the sqlLab state.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
<img width="381" alt="Screenshot 2023-06-12 at 4 18 37 PM" src="https://github.com/apache/superset/assets/1392866/bb754707-9f80-4558-9a30-fd4b9baa5627">
Before:
<img width="525" alt="Screenshot 2023-06-12 at 5 37 10 PM" src="https://github.com/apache/superset/assets/1392866/b64cdd65-d5ee-4661-be38-7599f228c211">
### TESTING INSTRUCTIONS
Go to sqllab and select/remove table options from the left menu
check the table metadata including columns and indices
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sadpandajoe commented on pull request #24371: chore(sqllab): Remove table metadata from state
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on PR #24371:
URL: https://github.com/apache/superset/pull/24371#issuecomment-1624011349
Looks like this PR has a regression that affects auto-complete in sql lab if someone is using this feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark merged pull request #24371: chore(sqllab): Remove table metadata from state
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark merged PR #24371:
URL: https://github.com/apache/superset/pull/24371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24371: chore(sqllab): Remove table metadata from state
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24371:
URL: https://github.com/apache/superset/pull/24371#issuecomment-1588439108
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24371?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24371](https://app.codecov.io/gh/apache/superset/pull/24371?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e7a302f) into [master](https://app.codecov.io/gh/apache/superset/commit/2b364898a529b1c8121c381085a894a7e75413b9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (2b36489) will **increase** coverage by `0.00%`.
> The diff coverage is `76.05%`.
> :exclamation: Current head e7a302f differs from pull request most recent head cdde50b. Consider uploading reports for the commit cdde50b to get more accurate results
```diff
@@ Coverage Diff @@
## master #24371 +/- ##
=======================================
Coverage 69.04% 69.05%
=======================================
Files 1903 1903
Lines 74533 74566 +33
Branches 8109 8114 +5
=======================================
+ Hits 51463 51491 +28
- Misses 20958 20966 +8
+ Partials 2112 2109 -3
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `55.66% <76.05%> (+0.04%)` | :arrow_up: |
| postgres | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://app.codecov.io/gh/apache/superset/pull/24371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (ø)` | |
| [...d/src/SqlLab/components/AceEditorWrapper/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIvaW5kZXgudHN4) | `67.07% <0.00%> (ø)` | |
| [...frontend/src/SqlLab/components/SqlEditor/index.jsx](https://app.codecov.io/gh/apache/superset/pull/24371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci9pbmRleC5qc3g=) | `59.88% <ø> (ø)` | |
| [...src/SqlLab/utils/reduxStateToLocalStorageHelper.js](https://app.codecov.io/gh/apache/superset/pull/24371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi91dGlscy9yZWR1eFN0YXRlVG9Mb2NhbFN0b3JhZ2VIZWxwZXIuanM=) | `80.00% <0.00%> (-20.00%)` | :arrow_down: |
| [...end/src/components/Datasource/DatasourceEditor.jsx](https://app.codecov.io/gh/apache/superset/pull/24371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YXNvdXJjZS9EYXRhc291cmNlRWRpdG9yLmpzeA==) | `65.35% <ø> (ø)` | |
| [...perset-frontend/src/hooks/apiResources/queryApi.ts](https://app.codecov.io/gh/apache/superset/pull/24371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2hvb2tzL2FwaVJlc291cmNlcy9xdWVyeUFwaS50cw==) | `100.00% <ø> (ø)` | |
| [...d/src/SqlLab/components/SqlEditorLeftBar/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIvaW5kZXgudHN4) | `62.12% <50.00%> (ø)` | |
| [...ntend/src/SqlLab/components/TableElement/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC9pbmRleC50c3g=) | `81.92% <73.07%> (+8.01%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://app.codecov.io/gh/apache/superset/pull/24371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `69.89% <93.75%> (+0.45%)` | :arrow_up: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://app.codecov.io/gh/apache/superset/pull/24371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `91.66% <100.00%> (+1.04%)` | :arrow_up: |
| ... and [2 more](https://app.codecov.io/gh/apache/superset/pull/24371?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [14 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24371/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org