[GitHub] [accumulo] cshannon commented on a diff in pull request #3129: Replace copied HostAndPort with guava

[GitBox <gi...@apache.org>]

cshannon commented on code in PR #3129:
URL: https://github.com/apache/accumulo/pull/3129#discussion_r1050657191


##########
server/base/src/main/java/org/apache/accumulo/server/util/VerifyTabletAssignments.java:
##########
@@ -95,7 +97,10 @@ private static void checkTable(final ClientContext context, final boolean verbos
 
     final HashSet<KeyExtent> failures = new HashSet<>();
 
-    Map<HostAndPort,List<KeyExtent>> extentsPerServer = new TreeMap<>();
+    Comparator<HostAndPort> comparator = Comparator.nullsFirst(

Review Comment:
   You should be able to make this static and create it just one time in the class and reuse the comparator just like we were doing originally in the copied version. It might be better to even have it in a public utility class somewhere so we could re-use it elsewhere if needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org