You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Darryl L. Pierce (JIRA)" <ji...@apache.org> on 2011/05/27 15:08:47 UTC
[jira] [Created] (QPID-3284) Removed unused variables, which caused
the build to break under GCC 4.6
Removed unused variables, which caused the build to break under GCC 4.6
-----------------------------------------------------------------------
Key: QPID-3284
URL: https://issues.apache.org/jira/browse/QPID-3284
Project: Qpid
Issue Type: Improvement
Components: C++ Broker
Affects Versions: 0.10
Environment: Fedora 15 x86_64.
Reporter: Darryl L. Pierce
Priority: Blocker
Fix For: Future
There were several variables that were declared and assigned values but whose values were not used. This caused GCC 4.6.0 to raise a warning, which causes the build to stop.
This patch removes those unused variables.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3284) Removed unused variables, which caused
the build to break under GCC 4.6
Posted by "Darryl L. Pierce (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Darryl L. Pierce updated QPID-3284:
-----------------------------------
Attachment: 0001-Removed-unused-variables.patch
Git patch to remove unused variables.
> Removed unused variables, which caused the build to break under GCC 4.6
> -----------------------------------------------------------------------
>
> Key: QPID-3284
> URL: https://issues.apache.org/jira/browse/QPID-3284
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Affects Versions: 0.10
> Environment: Fedora 15 x86_64.
> Reporter: Darryl L. Pierce
> Priority: Blocker
> Fix For: Future
>
> Attachments: 0001-Removed-unused-variables.patch
>
>
> There were several variables that were declared and assigned values but whose values were not used. This caused GCC 4.6.0 to raise a warning, which causes the build to stop.
> This patch removes those unused variables.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3284) Removed unused variables, which
caused the build to break under GCC 4.6
Posted by "Ted Ross (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Ross reassigned QPID-3284:
------------------------------
Assignee: Andrew Stitcher (was: Ted Ross)
> Removed unused variables, which caused the build to break under GCC 4.6
> -----------------------------------------------------------------------
>
> Key: QPID-3284
> URL: https://issues.apache.org/jira/browse/QPID-3284
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Affects Versions: 0.10
> Environment: Fedora 15 x86_64.
> Reporter: Darryl L. Pierce
> Assignee: Andrew Stitcher
> Priority: Blocker
> Fix For: Future
>
> Attachments: 0001-Removed-unused-variables.patch, 0001-Removed-unused-variables.patch
>
>
> There were several variables that were declared and assigned values but whose values were not used. This caused GCC 4.6.0 to raise a warning, which causes the build to stop.
> This patch removes those unused variables.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3284) Removed unused variables, which
caused the build to break under GCC 4.6
Posted by "Chuck Rolke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040222#comment-13040222 ]
Chuck Rolke commented on QPID-3284:
-----------------------------------
This patch appears to re-install warnings for other users. Specifically:
- int unused_ret;
- unused_ret = ::lockf(f, F_ULOCK, 0); // Suppress warnings about ignoring return value.
+ ::lockf(f, F_ULOCK, 0); // Suppress warnings about ignoring return value.
The return value is now ignored again.
I'd suggest Holtzmann's Rule 7 in http://spinroot.com/gerard/pdf/P10.pdf
Cast the result as void. The patches would read:
+ (void) ::lockf(f, F_ULOCK, 0);
Both problems solved.
> Removed unused variables, which caused the build to break under GCC 4.6
> -----------------------------------------------------------------------
>
> Key: QPID-3284
> URL: https://issues.apache.org/jira/browse/QPID-3284
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Affects Versions: 0.10
> Environment: Fedora 15 x86_64.
> Reporter: Darryl L. Pierce
> Priority: Blocker
> Fix For: Future
>
> Attachments: 0001-Removed-unused-variables.patch
>
>
> There were several variables that were declared and assigned values but whose values were not used. This caused GCC 4.6.0 to raise a warning, which causes the build to stop.
> This patch removes those unused variables.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Resolved] (QPID-3284) Removed unused variables, which
caused the build to break under GCC 4.6
Posted by "Andrew Stitcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Stitcher resolved QPID-3284.
-----------------------------------
Resolution: Fixed
Fix Version/s: (was: Future)
0.11
Committed as very similar but more extensive patch I was already working on.
> Removed unused variables, which caused the build to break under GCC 4.6
> -----------------------------------------------------------------------
>
> Key: QPID-3284
> URL: https://issues.apache.org/jira/browse/QPID-3284
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Affects Versions: 0.10
> Environment: Fedora 15 x86_64.
> Reporter: Darryl L. Pierce
> Assignee: Andrew Stitcher
> Priority: Blocker
> Fix For: 0.11
>
> Attachments: 0001-Removed-unused-variables.patch, 0001-Removed-unused-variables.patch
>
>
> There were several variables that were declared and assigned values but whose values were not used. This caused GCC 4.6.0 to raise a warning, which causes the build to stop.
> This patch removes those unused variables.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3284) Removed unused variables, which caused
the build to break under GCC 4.6
Posted by "Darryl L. Pierce (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Darryl L. Pierce updated QPID-3284:
-----------------------------------
Attachment: 0001-Removed-unused-variables.patch
Refactored patch.
> Removed unused variables, which caused the build to break under GCC 4.6
> -----------------------------------------------------------------------
>
> Key: QPID-3284
> URL: https://issues.apache.org/jira/browse/QPID-3284
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Affects Versions: 0.10
> Environment: Fedora 15 x86_64.
> Reporter: Darryl L. Pierce
> Assignee: Ted Ross
> Priority: Blocker
> Fix For: Future
>
> Attachments: 0001-Removed-unused-variables.patch, 0001-Removed-unused-variables.patch
>
>
> There were several variables that were declared and assigned values but whose values were not used. This caused GCC 4.6.0 to raise a warning, which causes the build to stop.
> This patch removes those unused variables.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3284) Removed unused variables, which
caused the build to break under GCC 4.6
Posted by "Darryl L. Pierce (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040247#comment-13040247 ]
Darryl L. Pierce commented on QPID-3284:
----------------------------------------
Thanks for the feedback. I've modified the patch and have resubmitted it.
> Removed unused variables, which caused the build to break under GCC 4.6
> -----------------------------------------------------------------------
>
> Key: QPID-3284
> URL: https://issues.apache.org/jira/browse/QPID-3284
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Affects Versions: 0.10
> Environment: Fedora 15 x86_64.
> Reporter: Darryl L. Pierce
> Assignee: Ted Ross
> Priority: Blocker
> Fix For: Future
>
> Attachments: 0001-Removed-unused-variables.patch, 0001-Removed-unused-variables.patch
>
>
> There were several variables that were declared and assigned values but whose values were not used. This caused GCC 4.6.0 to raise a warning, which causes the build to stop.
> This patch removes those unused variables.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3284) Removed unused variables, which
caused the build to break under GCC 4.6
Posted by "Ted Ross (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Ross reassigned QPID-3284:
------------------------------
Assignee: Ted Ross
> Removed unused variables, which caused the build to break under GCC 4.6
> -----------------------------------------------------------------------
>
> Key: QPID-3284
> URL: https://issues.apache.org/jira/browse/QPID-3284
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Affects Versions: 0.10
> Environment: Fedora 15 x86_64.
> Reporter: Darryl L. Pierce
> Assignee: Ted Ross
> Priority: Blocker
> Fix For: Future
>
> Attachments: 0001-Removed-unused-variables.patch
>
>
> There were several variables that were declared and assigned values but whose values were not used. This caused GCC 4.6.0 to raise a warning, which causes the build to stop.
> This patch removes those unused variables.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org