You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "Aurélien Pupier (JIRA)" <ji...@apache.org> on 2017/08/03 06:13:00 UTC

[jira] [Created] (CAMEL-11625) Potential SQL injection in JdbcAggregationRepository

Aurélien Pupier created CAMEL-11625:
---------------------------------------

             Summary: Potential SQL injection in JdbcAggregationRepository
                 Key: CAMEL-11625
                 URL: https://issues.apache.org/jira/browse/CAMEL-11625
             Project: Camel
          Issue Type: Bug
          Components: camel-sql
            Reporter: Aurélien Pupier


Quoting Sonar:
"Applications that execute SQL commands should neutralize any externally-provided values used in those commands. Failure to do so could allow an attacker to include input that changes the query so that unintended commands are executed, or sensitive data is exposed."

it is the case at 2 places:
https://github.com/apache/camel/blame/master/components/camel-sql/src/main/java/org/apache/camel/processor/aggregate/jdbc/JdbcAggregationRepository.java#L288
https://github.com/apache/camel/blame/master/components/camel-sql/src/main/java/org/apache/camel/processor/aggregate/jdbc/JdbcAggregationRepository.java#L357

the only variable thing is the "repositoryName" so maybe there are some validation previously which will avoid to users to inject sql code or it is something that only the Camel developer can configure?

even if it is the case, it might be a good idea to use some "preparedStatement" to avoid sql injection in case previous assumptions are no more true

I reported here because I didn't see any "security" options on the Camel open source JIRA.





--
This message was sent by Atlassian JIRA
(v6.4.14#64029)