You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/10 09:43:37 UTC

[GitHub] [dolphinscheduler] EricGao888 commented on pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)

EricGao888 commented on PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#issuecomment-1210427084

   BTW, there are two ways to fully migrate those tests from jUnit 4 to jUnit 5:
   
   1. We keep both versions of jUnit dependencies and migrate those UTs gradually with `DSIP-10` #10573.  
   2. Remove the dependency of jUnit 4 and migrate all the UTs with IDE `inspections` in this PR.
   
   However, I think the second method is a bit risky. 
   
   WDYT? @caishunfeng @kezhenxu94 @SbloodyS @ruanwenjun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org