You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2015/07/16 13:10:03 UTC
Review Request 36543: LENS-669 : Add queryId in LogSegregationContext
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36543/
-----------------------------------------------------------
Review request for lens and Himanshu Gahlaut.
Bugs: LENS-669
https://issues.apache.org/jira/browse/LENS-669
Repository: lens
Description
-------
Initial patch for review.
Diffs
-----
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java e048a78
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 1334d9a
lens-server-api/src/main/java/org/apache/lens/server/model/LogSegregationContext.java 8691a05
lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java 989cb9d
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java df36a21
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3511236
lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java c526c02
Diff: https://reviews.apache.org/r/36543/diff/
Testing
-------
Pending.
Thanks,
Amareshwari Sriramadasu
Re: Review Request 36543: LENS-669 : Add queryId in
LogSegregationContext
Posted by Himanshu Gahlaut <ga...@gmail.com>.
> On July 16, 2015, 11:30 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java, lines 40-41
> > <https://reviews.apache.org/r/36543/diff/1/?file=1013262#file1013262line40>
> >
> > Setting LOG_SEGREGATION_ID from setQueryId, as all the callers will set it as LOG_SEGREGATION_ID as well.
We can rename methods in LogSegrationContext interface to align more with what they do internally:
setLogSegragationId(String id): only sets log segragation id
setQueryId(String id): only sets query id
setLogSegragationAndQueryId(String id): internally calls both setLogSegrationId and setQueryId
- Himanshu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36543/#review91879
-----------------------------------------------------------
On July 16, 2015, 11:10 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36543/
> -----------------------------------------------------------
>
> (Updated July 16, 2015, 11:10 a.m.)
>
>
> Review request for lens and Himanshu Gahlaut.
>
>
> Bugs: LENS-669
> https://issues.apache.org/jira/browse/LENS-669
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for review.
>
>
> Diffs
> -----
>
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java e048a78
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 1334d9a
> lens-server-api/src/main/java/org/apache/lens/server/model/LogSegregationContext.java 8691a05
> lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java 989cb9d
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java df36a21
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3511236
> lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java c526c02
>
> Diff: https://reviews.apache.org/r/36543/diff/
>
>
> Testing
> -------
>
> Pending.
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 36543: LENS-669 : Add queryId in
LogSegregationContext
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36543/#review91879
-----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java (lines 40 - 41)
<https://reviews.apache.org/r/36543/#comment145582>
Setting LOG_SEGREGATION_ID from setQueryId, as all the callers will set it as LOG_SEGREGATION_ID as well.
- Amareshwari Sriramadasu
On July 16, 2015, 11:10 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36543/
> -----------------------------------------------------------
>
> (Updated July 16, 2015, 11:10 a.m.)
>
>
> Review request for lens and Himanshu Gahlaut.
>
>
> Bugs: LENS-669
> https://issues.apache.org/jira/browse/LENS-669
>
>
> Repository: lens
>
>
> Description
> -------
>
> Initial patch for review.
>
>
> Diffs
> -----
>
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java e048a78
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 1334d9a
> lens-server-api/src/main/java/org/apache/lens/server/model/LogSegregationContext.java 8691a05
> lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java 989cb9d
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java df36a21
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3511236
> lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java c526c02
>
> Diff: https://reviews.apache.org/r/36543/diff/
>
>
> Testing
> -------
>
> Pending.
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 36543: LENS-669 : Add queryId in
LogSegregationContext
Posted by Himanshu Gahlaut <ga...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36543/#review92069
-----------------------------------------------------------
Ship it!
Ship It!
- Himanshu Gahlaut
On July 17, 2015, 10:21 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36543/
> -----------------------------------------------------------
>
> (Updated July 17, 2015, 10:21 a.m.)
>
>
> Review request for lens and Himanshu Gahlaut.
>
>
> Bugs: LENS-669
> https://issues.apache.org/jira/browse/LENS-669
>
>
> Repository: lens
>
>
> Description
> -------
>
> Adds queryId in LogSegregationContext
>
>
> Diffs
> -----
>
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java e048a78
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 1334d9a
> lens-server-api/src/main/java/org/apache/lens/server/model/LogSegregationContext.java 8691a05
> lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java 989cb9d
> lens-server-api/src/test/java/org/apache/lens/server/api/query/MockQueryContext.java 5a1ab66
> lens-server-api/src/test/java/org/apache/lens/server/model/TestMappedDiagnosticLogSegregationContext.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/LensRequestContextInitFilter.java c9658fc
> lens-server/src/main/java/org/apache/lens/server/LensServer.java d3dfad4
> lens-server/src/main/java/org/apache/lens/server/LensServices.java 5fe3935
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java df36a21
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3511236
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 19ed94a
> lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java c526c02
> lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogFileScannerTask.java 7e9c74d
>
> Diff: https://reviews.apache.org/r/36543/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.866s]
> [INFO] Lens .............................................. SUCCESS [2.984s]
> [INFO] Lens API .......................................... SUCCESS [21.006s]
> [INFO] Lens API for server and extensions ................ SUCCESS [17.446s]
> [INFO] Lens Cube ......................................... SUCCESS [4:11.677s]
> [INFO] Lens DB storage ................................... SUCCESS [18.454s]
> [INFO] Lens Query Library ................................ SUCCESS [14.987s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:48.217s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [34.716s]
> [INFO] Lens Server ....................................... SUCCESS [5:30.733s]
> [INFO] Lens client ....................................... SUCCESS [34.754s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.758s]
> [INFO] Lens Examples ..................................... SUCCESS [8.658s]
> [INFO] Lens Distribution ................................. SUCCESS [8.553s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:22.418s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.957s]
> [INFO] Lens Regression ................................... SUCCESS [9.336s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:24.369s
> [INFO] Finished at: Fri Jul 17 10:10:39 UTC 2015
> [INFO] Final Memory: 192M/2369M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 36543: LENS-669 : Add queryId in
LogSegregationContext
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36543/
-----------------------------------------------------------
(Updated July 17, 2015, 10:21 a.m.)
Review request for lens and Himanshu Gahlaut.
Bugs: LENS-669
https://issues.apache.org/jira/browse/LENS-669
Repository: lens
Description (updated)
-------
Adds queryId in LogSegregationContext
Diffs (updated)
-----
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java e048a78
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 1334d9a
lens-server-api/src/main/java/org/apache/lens/server/model/LogSegregationContext.java 8691a05
lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java 989cb9d
lens-server-api/src/test/java/org/apache/lens/server/api/query/MockQueryContext.java 5a1ab66
lens-server-api/src/test/java/org/apache/lens/server/model/TestMappedDiagnosticLogSegregationContext.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/LensRequestContextInitFilter.java c9658fc
lens-server/src/main/java/org/apache/lens/server/LensServer.java d3dfad4
lens-server/src/main/java/org/apache/lens/server/LensServices.java 5fe3935
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java df36a21
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 3511236
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 19ed94a
lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java c526c02
lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogFileScannerTask.java 7e9c74d
Diff: https://reviews.apache.org/r/36543/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.866s]
[INFO] Lens .............................................. SUCCESS [2.984s]
[INFO] Lens API .......................................... SUCCESS [21.006s]
[INFO] Lens API for server and extensions ................ SUCCESS [17.446s]
[INFO] Lens Cube ......................................... SUCCESS [4:11.677s]
[INFO] Lens DB storage ................................... SUCCESS [18.454s]
[INFO] Lens Query Library ................................ SUCCESS [14.987s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:48.217s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [34.716s]
[INFO] Lens Server ....................................... SUCCESS [5:30.733s]
[INFO] Lens client ....................................... SUCCESS [34.754s]
[INFO] Lens CLI .......................................... SUCCESS [2:35.758s]
[INFO] Lens Examples ..................................... SUCCESS [8.658s]
[INFO] Lens Distribution ................................. SUCCESS [8.553s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:22.418s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.957s]
[INFO] Lens Regression ................................... SUCCESS [9.336s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:24.369s
[INFO] Finished at: Fri Jul 17 10:10:39 UTC 2015
[INFO] Final Memory: 192M/2369M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu