You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2019/11/19 00:53:41 UTC
[Impala-ASF-CR] IMPALA-8867: Further deflake test auto scaling
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14740
Change subject: IMPALA-8867: Further deflake test_auto_scaling
......................................................................
IMPALA-8867: Further deflake test_auto_scaling
A previous attempt to deflake this test by lowering the threshold for
multi-group throughput had improved things but we still saw another
occurrence of test_auto_scaling failing recently. This change lowers the
threshold even further to try and eradicate the flakiness. From
inspecting the logs of the failed run I could see that the new threshold
would have prevented the failure.
Change-Id: I29808982cc6226152c544cb99f76961b582975a7
---
M tests/custom_cluster/test_auto_scaling.py
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/14740/1
--
To view, visit http://gerrit.cloudera.org:8080/14740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I29808982cc6226152c544cb99f76961b582975a7
Gerrit-Change-Number: 14740
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-8867: Further deflake test auto scaling
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14740
to look at the new patch set (#2).
Change subject: IMPALA-8867: Further deflake test_auto_scaling
......................................................................
IMPALA-8867: Further deflake test_auto_scaling
A previous attempt to deflake this test by lowering the threshold for
multi-group throughput had improved things but we still saw another
occurrence of test_auto_scaling failing recently. This change lowers the
threshold even further to try and eradicate the flakiness. From
inspecting the logs of the failed run I could see that the new threshold
would have prevented the failure.
Change-Id: I29808982cc6226152c544cb99f76961b582975a7
---
M tests/custom_cluster/test_auto_scaling.py
1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/14740/2
--
To view, visit http://gerrit.cloudera.org:8080/14740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I29808982cc6226152c544cb99f76961b582975a7
Gerrit-Change-Number: 14740
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-8867: Further deflake test auto scaling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14740 )
Change subject: IMPALA-8867: Further deflake test_auto_scaling
......................................................................
IMPALA-8867: Further deflake test_auto_scaling
A previous attempt to deflake this test by lowering the threshold for
multi-group throughput had improved things but we still saw another
occurrence of test_auto_scaling failing recently. This change lowers the
threshold even further to try and eradicate the flakiness. From
inspecting the logs of the failed run I could see that the new threshold
would have prevented the failure.
Change-Id: I29808982cc6226152c544cb99f76961b582975a7
Reviewed-on: http://gerrit.cloudera.org:8080/14740
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/custom_cluster/test_auto_scaling.py
1 file changed, 5 insertions(+), 3 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
Lars Volker: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I29808982cc6226152c544cb99f76961b582975a7
Gerrit-Change-Number: 14740
Gerrit-PatchSet: 8
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-8867: Further deflake test auto scaling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14740 )
Change subject: IMPALA-8867: Further deflake test_auto_scaling
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5087/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29808982cc6226152c544cb99f76961b582975a7
Gerrit-Change-Number: 14740
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2019 20:53:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8867: Further deflake test auto scaling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14740 )
Change subject: IMPALA-8867: Further deflake test_auto_scaling
......................................................................
Patch Set 7:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5133/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29808982cc6226152c544cb99f76961b582975a7
Gerrit-Change-Number: 14740
Gerrit-PatchSet: 7
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Nov 2019 22:13:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8867: Further deflake test auto scaling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14740 )
Change subject: IMPALA-8867: Further deflake test_auto_scaling
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5284/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29808982cc6226152c544cb99f76961b582975a7
Gerrit-Change-Number: 14740
Gerrit-PatchSet: 5
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Nov 2019 21:42:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8867: Further deflake test auto scaling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14740 )
Change subject: IMPALA-8867: Further deflake test_auto_scaling
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29808982cc6226152c544cb99f76961b582975a7
Gerrit-Change-Number: 14740
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2019 20:16:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8867: Further deflake test auto scaling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14740 )
Change subject: IMPALA-8867: Further deflake test_auto_scaling
......................................................................
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5260/
--
To view, visit http://gerrit.cloudera.org:8080/14740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29808982cc6226152c544cb99f76961b582975a7
Gerrit-Change-Number: 14740
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Nov 2019 06:16:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8867: Further deflake test auto scaling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14740 )
Change subject: IMPALA-8867: Further deflake test_auto_scaling
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5272/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29808982cc6226152c544cb99f76961b582975a7
Gerrit-Change-Number: 14740
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Nov 2019 21:03:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8867: Further deflake test auto scaling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14740 )
Change subject: IMPALA-8867: Further deflake test_auto_scaling
......................................................................
Patch Set 4: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5272/
--
To view, visit http://gerrit.cloudera.org:8080/14740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29808982cc6226152c544cb99f76961b582975a7
Gerrit-Change-Number: 14740
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Nov 2019 01:43:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8867: Further deflake test auto scaling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14740 )
Change subject: IMPALA-8867: Further deflake test_auto_scaling
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29808982cc6226152c544cb99f76961b582975a7
Gerrit-Change-Number: 14740
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Nov 2019 21:03:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8867: Further deflake test auto scaling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14740 )
Change subject: IMPALA-8867: Further deflake test_auto_scaling
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5290/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29808982cc6226152c544cb99f76961b582975a7
Gerrit-Change-Number: 14740
Gerrit-PatchSet: 6
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Nov 2019 21:21:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8867: Further deflake test auto scaling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14740 )
Change subject: IMPALA-8867: Further deflake test_auto_scaling
......................................................................
Patch Set 7:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5291/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29808982cc6226152c544cb99f76961b582975a7
Gerrit-Change-Number: 14740
Gerrit-PatchSet: 7
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Nov 2019 21:29:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8867: Further deflake test auto scaling
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14740 )
Change subject: IMPALA-8867: Further deflake test_auto_scaling
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14740/1/tests/custom_cluster/test_auto_scaling.py
File tests/custom_cluster/test_auto_scaling.py:
http://gerrit.cloudera.org:8080/#/c/14740/1/tests/custom_cluster/test_auto_scaling.py@104
PS1, Line 104: min_query_rate = 1.1 * EXECUTOR_SLOTS
I looked through the failures for this, and I've seen a couple failures on an older Centos 6 machine that was slightly below this:
custom_cluster/test_auto_scaling.py:116: in test_single_workload
assert max_query_rate >= min_query_rate, "Query rate did not reach %s within %s " \
E AssertionError: Query rate did not reach 3.6 within 45 s. Maximum was 3.2. Cluster size is 5.
E assert 3.2000000000000002 >= 3.5999999999999996
That's the lowest I saw it go in the failures I reviewed. (Most of the current failures are above 3.3 and your fix would be good.) Would a 1.05 multiplier be ok?
--
To view, visit http://gerrit.cloudera.org:8080/14740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29808982cc6226152c544cb99f76961b582975a7
Gerrit-Change-Number: 14740
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Nov 2019 22:05:54 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8867: Further deflake test auto scaling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14740 )
Change subject: IMPALA-8867: Further deflake test_auto_scaling
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29808982cc6226152c544cb99f76961b582975a7
Gerrit-Change-Number: 14740
Gerrit-PatchSet: 6
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Nov 2019 21:21:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8867: Further deflake test auto scaling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14740 )
Change subject: IMPALA-8867: Further deflake test_auto_scaling
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5260/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29808982cc6226152c544cb99f76961b582975a7
Gerrit-Change-Number: 14740
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2019 20:16:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8867: Further deflake test auto scaling
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/14740 )
Change subject: IMPALA-8867: Further deflake test_auto_scaling
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14740/1/tests/custom_cluster/test_auto_scaling.py
File tests/custom_cluster/test_auto_scaling.py:
http://gerrit.cloudera.org:8080/#/c/14740/1/tests/custom_cluster/test_auto_scaling.py@104
PS1, Line 104: min_query_rate = 1.1 * EXECUTOR_SLOTS
> I looked through the failures for this, and I've seen a couple failures on
Changed it to > EXECUTOR_SLOTS
--
To view, visit http://gerrit.cloudera.org:8080/14740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29808982cc6226152c544cb99f76961b582975a7
Gerrit-Change-Number: 14740
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2019 20:09:22 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8867: Further deflake test auto scaling
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/14740 )
Change subject: IMPALA-8867: Further deflake test_auto_scaling
......................................................................
Patch Set 5: Code-Review+2
Hit the HBase build timeout issue (IMPALA-9165).
--
To view, visit http://gerrit.cloudera.org:8080/14740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29808982cc6226152c544cb99f76961b582975a7
Gerrit-Change-Number: 14740
Gerrit-PatchSet: 5
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Nov 2019 21:42:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8867: Further deflake test auto scaling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14740 )
Change subject: IMPALA-8867: Further deflake test_auto_scaling
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5055/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29808982cc6226152c544cb99f76961b582975a7
Gerrit-Change-Number: 14740
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Nov 2019 01:37:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8867: Further deflake test auto scaling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14740 )
Change subject: IMPALA-8867: Further deflake test_auto_scaling
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29808982cc6226152c544cb99f76961b582975a7
Gerrit-Change-Number: 14740
Gerrit-PatchSet: 6
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Nov 2019 02:06:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8867: Further deflake test auto scaling
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14740
to look at the new patch set (#7).
Change subject: IMPALA-8867: Further deflake test_auto_scaling
......................................................................
IMPALA-8867: Further deflake test_auto_scaling
A previous attempt to deflake this test by lowering the threshold for
multi-group throughput had improved things but we still saw another
occurrence of test_auto_scaling failing recently. This change lowers the
threshold even further to try and eradicate the flakiness. From
inspecting the logs of the failed run I could see that the new threshold
would have prevented the failure.
Change-Id: I29808982cc6226152c544cb99f76961b582975a7
---
M tests/custom_cluster/test_auto_scaling.py
1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/14740/7
--
To view, visit http://gerrit.cloudera.org:8080/14740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I29808982cc6226152c544cb99f76961b582975a7
Gerrit-Change-Number: 14740
Gerrit-PatchSet: 7
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-8867: Further deflake test auto scaling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14740 )
Change subject: IMPALA-8867: Further deflake test_auto_scaling
......................................................................
Patch Set 7: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29808982cc6226152c544cb99f76961b582975a7
Gerrit-Change-Number: 14740
Gerrit-PatchSet: 7
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Nov 2019 02:03:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8867: Further deflake test auto scaling
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/14740 )
Change subject: IMPALA-8867: Further deflake test_auto_scaling
......................................................................
Patch Set 7: Code-Review+2
Rebased to pull in the fix for IMPALA-9165, carrying Joe's +2
--
To view, visit http://gerrit.cloudera.org:8080/14740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29808982cc6226152c544cb99f76961b582975a7
Gerrit-Change-Number: 14740
Gerrit-PatchSet: 7
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Nov 2019 21:29:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8867: Further deflake test auto scaling
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14740 )
Change subject: IMPALA-8867: Further deflake test_auto_scaling
......................................................................
Patch Set 2: Code-Review+2
Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/14740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29808982cc6226152c544cb99f76961b582975a7
Gerrit-Change-Number: 14740
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2019 20:11:07 +0000
Gerrit-HasComments: No