You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/02 01:14:36 UTC

[GitHub] [spark] cloud-fan commented on a diff in pull request #37364: [SPARK-39936][SQL] Store schema in properties for Spark Views

cloud-fan commented on code in PR #37364:
URL: https://github.com/apache/spark/pull/37364#discussion_r935030049


##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala:
##########
@@ -2386,10 +2385,6 @@ class HiveDDLSuite
         "CREATE TABLE t1 USING PARQUET AS SELECT NULL AS null_col",
         "Parquet data source does not support void data type")
 
-      assertAnalysisError(

Review Comment:
   do we still need to remove this test?



##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala:
##########
@@ -2400,10 +2395,6 @@ class HiveDDLSuite
         "CREATE TABLE t1 (v VOID) USING PARQUET",
         "Parquet data source does not support void data type")
 
-      assertAnalysisError(

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org