You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/04/28 07:44:22 UTC
[GitHub] [dolphinscheduler] SnowMoon-Dev opened a new pull request, #9828: fix bug #9827 json object serialization error
SnowMoon-Dev opened a new pull request, #9828:
URL: https://github.com/apache/dolphinscheduler/pull/9828
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
<!--(For example: This pull request adds checkstyle plugin).-->
## Brief change log
close [ #9827](https://github.com/apache/dolphinscheduler/issues/9827)
## Verify this pull request
Manually verified the change by testing locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SnowMoon-Dev commented on a diff in pull request #9828: [Fix] json object serialization error
Posted by GitBox <gi...@apache.org>.
SnowMoon-Dev commented on code in PR #9828:
URL: https://github.com/apache/dolphinscheduler/pull/9828#discussion_r860702641
##########
dolphinscheduler-ui-next/src/views/datasource/list/use-form.ts:
##########
@@ -138,9 +139,15 @@ export function useForm(id?: number) {
const resetFieldsValue = () => {
state.detailForm = { ...initialValues }
}
- const setFieldsValue = (values: object) => {
- state.detailForm = { ...state.detailForm, ...values }
+
+ const setFieldsValue = (values: IDataSource) => {
+ state.detailForm = {
+ ...state.detailForm,
+ ...values,
+ other: values.other ? JSON.stringify(values.other) : ''
Review Comment:
Thanks for the guidance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] devosend commented on a diff in pull request #9828: [Fix] json object serialization error
Posted by GitBox <gi...@apache.org>.
devosend commented on code in PR #9828:
URL: https://github.com/apache/dolphinscheduler/pull/9828#discussion_r860625079
##########
dolphinscheduler-ui-next/src/views/datasource/list/use-detail.ts:
##########
@@ -50,7 +50,7 @@ export function useDetail(getFieldsValue: Function) {
const dataSourceRes = await queryDataSource(id)
status.loading = false
PREV_NAME = dataSourceRes.name
- return dataSourceRes
+ return dataSourceRes as IDataSource
Review Comment:
Why did you modify it?
##########
dolphinscheduler-ui-next/src/views/datasource/list/use-form.ts:
##########
@@ -138,9 +139,15 @@ export function useForm(id?: number) {
const resetFieldsValue = () => {
state.detailForm = { ...initialValues }
}
- const setFieldsValue = (values: object) => {
- state.detailForm = { ...state.detailForm, ...values }
+
+ const setFieldsValue = (values: IDataSource) => {
+ state.detailForm = {
+ ...state.detailForm,
+ ...values,
+ other: JSON.stringify(values.other)
Review Comment:
`values.other` may be null. You should judge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #9828: [Fix] json object serialization error
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #9828:
URL: https://github.com/apache/dolphinscheduler/pull/9828#issuecomment-1111945778
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=9828)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=9828&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=9828&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=9828&metric=new_duplicated_lines_density&view=list) [28.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=9828&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #9828: [Fix] json object serialization error
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #9828:
URL: https://github.com/apache/dolphinscheduler/pull/9828#issuecomment-1111880573
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=9828)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=9828&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=9828&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=9828&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=9828&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] devosend commented on a diff in pull request #9828: [Fix] json object serialization error
Posted by GitBox <gi...@apache.org>.
devosend commented on code in PR #9828:
URL: https://github.com/apache/dolphinscheduler/pull/9828#discussion_r860643632
##########
dolphinscheduler-ui-next/src/views/datasource/list/use-form.ts:
##########
@@ -138,9 +139,15 @@ export function useForm(id?: number) {
const resetFieldsValue = () => {
state.detailForm = { ...initialValues }
}
- const setFieldsValue = (values: object) => {
- state.detailForm = { ...state.detailForm, ...values }
+
+ const setFieldsValue = (values: IDataSource) => {
+ state.detailForm = {
+ ...state.detailForm,
+ ...values,
+ other: values.other ? JSON.stringify(values.other) : ''
Review Comment:
'' will cause the placeholder to not be displayed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #9828: [Fix] json object serialization error
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #9828:
URL: https://github.com/apache/dolphinscheduler/pull/9828#issuecomment-1111876016
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/9828?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9828](https://codecov.io/gh/apache/dolphinscheduler/pull/9828?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5a7d249) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/ab2d535e5451ea05b0da89865176b6612e3d2994?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ab2d535) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 5a7d249 differs from pull request most recent head 5f65e78. Consider uploading reports for the commit 5f65e78 to get more accurate results
```diff
@@ Coverage Diff @@
## dev #9828 +/- ##
============================================
- Coverage 40.40% 40.39% -0.01%
+ Complexity 4525 4523 -2
============================================
Files 834 834
Lines 33639 33639
Branches 3721 3721
============================================
- Hits 13592 13590 -2
Misses 18765 18765
- Partials 1282 1284 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/9828?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...er/master/dispatch/host/assign/RandomSelector.java](https://codecov.io/gh/apache/dolphinscheduler/pull/9828/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9kaXNwYXRjaC9ob3N0L2Fzc2lnbi9SYW5kb21TZWxlY3Rvci5qYXZh) | `77.77% <0.00%> (-5.56%)` | :arrow_down: |
| [...dolphinscheduler/remote/future/ResponseFuture.java](https://codecov.io/gh/apache/dolphinscheduler/pull/9828/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2Z1dHVyZS9SZXNwb25zZUZ1dHVyZS5qYXZh) | `81.96% <0.00%> (-1.64%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/9828?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/9828?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ab2d535...5f65e78](https://codecov.io/gh/apache/dolphinscheduler/pull/9828?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SnowMoon-Dev commented on a diff in pull request #9828: [Fix] json object serialization error
Posted by GitBox <gi...@apache.org>.
SnowMoon-Dev commented on code in PR #9828:
URL: https://github.com/apache/dolphinscheduler/pull/9828#discussion_r860702901
##########
dolphinscheduler-ui-next/src/views/datasource/list/use-form.ts:
##########
@@ -138,9 +139,15 @@ export function useForm(id?: number) {
const resetFieldsValue = () => {
state.detailForm = { ...initialValues }
}
- const setFieldsValue = (values: object) => {
- state.detailForm = { ...state.detailForm, ...values }
+
+ const setFieldsValue = (values: IDataSource) => {
+ state.detailForm = {
+ ...state.detailForm,
+ ...values,
+ other: JSON.stringify(values.other)
Review Comment:
i will fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #9828: [Fix] json object serialization error
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #9828:
URL: https://github.com/apache/dolphinscheduler/pull/9828#issuecomment-1111984664
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=9828)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9828&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=9828&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=9828&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=9828&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=9828&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] devosend merged pull request #9828: [Fix] json object serialization error
Posted by GitBox <gi...@apache.org>.
devosend merged PR #9828:
URL: https://github.com/apache/dolphinscheduler/pull/9828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org