[jira] Commented: (DERBY-64) Create a table with a query

["A B (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463331 ] 

A B commented on DERBY-64:
--------------------------

I noticed that the patch for this issue was posted about a month ago and has been idle since.   So I did a quick review and it looks like a great start.  I ran some simple tests and things work as I would expect them to.  If I specify "WITH DATA" I get a reasonable "incremental" error message ("Feature not supported") instead of an internal failure, which is good.  The code is well-contained and nicely commented--and the indentation even matches the surrounding code (nice job!).  There are handful of lines in CreateTableNode and sqlgrammar.jj that go beyond 80 characters, but that's just me being picky.

I also looked at section 11.3 of SQL2003 foundation and so far as I can tell Derby64Patch2.txt lines up with the standard in terms of the required "NO DATA" syntax and functionality.  As a sanity check I ran derbyall on Red Hat Linux with ibm142 and there were no failures.

The most recent comment for this issue is from James Adams saying:

"I think I will develop tests for the functionality I provided so far."

James, are you still planning to contribute test cases for the current (NO DATA) functionality?  If you do so, I'd be willing to look at committing this patch as the first step in incremental development for this feature. 

> Create a table with a query
> ---------------------------
>
>                 Key: DERBY-64
>                 URL: https://issues.apache.org/jira/browse/DERBY-64
>             Project: Derby
>          Issue Type: New Feature
>          Components: SQL
>            Reporter: Christian d'Heureuse
>         Assigned To: James F. Adams
>         Attachments: Derby64Patch1.txt, Derby64Patch2.txt
>
>
> I suggest to implement a SQL statement to create and fill a table with a query, without having to write the columns definition.
> e.g.:
>  CREATE TABLE new_table AS SELECT ...;
> or:
>  SELECT ... INTO new_table FROM ...;

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira