You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "David Smiley (Jira)" <ji...@apache.org> on 2020/08/01 04:08:00 UTC
[jira] [Commented] (SOLR-14696) PluginInfo attribute values should
only be Strings
[ https://issues.apache.org/jira/browse/SOLR-14696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17169226#comment-17169226 ]
David Smiley commented on SOLR-14696:
-------------------------------------
I appreciate the history lesson!
In the spirit of JSON compatibility, maybe the "attributes" vs "initArgs" distinction should disappear and we just use *one* of type: Map<String,Object> ?
> PluginInfo attribute values should only be Strings
> --------------------------------------------------
>
> Key: SOLR-14696
> URL: https://issues.apache.org/jira/browse/SOLR-14696
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: David Smiley
> Priority: Minor
>
> PluginInfo has a constructor that initializes its attributes field (Map<String,String>) to that of a constructor param (Map<String,Object>). Sometimes, the values aren't Strings, yet the code suppresses warnings about this and just sets it any way. This is nasty!
> Perhaps it should only let through some built-in meta names like name, class, and enabled that are or can trivially be coerced to a String.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org