[jira] [Commented] (LUCENE-5385) make precommit work for svn 1.8 or git checkouts

["Robert Muir (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-5385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13863077#comment-13863077 ] 

Robert Muir commented on LUCENE-5385:
-------------------------------------

The biggest thing i dont like, is the ignoring of any svn exceptions in the main processing loop.
I guess I would prefer if we had something like this instead:

{code}
// explicit sanity check to see if its even an svn checkout with a supported version
try {
  statusClient.getVersionOrSomeOtherTrivialOperation();
} catch (SVNException e) {
  task.log("unsupported....")
}
{code}

> make precommit work for svn 1.8 or git checkouts
> ------------------------------------------------
>
>                 Key: LUCENE-5385
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5385
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/build
>            Reporter: Robert Muir
>         Attachments: LUCENE-5385.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org