[GitHub] [cloudstack] ustcweizhou edited a comment on issue #3294: Set default service offering over api and ui

[GitBox <gi...@apache.org>]

ustcweizhou edited a comment on issue #3294: Set default service offering over api and ui
URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-489131253
 
 
   > @DaanHoogland we dont agree. we would prefer this functionality. we dont think its somehow like "clunky". "clunky" was it implemented before. we think it should be easier so set it for all types of system vms. this feature allow to set different type of system vm images. to get this a graphical menu is more user friendly than one value for each type of system vm in global settings. at the moment its a
   > 
   > > I would prefer to add a global setting to specify the default service offering for routers.
   > > The service offering will be determined in findServiceOfferingId() in RouterDeploymentDefinition.java and VpcRouterDeploymentDefinition.java
   > > If you do not mind, I can create a PR for it.
   > 
   > what this means its determined in this functions? is there any functionality they breaks this? why it should set this in global setting when all other things for "offering" are set there?
   
   @svenvogel 
   Currently we have global setting consoleproxy.service.offering for CPVM and secstorage.service.offering for SSVM, no code change is needed. 
   Of course it would be better to change it from global setting to zone setting, so zones can have different offering for systemvms f there are multiple zones created.
   
   We do not have setting for router vms. I prefer to add an account setting (eg router.service.offering" so we can set offering of router globally and also for individual account. it is a simple change similar as consoleproxy.service.offering and secstorage.service.offering
   
   I understand that you have spent some time on this PR and it might be running on your production already. I agree that it is user friendly. Although this is not the best way in my point of view , considering It will not break any functionality, this PR is ok for me. New cloudstack users will benefit from it.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services