You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whirr.apache.org by "Andrei Savu (JIRA)" <ji...@apache.org> on 2011/01/07 11:32:47 UTC

[jira] Created: (WHIRR-195) Display available roles instead of service names when running ./bin/whirr

Display available roles instead of service names when running ./bin/whirr
-------------------------------------------------------------------------

                 Key: WHIRR-195
                 URL: https://issues.apache.org/jira/browse/WHIRR-195
             Project: Whirr
          Issue Type: Improvement
          Components: cli
            Reporter: Andrei Savu
            Priority: Minor


Now that service-name is optional I believe that we should display a list of the available roles (with a small description) instead of service names. 

Similar to: 

{code}
$ ./bin/whirr 
Usage: whirr COMMAND [ARGS]
where COMMAND may be one of:

        version  Print the version number and exit.
 launch-cluster  Launch a new cluster running a service.
destroy-cluster  Terminate and cleanup resources for a running cluster.
   list-cluster  List the nodes in a cluster.

Available roles for instances:
  nn             hadoop name node
  jt             hadoop job trackers
  ... 
{code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WHIRR-195) Display available roles instead of service names when running ./bin/whirr

Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WHIRR-195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrei Savu updated WHIRR-195:
------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I've just committed this. Thanks Tom for reviewing. 

> Display available roles instead of service names when running ./bin/whirr
> -------------------------------------------------------------------------
>
>                 Key: WHIRR-195
>                 URL: https://issues.apache.org/jira/browse/WHIRR-195
>             Project: Whirr
>          Issue Type: Improvement
>          Components: cli
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>            Priority: Minor
>             Fix For: 0.4.0
>
>         Attachments: WHIRR-195.patch, WHIRR-195.patch, WHIRR-195.patch
>
>
> Now that service-name is optional I believe that we should display a list of the available roles (with a small description) instead of service names. 
> Similar to: 
> {code}
> $ ./bin/whirr 
> Usage: whirr COMMAND [ARGS]
> where COMMAND may be one of:
>         version  Print the version number and exit.
>  launch-cluster  Launch a new cluster running a service.
> destroy-cluster  Terminate and cleanup resources for a running cluster.
>    list-cluster  List the nodes in a cluster.
> Available roles for instances:
>   nn             hadoop name node
>   jt             hadoop job trackers
>   ... 
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WHIRR-195) Display available roles instead of service names when running ./bin/whirr

Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WHIRR-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987762#action_12987762 ] 

Andrei Savu commented on WHIRR-195:
-----------------------------------


With an experimental version of WHIRR-199:

{code}
$ ./bin/whirr 
Usage: whirr COMMAND [ARGS]
where COMMAND may be one of:

        version  Print the version number and exit.
 launch-cluster  Launch a new cluster running a service.
destroy-cluster  Terminate and cleanup resources for a running cluster.
   list-cluster  List the nodes in a cluster.

Available roles:
  cassandra
  hadoop-namenode
  hadoop-datanode
  hadoop-jobtracker
  hadoop-tasktracker
  zookeeper
  hbase-master
  hbase-regionserver
  hbase-restserver
  hbase-avroserver
  hbase-thriftserver
{code}

Should I add some sort of grouping based on the role prefix? 


> Display available roles instead of service names when running ./bin/whirr
> -------------------------------------------------------------------------
>
>                 Key: WHIRR-195
>                 URL: https://issues.apache.org/jira/browse/WHIRR-195
>             Project: Whirr
>          Issue Type: Improvement
>          Components: cli
>            Reporter: Andrei Savu
>            Priority: Minor
>         Attachments: WHIRR-195.patch
>
>
> Now that service-name is optional I believe that we should display a list of the available roles (with a small description) instead of service names. 
> Similar to: 
> {code}
> $ ./bin/whirr 
> Usage: whirr COMMAND [ARGS]
> where COMMAND may be one of:
>         version  Print the version number and exit.
>  launch-cluster  Launch a new cluster running a service.
> destroy-cluster  Terminate and cleanup resources for a running cluster.
>    list-cluster  List the nodes in a cluster.
> Available roles for instances:
>   nn             hadoop name node
>   jt             hadoop job trackers
>   ... 
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WHIRR-195) Display available roles instead of service names when running ./bin/whirr

Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WHIRR-195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrei Savu updated WHIRR-195:
------------------------------

    Fix Version/s: 0.4.0
           Status: Patch Available  (was: Open)

> Display available roles instead of service names when running ./bin/whirr
> -------------------------------------------------------------------------
>
>                 Key: WHIRR-195
>                 URL: https://issues.apache.org/jira/browse/WHIRR-195
>             Project: Whirr
>          Issue Type: Improvement
>          Components: cli
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>            Priority: Minor
>             Fix For: 0.4.0
>
>         Attachments: WHIRR-195.patch, WHIRR-195.patch, WHIRR-195.patch
>
>
> Now that service-name is optional I believe that we should display a list of the available roles (with a small description) instead of service names. 
> Similar to: 
> {code}
> $ ./bin/whirr 
> Usage: whirr COMMAND [ARGS]
> where COMMAND may be one of:
>         version  Print the version number and exit.
>  launch-cluster  Launch a new cluster running a service.
> destroy-cluster  Terminate and cleanup resources for a running cluster.
>    list-cluster  List the nodes in a cluster.
> Available roles for instances:
>   nn             hadoop name node
>   jt             hadoop job trackers
>   ... 
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WHIRR-195) Display available roles instead of service names when running ./bin/whirr

Posted by "Tom White (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WHIRR-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987847#action_12987847 ] 

Tom White commented on WHIRR-195:
---------------------------------

I'm not sure we need the (publicly visible) ClusterActionHandlerFactory class. How about having the role sort code in Main (since that is the only place it's used), and just call ServiceLoader.load() as needed?

> Display available roles instead of service names when running ./bin/whirr
> -------------------------------------------------------------------------
>
>                 Key: WHIRR-195
>                 URL: https://issues.apache.org/jira/browse/WHIRR-195
>             Project: Whirr
>          Issue Type: Improvement
>          Components: cli
>            Reporter: Andrei Savu
>            Priority: Minor
>         Attachments: WHIRR-195.patch, WHIRR-195.patch
>
>
> Now that service-name is optional I believe that we should display a list of the available roles (with a small description) instead of service names. 
> Similar to: 
> {code}
> $ ./bin/whirr 
> Usage: whirr COMMAND [ARGS]
> where COMMAND may be one of:
>         version  Print the version number and exit.
>  launch-cluster  Launch a new cluster running a service.
> destroy-cluster  Terminate and cleanup resources for a running cluster.
>    list-cluster  List the nodes in a cluster.
> Available roles for instances:
>   nn             hadoop name node
>   jt             hadoop job trackers
>   ... 
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WHIRR-195) Display available roles instead of service names when running ./bin/whirr

Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WHIRR-195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrei Savu updated WHIRR-195:
------------------------------

    Attachment: WHIRR-195.patch

Done. 

> Display available roles instead of service names when running ./bin/whirr
> -------------------------------------------------------------------------
>
>                 Key: WHIRR-195
>                 URL: https://issues.apache.org/jira/browse/WHIRR-195
>             Project: Whirr
>          Issue Type: Improvement
>          Components: cli
>            Reporter: Andrei Savu
>            Priority: Minor
>         Attachments: WHIRR-195.patch, WHIRR-195.patch
>
>
> Now that service-name is optional I believe that we should display a list of the available roles (with a small description) instead of service names. 
> Similar to: 
> {code}
> $ ./bin/whirr 
> Usage: whirr COMMAND [ARGS]
> where COMMAND may be one of:
>         version  Print the version number and exit.
>  launch-cluster  Launch a new cluster running a service.
> destroy-cluster  Terminate and cleanup resources for a running cluster.
>    list-cluster  List the nodes in a cluster.
> Available roles for instances:
>   nn             hadoop name node
>   jt             hadoop job trackers
>   ... 
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WHIRR-195) Display available roles instead of service names when running ./bin/whirr

Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WHIRR-195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrei Savu updated WHIRR-195:
------------------------------

    Attachment: WHIRR-195.patch

I've removed the useless factory. 

> Display available roles instead of service names when running ./bin/whirr
> -------------------------------------------------------------------------
>
>                 Key: WHIRR-195
>                 URL: https://issues.apache.org/jira/browse/WHIRR-195
>             Project: Whirr
>          Issue Type: Improvement
>          Components: cli
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>            Priority: Minor
>         Attachments: WHIRR-195.patch, WHIRR-195.patch, WHIRR-195.patch
>
>
> Now that service-name is optional I believe that we should display a list of the available roles (with a small description) instead of service names. 
> Similar to: 
> {code}
> $ ./bin/whirr 
> Usage: whirr COMMAND [ARGS]
> where COMMAND may be one of:
>         version  Print the version number and exit.
>  launch-cluster  Launch a new cluster running a service.
> destroy-cluster  Terminate and cleanup resources for a running cluster.
>    list-cluster  List the nodes in a cluster.
> Available roles for instances:
>   nn             hadoop name node
>   jt             hadoop job trackers
>   ... 
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WHIRR-195) Display available roles instead of service names when running ./bin/whirr

Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WHIRR-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988084#action_12988084 ] 

Andrei Savu commented on WHIRR-195:
-----------------------------------

That was the first thing I've done before adding the ClusterActionHandlerFactory class. I will rewrite the patch if you think that adding a new class it's too much. 

> Display available roles instead of service names when running ./bin/whirr
> -------------------------------------------------------------------------
>
>                 Key: WHIRR-195
>                 URL: https://issues.apache.org/jira/browse/WHIRR-195
>             Project: Whirr
>          Issue Type: Improvement
>          Components: cli
>            Reporter: Andrei Savu
>            Priority: Minor
>         Attachments: WHIRR-195.patch, WHIRR-195.patch
>
>
> Now that service-name is optional I believe that we should display a list of the available roles (with a small description) instead of service names. 
> Similar to: 
> {code}
> $ ./bin/whirr 
> Usage: whirr COMMAND [ARGS]
> where COMMAND may be one of:
>         version  Print the version number and exit.
>  launch-cluster  Launch a new cluster running a service.
> destroy-cluster  Terminate and cleanup resources for a running cluster.
>    list-cluster  List the nodes in a cluster.
> Available roles for instances:
>   nn             hadoop name node
>   jt             hadoop job trackers
>   ... 
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WHIRR-195) Display available roles instead of service names when running ./bin/whirr

Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WHIRR-195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrei Savu reassigned WHIRR-195:
---------------------------------

    Assignee: Andrei Savu

> Display available roles instead of service names when running ./bin/whirr
> -------------------------------------------------------------------------
>
>                 Key: WHIRR-195
>                 URL: https://issues.apache.org/jira/browse/WHIRR-195
>             Project: Whirr
>          Issue Type: Improvement
>          Components: cli
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>            Priority: Minor
>         Attachments: WHIRR-195.patch, WHIRR-195.patch
>
>
> Now that service-name is optional I believe that we should display a list of the available roles (with a small description) instead of service names. 
> Similar to: 
> {code}
> $ ./bin/whirr 
> Usage: whirr COMMAND [ARGS]
> where COMMAND may be one of:
>         version  Print the version number and exit.
>  launch-cluster  Launch a new cluster running a service.
> destroy-cluster  Terminate and cleanup resources for a running cluster.
>    list-cluster  List the nodes in a cluster.
> Available roles for instances:
>   nn             hadoop name node
>   jt             hadoop job trackers
>   ... 
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WHIRR-195) Display available roles instead of service names when running ./bin/whirr

Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WHIRR-195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrei Savu updated WHIRR-195:
------------------------------

    Attachment: WHIRR-195.patch

This patch needs WHIRR-199 in order to look good :) I haven't added descriptions because the role names should be self explanatory for now. 

> Display available roles instead of service names when running ./bin/whirr
> -------------------------------------------------------------------------
>
>                 Key: WHIRR-195
>                 URL: https://issues.apache.org/jira/browse/WHIRR-195
>             Project: Whirr
>          Issue Type: Improvement
>          Components: cli
>            Reporter: Andrei Savu
>            Priority: Minor
>         Attachments: WHIRR-195.patch
>
>
> Now that service-name is optional I believe that we should display a list of the available roles (with a small description) instead of service names. 
> Similar to: 
> {code}
> $ ./bin/whirr 
> Usage: whirr COMMAND [ARGS]
> where COMMAND may be one of:
>         version  Print the version number and exit.
>  launch-cluster  Launch a new cluster running a service.
> destroy-cluster  Terminate and cleanup resources for a running cluster.
>    list-cluster  List the nodes in a cluster.
> Available roles for instances:
>   nn             hadoop name node
>   jt             hadoop job trackers
>   ... 
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WHIRR-195) Display available roles instead of service names when running ./bin/whirr

Posted by "Tom White (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WHIRR-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988490#action_12988490 ] 

Tom White commented on WHIRR-195:
---------------------------------

+1

> Display available roles instead of service names when running ./bin/whirr
> -------------------------------------------------------------------------
>
>                 Key: WHIRR-195
>                 URL: https://issues.apache.org/jira/browse/WHIRR-195
>             Project: Whirr
>          Issue Type: Improvement
>          Components: cli
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>            Priority: Minor
>             Fix For: 0.4.0
>
>         Attachments: WHIRR-195.patch, WHIRR-195.patch, WHIRR-195.patch
>
>
> Now that service-name is optional I believe that we should display a list of the available roles (with a small description) instead of service names. 
> Similar to: 
> {code}
> $ ./bin/whirr 
> Usage: whirr COMMAND [ARGS]
> where COMMAND may be one of:
>         version  Print the version number and exit.
>  launch-cluster  Launch a new cluster running a service.
> destroy-cluster  Terminate and cleanup resources for a running cluster.
>    list-cluster  List the nodes in a cluster.
> Available roles for instances:
>   nn             hadoop name node
>   jt             hadoop job trackers
>   ... 
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WHIRR-195) Display available roles instead of service names when running ./bin/whirr

Posted by "Tom White (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WHIRR-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987769#action_12987769 ] 

Tom White commented on WHIRR-195:
---------------------------------

> Should I add some sort of grouping based on the role prefix? 

Yes, I would just sort the list.

> Display available roles instead of service names when running ./bin/whirr
> -------------------------------------------------------------------------
>
>                 Key: WHIRR-195
>                 URL: https://issues.apache.org/jira/browse/WHIRR-195
>             Project: Whirr
>          Issue Type: Improvement
>          Components: cli
>            Reporter: Andrei Savu
>            Priority: Minor
>         Attachments: WHIRR-195.patch
>
>
> Now that service-name is optional I believe that we should display a list of the available roles (with a small description) instead of service names. 
> Similar to: 
> {code}
> $ ./bin/whirr 
> Usage: whirr COMMAND [ARGS]
> where COMMAND may be one of:
>         version  Print the version number and exit.
>  launch-cluster  Launch a new cluster running a service.
> destroy-cluster  Terminate and cleanup resources for a running cluster.
>    list-cluster  List the nodes in a cluster.
> Available roles for instances:
>   nn             hadoop name node
>   jt             hadoop job trackers
>   ... 
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WHIRR-195) Display available roles instead of service names when running ./bin/whirr

Posted by "Tom White (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WHIRR-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988186#action_12988186 ] 

Tom White commented on WHIRR-195:
---------------------------------

Not a big deal either way, but the ClusterActionHandlerFactory didn't seem to "pull its weight".

> Display available roles instead of service names when running ./bin/whirr
> -------------------------------------------------------------------------
>
>                 Key: WHIRR-195
>                 URL: https://issues.apache.org/jira/browse/WHIRR-195
>             Project: Whirr
>          Issue Type: Improvement
>          Components: cli
>            Reporter: Andrei Savu
>            Priority: Minor
>         Attachments: WHIRR-195.patch, WHIRR-195.patch
>
>
> Now that service-name is optional I believe that we should display a list of the available roles (with a small description) instead of service names. 
> Similar to: 
> {code}
> $ ./bin/whirr 
> Usage: whirr COMMAND [ARGS]
> where COMMAND may be one of:
>         version  Print the version number and exit.
>  launch-cluster  Launch a new cluster running a service.
> destroy-cluster  Terminate and cleanup resources for a running cluster.
>    list-cluster  List the nodes in a cluster.
> Available roles for instances:
>   nn             hadoop name node
>   jt             hadoop job trackers
>   ... 
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.