[GitHub] [incubator-doris] HangyuanLiu commented on a change in pull request #1587: Set timezone variable in fe

[GitBox <gi...@apache.org>]

HangyuanLiu commented on a change in pull request #1587: Set timezone variable in fe
URL: https://github.com/apache/incubator-doris/pull/1587#discussion_r310568646
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/qe/VariableMgr.java
 ##########
 @@ -211,6 +244,12 @@ public static void setVar(SessionVariable sessionVariable, SetVar setVar) throws
         }
         // Check variable attribute and setVar
         checkUpdate(setVar, ctx.getFlag());
+        // Check variable time_zone value is valid
+        if (setVar.getVariable().toLowerCase().equals("time_zone")) {
+            if (!setVar.getValue().getStringValue().equalsIgnoreCase("SYSTEM")) {
 
 Review comment:
   we don't support "system" variable because fe system time zone is different

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org