You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Laszlo Pinter via Review Board <no...@reviews.apache.org> on 2020/03/26 14:43:01 UTC
Re: Review Request 71812: HIVE-22534: ACID: Improve Compactor thread
logging
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71812/
-----------------------------------------------------------
(Updated March 26, 2020, 2:43 p.m.)
Review request for hive and Karen Coppage.
Repository: hive-git
Description (updated)
-------
HIVE-22534: Improve Compactor threads logging
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java 54b616e60c73fa1005c6d679ea76d65e01a0749d
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 543ec0b99124cb38c8508aa2ec2f99cababdbdbd
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java 37a58627913c33be37cee7f11d9ca4ee5fd8aff2
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MinorQueryCompactor.java 1bf0beea4022dbabe65a9d2ee0972186b5cb3396
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MmMinorQueryCompactor.java 383891bfadfc1352430e50eac2d60366ad699bf0
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java a96cf1e73183232d587b3f4937c0d7e96764e662
Diff: https://reviews.apache.org/r/71812/diff/6/
Changes: https://reviews.apache.org/r/71812/diff/5-6/
Testing
-------
Thanks,
Laszlo Pinter
Re: Review Request 71812: HIVE-22534: ACID: Improve Compactor thread
logging
Posted by Laszlo Pinter via Review Board <no...@reviews.apache.org>.
> On March 27, 2020, 2:23 p.m., Karen Coppage wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java
> > Lines 374-375 (original), 360-361 (patched)
> > <https://reviews.apache.org/r/71812/diff/7/?file=2216296#file2216296line376>
> >
> > Not regression, but it looks like these arguments are switched up:
> > deltaNumThreshold
> > noBase ? "without" : "with"
Good catch, fixed it.
- Laszlo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71812/#review220095
-----------------------------------------------------------
On March 26, 2020, 2:43 p.m., Laszlo Pinter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71812/
> -----------------------------------------------------------
>
> (Updated March 26, 2020, 2:43 p.m.)
>
>
> Review request for hive and Karen Coppage.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-22534: ACID: Improve Compactor thread logging
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java 54b616e60c73fa1005c6d679ea76d65e01a0749d
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 543ec0b99124cb38c8508aa2ec2f99cababdbdbd
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java 37a58627913c33be37cee7f11d9ca4ee5fd8aff2
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MinorQueryCompactor.java 1bf0beea4022dbabe65a9d2ee0972186b5cb3396
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MmMinorQueryCompactor.java 383891bfadfc1352430e50eac2d60366ad699bf0
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java a96cf1e73183232d587b3f4937c0d7e96764e662
>
>
> Diff: https://reviews.apache.org/r/71812/diff/7/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Laszlo Pinter
>
>
Re: Review Request 71812: HIVE-22534: ACID: Improve Compactor thread
logging
Posted by Karen Coppage via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71812/#review220095
-----------------------------------------------------------
LGTM, one suggestion below.
Also Zoltan Chovan seemed excited about this change, maybe consider asking him if this fulfills his logging wishes :)
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java
Lines 374-375 (original), 360-361 (patched)
<https://reviews.apache.org/r/71812/#comment308401>
Not regression, but it looks like these arguments are switched up:
deltaNumThreshold
noBase ? "without" : "with"
- Karen Coppage
On March 26, 2020, 2:43 p.m., Laszlo Pinter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71812/
> -----------------------------------------------------------
>
> (Updated March 26, 2020, 2:43 p.m.)
>
>
> Review request for hive and Karen Coppage.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-22534: ACID: Improve Compactor thread logging
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java 54b616e60c73fa1005c6d679ea76d65e01a0749d
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 543ec0b99124cb38c8508aa2ec2f99cababdbdbd
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java 37a58627913c33be37cee7f11d9ca4ee5fd8aff2
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MinorQueryCompactor.java 1bf0beea4022dbabe65a9d2ee0972186b5cb3396
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MmMinorQueryCompactor.java 383891bfadfc1352430e50eac2d60366ad699bf0
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java a96cf1e73183232d587b3f4937c0d7e96764e662
>
>
> Diff: https://reviews.apache.org/r/71812/diff/7/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Laszlo Pinter
>
>