[jira] [Commented] (WAGON-396) AbstractHttpClientWagon extensibility (SPNEGO Authentication)

["Michael Osipov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WAGON-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14482907#comment-14482907 ] 

Michael Osipov commented on WAGON-396:
--------------------------------------

For what it is worth, the current SPNEGO implementation in {{HttpClient}} is unusable because it is implemented incorrectly. I currently rewriting it in HTTPCLIENT-1625 and having trouble with {{HttpAuthenticator}} not passing tokens back. Are you able to share your {{AuthScheme}}?

> AbstractHttpClientWagon extensibility (SPNEGO Authentication)
> -------------------------------------------------------------
>
>                 Key: WAGON-396
>                 URL: https://issues.apache.org/jira/browse/WAGON-396
>             Project: Maven Wagon
>          Issue Type: Improvement
>          Components: wagon-http
>    Affects Versions: 2.5
>            Reporter: Moritz Bechler
>            Priority: Minor
>
> I recently implemented SPNEGO authentication for the wagon-http provider. This implementation required a extension of DefaultHttpClient. So far this support lives in a separate modules. Unfortunately overriding the client initialization is not easily possible in the current code and requires nearly full duplication of wagon-http code.
> I would suggest to move the instantiation of the client from AbstractHttpClientWagon.openConnectionInternal() into a seperate factory method, e.g.
> {code}
>  protected DefaultHttpClient createHttpClient( ClientConnectionManager connManager ) {
>     	return new DefaultHttpClient(connManager);
>     }
>     public void openConnectionInternal()
>     {
>         repository.setUrl( getURL( repository ) );
>         client = this.createHttpClient( getConnectionManager() );
> {code}
> In case you are interested to integrate the SPNEGO support, I will be happy to share.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)