[GitHub] [maven] michael-o commented on a change in pull request #477: Improve the use of checkstyle in the build

[GitBox <gi...@apache.org>]

michael-o commented on a change in pull request #477:
URL: https://github.com/apache/maven/pull/477#discussion_r648618184



##########
File path: maven-core/src/main/java/org/apache/maven/execution/BuildResumptionAnalyzer.java
##########
@@ -32,5 +32,5 @@
      * @param result Outcome of the current Maven build.
      * @return A {@link BuildResumptionData} instance or {@link Optional#empty()} if resuming the build is not possible.
      */
-    Optional<BuildResumptionData> determineBuildResumptionData( final MavenExecutionResult result );
+    Optional<BuildResumptionData> determineBuildResumptionData( MavenExecutionResult result );

Review comment:
       Why did you remove the `final` keywords?

##########
File path: .mvn/readme.txt
##########
@@ -0,0 +1 @@
+The .mvn folder is needed to be able to use the ${maven.multiModuleProjectDirectory} property.

Review comment:
       directory, not folder




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org