You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tianyi Wang (Code Review)" <ge...@cloudera.org> on 2017/11/17 22:11:01 UTC
[Impala-ASF-CR] IMPALA-6210: Add query id to lineage graph logging
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8589
Change subject: IMPALA-6210: Add query id to lineage graph logging
......................................................................
IMPALA-6210: Add query id to lineage graph logging
Some tools use lineage graph logging to collect query metrics. Currently
only query hash is present in this log. Adding query id into it makes
such accounting easier.
Change-Id: I4adbd02df37a234dbb79f58b7c46ca11a914229f
---
M be/src/util/lineage-util.h
M common/thrift/LineageGraph.thrift
M fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java
A fe/src/main/java/org/apache/impala/util/TUniqueIdUtil.java
M testdata/workloads/functional-planner/queries/PlannerTest/lineage.test
5 files changed, 106 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/8589/1
--
To view, visit http://gerrit.cloudera.org:8080/8589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4adbd02df37a234dbb79f58b7c46ca11a914229f
Gerrit-Change-Number: 8589
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
[Impala-ASF-CR] IMPALA-6210: Add query id to lineage graph logging
Posted by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org>.
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8589 )
Change subject: IMPALA-6210: Add query id to lineage graph logging
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8589/2/fe/src/main/java/org/apache/impala/util/TUniqueIdUtil.java
File fe/src/main/java/org/apache/impala/util/TUniqueIdUtil.java:
http://gerrit.cloudera.org:8080/#/c/8589/2/fe/src/main/java/org/apache/impala/util/TUniqueIdUtil.java@33
PS2, Line 33: NumberFormatException("Invalid unique id format");
nit: maybe add the id in the error message?
--
To view, visit http://gerrit.cloudera.org:8080/8589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4adbd02df37a234dbb79f58b7c46ca11a914229f
Gerrit-Change-Number: 8589
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Dec 2017 20:04:57 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6210: Add query id to lineage graph logging
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8589 )
Change subject: IMPALA-6210: Add query id to lineage graph logging
......................................................................
IMPALA-6210: Add query id to lineage graph logging
Some tools use lineage graph logging to collect query metrics. Currently
only query hash is present in this log. Adding query id into it makes
such accounting easier.
Testing: The equality of query id in the query profile and lineage log
is checked in test_lineage.py. A test for TUniqueIdUtil is added to the
FE tests.
Change-Id: I4adbd02df37a234dbb79f58b7c46ca11a914229f
Reviewed-on: http://gerrit.cloudera.org:8080/8589
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/util/lineage-util.h
M common/thrift/LineageGraph.thrift
M fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java
A fe/src/main/java/org/apache/impala/util/TUniqueIdUtil.java
A fe/src/test/java/org/apache/impala/util/TUniqueIdUtilTest.java
M testdata/workloads/functional-planner/queries/PlannerTest/lineage.test
M tests/custom_cluster/test_lineage.py
7 files changed, 186 insertions(+), 7 deletions(-)
Approvals:
Alex Behm: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4adbd02df37a234dbb79f58b7c46ca11a914229f
Gerrit-Change-Number: 8589
Gerrit-PatchSet: 5
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
[Impala-ASF-CR] IMPALA-6210: Add query id to lineage graph logging
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8589 )
Change subject: IMPALA-6210: Add query id to lineage graph logging
......................................................................
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1567/
--
To view, visit http://gerrit.cloudera.org:8080/8589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4adbd02df37a234dbb79f58b7c46ca11a914229f
Gerrit-Change-Number: 8589
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Dec 2017 09:50:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6210: Add query id to lineage graph logging
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8589 )
Change subject: IMPALA-6210: Add query id to lineage graph logging
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1567/
--
To view, visit http://gerrit.cloudera.org:8080/8589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4adbd02df37a234dbb79f58b7c46ca11a914229f
Gerrit-Change-Number: 8589
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Dec 2017 06:16:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6210: Add query id to lineage graph logging
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8589 )
Change subject: IMPALA-6210: Add query id to lineage graph logging
......................................................................
Patch Set 1:
(4 comments)
Thanks! This looks largely good to me.
Would you mind adding an assertion to tests/custom_cluster/test_lineage.py that the query id is populated, and is maybe the same as reported in the profile?
It's trivial, but it'd be nice to convince ourselves that TUniqueIdUtil.java matches the C++ implementations, too.
http://gerrit.cloudera.org:8080/#/c/8589/1/common/thrift/LineageGraph.thrift
File common/thrift/LineageGraph.thrift:
http://gerrit.cloudera.org:8080/#/c/8589/1/common/thrift/LineageGraph.thrift@55
PS1, Line 55: 3: required string hash
It's poor form to renumber thrift structs. Typically, you just use the next available number. This makes serialized structs compatible over time.
(In practice, these are internal RPCs and are unlikely to have been serialized, but I think it's best not to violate the rules.)
See https://developers.google.com/protocol-buffers/docs/proto#assigning-tags about "unique numbered tags". Thrift and ProtoBuf are basically isomorphic in this respect.
http://gerrit.cloudera.org:8080/#/c/8589/1/fe/src/main/java/org/apache/impala/util/TUniqueIdUtil.java
File fe/src/main/java/org/apache/impala/util/TUniqueIdUtil.java:
http://gerrit.cloudera.org:8080/#/c/8589/1/fe/src/main/java/org/apache/impala/util/TUniqueIdUtil.java@25
PS1, Line 25: public class TUniqueIdUtil {
I didn't see any test code for this. It'd be good to unit test it, and confirm that you're getting the same results as the tests in be/src/util/debug-util-test.cc. Should be quick, and it'd be good to check that the Java and C++ versions of this code are identical.
http://gerrit.cloudera.org:8080/#/c/8589/1/fe/src/main/java/org/apache/impala/util/TUniqueIdUtil.java@26
PS1, Line 26: public static String Print(TUniqueId id) {
This is called PrintId() and ParseId() in be/src/util/debug-util.cc. Perhaps use the same name to make it more obvious?
http://gerrit.cloudera.org:8080/#/c/8589/1/fe/src/main/java/org/apache/impala/util/TUniqueIdUtil.java@31
PS1, Line 31: String[] splitted = id.split(":");
nit: one space after =.
--
To view, visit http://gerrit.cloudera.org:8080/8589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4adbd02df37a234dbb79f58b7c46ca11a914229f
Gerrit-Change-Number: 8589
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Nov 2017 23:25:18 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6210: Add query id to lineage graph logging
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8589 )
Change subject: IMPALA-6210: Add query id to lineage graph logging
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4adbd02df37a234dbb79f58b7c46ca11a914229f
Gerrit-Change-Number: 8589
Gerrit-PatchSet: 4
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Dec 2017 21:11:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6210: Add query id to lineage graph logging
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8589 )
Change subject: IMPALA-6210: Add query id to lineage graph logging
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4adbd02df37a234dbb79f58b7c46ca11a914229f
Gerrit-Change-Number: 8589
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Dec 2017 06:16:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6210: Add query id to lineage graph logging
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8589 )
Change subject: IMPALA-6210: Add query id to lineage graph logging
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1574/
--
To view, visit http://gerrit.cloudera.org:8080/8589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4adbd02df37a234dbb79f58b7c46ca11a914229f
Gerrit-Change-Number: 8589
Gerrit-PatchSet: 4
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Dec 2017 21:11:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6210: Add query id to lineage graph logging
Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/8589 )
Change subject: IMPALA-6210: Add query id to lineage graph logging
......................................................................
IMPALA-6210: Add query id to lineage graph logging
Some tools use lineage graph logging to collect query metrics. Currently
only query hash is present in this log. Adding query id into it makes
such accounting easier.
Testing: The equality of query id in the query profile and lineage log
is checked in test_lineage.py. A test for TUniqueIdUtil is added to the
FE tests.
Change-Id: I4adbd02df37a234dbb79f58b7c46ca11a914229f
---
M be/src/util/lineage-util.h
M common/thrift/LineageGraph.thrift
M fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java
A fe/src/main/java/org/apache/impala/util/TUniqueIdUtil.java
A fe/src/test/java/org/apache/impala/util/TUniqueIdUtilTest.java
M testdata/workloads/functional-planner/queries/PlannerTest/lineage.test
M tests/custom_cluster/test_lineage.py
7 files changed, 186 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/8589/3
--
To view, visit http://gerrit.cloudera.org:8080/8589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4adbd02df37a234dbb79f58b7c46ca11a914229f
Gerrit-Change-Number: 8589
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
[Impala-ASF-CR] IMPALA-6210: Add query id to lineage graph logging
Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/8589 )
Change subject: IMPALA-6210: Add query id to lineage graph logging
......................................................................
IMPALA-6210: Add query id to lineage graph logging
Some tools use lineage graph logging to collect query metrics. Currently
only query hash is present in this log. Adding query id into it makes
such accounting easier.
Testing: The equality of query id in the query profile and lineage log
is checked in test_lineage.py. A test for TUniqueIdUtil is added to the
FE tests.
Change-Id: I4adbd02df37a234dbb79f58b7c46ca11a914229f
---
M be/src/util/lineage-util.h
M common/thrift/LineageGraph.thrift
M fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java
A fe/src/main/java/org/apache/impala/util/TUniqueIdUtil.java
A fe/src/test/java/org/apache/impala/util/TUniqueIdUtilTest.java
M testdata/workloads/functional-planner/queries/PlannerTest/lineage.test
M tests/custom_cluster/test_lineage.py
7 files changed, 186 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/8589/4
--
To view, visit http://gerrit.cloudera.org:8080/8589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4adbd02df37a234dbb79f58b7c46ca11a914229f
Gerrit-Change-Number: 8589
Gerrit-PatchSet: 4
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
[Impala-ASF-CR] IMPALA-6210: Add query id to lineage graph logging
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8589 )
Change subject: IMPALA-6210: Add query id to lineage graph logging
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
This looks good to me. Thanks for adding the tests.
The Thrift comments below are largely philosophical, though they wouldn't be in the case of the query profile.
http://gerrit.cloudera.org:8080/#/c/8589/1/common/thrift/LineageGraph.thrift
File common/thrift/LineageGraph.thrift:
http://gerrit.cloudera.org:8080/#/c/8589/1/common/thrift/LineageGraph.thrift@55
PS1, Line 55: 3: required string user
> Done. Does this mean ideally we shouldn't change those numbers or removing
In the strictest sense, you'd never re-use the numbers. You can remove an existing field today, just don't re-use the number. See https://www.quora.com/What-are-the-key-differences-between-Apache-Thrift-Google-Protocol-Buffers-MessagePack-ASN-1-BERT-and-Apache-Avro-All-of-these-provide-binary-serialization-RPC-frameworks-and-IDL-What-are-their-different-characteristics-performance-etc/answer/Philip-Zeyliger for more on this stuff, but we're not as affected by it here.
(In something like the Impala Runtime Profile, we are affected by this: we serialize that to log files which tools read, and it'd be bad to break these rules there.)
http://gerrit.cloudera.org:8080/#/c/8589/2/common/thrift/LineageGraph.thrift
File common/thrift/LineageGraph.thrift:
http://gerrit.cloudera.org:8080/#/c/8589/2/common/thrift/LineageGraph.thrift@69
PS2, Line 69: 8: required Types.TUniqueId query_id
It doesn't actually matter because we don't serialize these, but 'required' typically means that this will fail to parse an old serialized TLineageGraph from previous versions of Impala. I think your usage here is consistent with how we use Thrift here, so I think it's likely harmless.
--
To view, visit http://gerrit.cloudera.org:8080/8589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4adbd02df37a234dbb79f58b7c46ca11a914229f
Gerrit-Change-Number: 8589
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Nov 2017 00:11:21 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6210: Add query id to lineage graph logging
Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8589 )
Change subject: IMPALA-6210: Add query id to lineage graph logging
......................................................................
IMPALA-6210: Add query id to lineage graph logging
Some tools use lineage graph logging to collect query metrics. Currently
only query hash is present in this log. Adding query id into it makes
such accounting easier.
Testing: The equality of query id in the query profile and lineage log
is checked in test_lineage.py. A test for TUniqueIdUtil is added to the
FE tests.
Change-Id: I4adbd02df37a234dbb79f58b7c46ca11a914229f
---
M be/src/util/lineage-util.h
M common/thrift/LineageGraph.thrift
M fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java
A fe/src/main/java/org/apache/impala/util/TUniqueIdUtil.java
A fe/src/test/java/org/apache/impala/util/TUniqueIdUtilTest.java
M testdata/workloads/functional-planner/queries/PlannerTest/lineage.test
M tests/custom_cluster/test_lineage.py
7 files changed, 185 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/8589/2
--
To view, visit http://gerrit.cloudera.org:8080/8589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4adbd02df37a234dbb79f58b7c46ca11a914229f
Gerrit-Change-Number: 8589
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
[Impala-ASF-CR] IMPALA-6210: Add query id to lineage graph logging
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8589 )
Change subject: IMPALA-6210: Add query id to lineage graph logging
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/8589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4adbd02df37a234dbb79f58b7c46ca11a914229f
Gerrit-Change-Number: 8589
Gerrit-PatchSet: 4
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Dec 2017 00:52:18 +0000
Gerrit-HasComments: No