You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/02/22 03:43:03 UTC

[GitHub] [commons-csv] shootercheng opened a new pull request #58: export page data from db

shootercheng opened a new pull request #58: export page data from db
URL: https://github.com/apache/commons-csv/pull/58
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-csv] garydgregory commented on issue #58: export page data from db

Posted by GitBox <gi...@apache.org>.

garydgregory commented on issue #58: export page data from db
URL: https://github.com/apache/commons-csv/pull/58#issuecomment-590080098
 
 
   Google translate says:
   
   > I have used printRecords (ResultSet) to export csv data before, but when the amount of data is relatively large, there is a problem with the export, so I added this export method, and it seems that it can be built separately, but there is nothing here Problem, enhanced the original export function
   
   
   I do not see enhancements in this PR that has anything to do with JDBC. What am I missing?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-csv] shootercheng commented on issue #58: export page data from db

Posted by GitBox <gi...@apache.org>.

shootercheng commented on issue #58: export page data from db
URL: https://github.com/apache/commons-csv/pull/58#issuecomment-590014980
 
 
   今天添加JavaDoc ，实现分页查询导出数据库的数据到 CSV
   
   
    
   ---Original---
   From: "Gary Gregory"<notifications@github.com&gt;
   Date: Sat, Feb 22, 2020 21:06 PM
   To: "apache/commons-csv"<commons-csv@noreply.github.com&gt;;
   Cc: "Comment"<comment@noreply.github.com&gt;;"James Sun"<3281328128@qq.com&gt;;
   Subject: Re: [apache/commons-csv] export page data from db (#58)
   
   
   
   This ticket has no description so I have no idea what the intent is here. The lack of Javadoc does not help either.
    
   —
   You are receiving this because you commented.
   Reply to this email directly, view it on GitHub, or unsubscribe.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-csv] shootercheng commented on issue #58: export page data from db

Posted by GitBox <gi...@apache.org>.

shootercheng commented on issue #58: export page data from db
URL: https://github.com/apache/commons-csv/pull/58#issuecomment-590017392
 
 
   > intent
   
   
   
   > This ticket has no description so I have no idea what the intent is here. The lack of Javadoc does not help either.
   
   you can see the method DbQueryExportTest.testExport(),  this test method will export querying page data from db

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-csv] coveralls edited a comment on issue #58: export page data from db

Posted by GitBox <gi...@apache.org>.

coveralls edited a comment on issue #58: export page data from db
URL: https://github.com/apache/commons-csv/pull/58#issuecomment-589916433
 
 
   
   [![Coverage Status](https://coveralls.io/builds/28893848/badge)](https://coveralls.io/builds/28893848)
   
   Coverage decreased (-2.9%) to 90.368% when pulling **ed6a7fea2dff59866dfefbbbcd9977d61be3428c on shootercheng:master** into **e503c568a10ae42364a94695b8505bcb4db28969 on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-csv] shootercheng commented on issue #58: export page data from db

Posted by GitBox <gi...@apache.org>.

shootercheng commented on issue #58: export page data from db
URL: https://github.com/apache/commons-csv/pull/58#issuecomment-590321805
 
 
   > Google translate says:
   > 
   > > I have used printRecords (ResultSet) to export csv data before, but when the amount of data is relatively large, there is a problem with the export, so I added this export method, and it seems that it can be built separately, but there is nothing here Problem, enhanced the original export function
   > 
   > I do not see enhancements in this PR that has anything to do with JDBC. What am I missing?
   
   time 64218 ms
   
   https://github.com/shootercheng/batch/tree/export
   
   How to use JDBC in this demo web project? You should add more base code.Show me wasting less time for using commons-csv !

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-csv] shootercheng removed a comment on issue #58: export page data from db

Posted by GitBox <gi...@apache.org>.

shootercheng removed a comment on issue #58: export page data from db
URL: https://github.com/apache/commons-csv/pull/58#issuecomment-590321037
 
 
   time 64218 ms 
   
   https://github.com/shootercheng/batch/tree/export
   
   How to use JDBC  in this demo web project? You should add more base code.Show me wasting less time for using commons-csv !
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-csv] coveralls edited a comment on issue #58: export page data from db

Posted by GitBox <gi...@apache.org>.

coveralls edited a comment on issue #58: export page data from db
URL: https://github.com/apache/commons-csv/pull/58#issuecomment-589916433
 
 
   
   [![Coverage Status](https://coveralls.io/builds/28893736/badge)](https://coveralls.io/builds/28893736)
   
   Coverage decreased (-4.8%) to 88.385% when pulling **9e1760fd820e2952943de1ae1f53ceb1d738ce76 on shootercheng:master** into **e503c568a10ae42364a94695b8505bcb4db28969 on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-csv] coveralls commented on issue #58: export page data from db

Posted by GitBox <gi...@apache.org>.

coveralls commented on issue #58: export page data from db
URL: https://github.com/apache/commons-csv/pull/58#issuecomment-589916433
 
 
   
   [![Coverage Status](https://coveralls.io/builds/28892811/badge)](https://coveralls.io/builds/28892811)
   
   Coverage decreased (-4.8%) to 88.385% when pulling **1bf86bfbc7df0098d7360f975069d6516edbf32b on shootercheng:master** into **e503c568a10ae42364a94695b8505bcb4db28969 on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-csv] coveralls edited a comment on issue #58: export page data from db

Posted by GitBox <gi...@apache.org>.

coveralls edited a comment on issue #58: export page data from db
URL: https://github.com/apache/commons-csv/pull/58#issuecomment-589916433
 
 
   
   [![Coverage Status](https://coveralls.io/builds/28893984/badge)](https://coveralls.io/builds/28893984)
   
   Coverage decreased (-1.9%) to 91.313% when pulling **70f6ad23ae3fd98b76e42639cc67072cd8b66e0d on shootercheng:master** into **e503c568a10ae42364a94695b8505bcb4db28969 on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-csv] shootercheng commented on issue #58: export page data from db

Posted by GitBox <gi...@apache.org>.

shootercheng commented on issue #58: export page data from db
URL: https://github.com/apache/commons-csv/pull/58#issuecomment-590023179

I am so sorry , I have closed it.

---Original---
From: "Gary Gregory"<notifications@github.com&gt;
Date: Sun, Feb 23, 2020 11:02 AM
To: "apache/commons-csv"<commons-csv@noreply.github.com&gt;;
Cc: "Mention"<mention@noreply.github.com&gt;;"James Sun"<3281328128@qq.com&gt;;
Subject: Re: [apache/commons-csv] export page data from db (#58)

intent

This ticket has no description so I have no idea what the intent is here. The lack of Javadoc does not help either.

you can see the method DbQueryExportTest.testExport(), this test method will export querying page data from db

@shootercheng
I'm sorry so say that you're not helping your PR here :-( You should provide some kind of description for this PR so that people can learn what problem this PR attempts to solve and how. This would then allow reviewers to try to understand if this code belongs here and how it can fit in. I suppose you could fill in the Javadoc at a later phase of your development (but before any merge into Commons CSV.)

If you want to export database rows, you can use org.apache.commons.csv.CSVPrinter.printRecords(ResultSet) which works with Java's own JDBC framework. The printer class also provides other types of services to create CSV files.

More importantly, I see zero reuse of Commons CSV's code for which this PR seems to duplicate features like using your ExportParam instead of CVS's CSVFormat. It seems this PR is complete;y standalone code from Commons CSV since it does not reuse any of Commons CSV's code. Why would it belong within Commons CSV?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [commons-csv] shootercheng commented on issue #58: export page data from db

Posted by GitBox <gi...@apache.org>.

shootercheng commented on issue #58: export page data from db
URL: https://github.com/apache/commons-csv/pull/58#issuecomment-590318365
 
 
   > Google translate says:
   > 
   > > I have used printRecords (ResultSet) to export csv data before, but when the amount of data is relatively large, there is a problem with the export, so I added this export method, and it seems that it can be built separately, but there is nothing here Problem, enhanced the original export function
   > 
   > I do not see enhancements in this PR that has anything to do with JDBC. What am I missing?
   Please see my demo project for export page data from db, it takes less time
   https://github.com/shootercheng/batch/tree/export
   `
   21:19:59.967 [main] DEBUG com.single.batch.mapper.BatchLabelMapper.selectPage - ==>  Preparing: select concat_ws(',', id, ifnull(parent,''), ifnull(code,''), ifnull(status,''), ifnull(type,''), ifnull(customer_id,''), ifnull(operator_id,''), ifnull(reseller_id,''), ifnull(user_id,''), ifnull(product_id,''), ifnull(batch,''), ifnull(query_times,''), ifnull(first_time,''), ifnull(create_time,''), ifnull(update_time,'') ) from label_1 limit ?,? 
   21:19:59.968 [main] DEBUG com.single.batch.mapper.BatchLabelMapper.selectPage - ==> Parameters: 990000(Integer), 10000(Integer)
   21:20:01.126 [main] DEBUG com.single.batch.mapper.BatchLabelMapper.selectPage - <==      Total: 10000
   21:20:01.131 [main] DEBUG org.apache.ibatis.transaction.jdbc.JdbcTransaction - Resetting autocommit to true on JDBC Connection [com.mysql.cj.jdbc.ConnectionImpl@59309333]
   21:20:01.131 [main] DEBUG org.apache.ibatis.transaction.jdbc.JdbcTransaction - Closing JDBC Connection [com.mysql.cj.jdbc.ConnectionImpl@59309333]
   time 64218 ms
   `

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-csv] shootercheng commented on issue #58: export page data from db

Posted by GitBox <gi...@apache.org>.

shootercheng commented on issue #58: export page data from db
URL: https://github.com/apache/commons-csv/pull/58#issuecomment-589914829
 
 
   Failed to execute goal org.apache.rat:apache-rat-plugin:0.13:check (rat-check) on project commons-csv: Execution rat-check of goal org.apache.rat:apache-rat-plugin:0.13:check failed: Plugin org.apache.rat:apache-rat-plugin:0.13 or one of its dependencies could not be resolved: Could not transfer artifact commons-collections:commons-collections:jar:3.2.2 from/to google-maven-central (https://maven-central.storage-download.googleapis.com/maven2/): GET request of: commons-collections/commons-collections/3.2.2/commons-collections-3.2.2.jar from google-maven-central failed: Connection reset

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-csv] coveralls edited a comment on issue #58: export page data from db

Posted by GitBox <gi...@apache.org>.

coveralls edited a comment on issue #58: export page data from db
URL: https://github.com/apache/commons-csv/pull/58#issuecomment-589916433
 
 
   
   [![Coverage Status](https://coveralls.io/builds/28894030/badge)](https://coveralls.io/builds/28894030)
   
   Coverage decreased (-1.3%) to 91.879% when pulling **ebe4a60a21e47125170cb17ab51f753f5b290d83 on shootercheng:master** into **e503c568a10ae42364a94695b8505bcb4db28969 on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-csv] coveralls edited a comment on issue #58: export page data from db

Posted by GitBox <gi...@apache.org>.

coveralls edited a comment on issue #58: export page data from db
URL: https://github.com/apache/commons-csv/pull/58#issuecomment-589916433
 
 
   
   [![Coverage Status](https://coveralls.io/builds/28900281/badge)](https://coveralls.io/builds/28900281)
   
   Coverage decreased (-1.3%) to 91.879% when pulling **6444993df822ece3dddca3981dc3bf323224fa6e on shootercheng:master** into **e503c568a10ae42364a94695b8505bcb4db28969 on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [commons-csv] shootercheng commented on issue #58: export page data from db

Posted by GitBox <gi...@apache.org>.

shootercheng commented on issue #58: export page data from db
URL: https://github.com/apache/commons-csv/pull/58#issuecomment-589939564
 
 
   > [![Coverage Status](https://camo.githubusercontent.com/b2500dbd6134a70cb5f7494693b588e076dd9408/68747470733a2f2f636f766572616c6c732e696f2f6275696c64732f32383839343038372f6261646765)](https://coveralls.io/builds/28894087)
   > 
   > Coverage decreased (-1.3%) to 91.879% when pulling **[f98dfe2](https://github.com/apache/commons-csv/commit/f98dfe2e8b8169c42e7aaa2692389dcc132f1bd9) on shootercheng:master** into **[e503c56](https://github.com/apache/commons-csv/commit/e503c568a10ae42364a94695b8505bcb4db28969) on apache:master**.
   
   所有的方法都测试了，这个覆盖率检测有bug

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services