You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@brooklyn.apache.org by al...@apache.org on 2016/07/12 11:32:47 UTC
[2/3] brooklyn-server git commit: BROOKLYN-272: disable
ConfigYamlTest getNonBlocking
BROOKLYN-272: disable ConfigYamlTest getNonBlocking
Project: http://git-wip-us.apache.org/repos/asf/brooklyn-server/repo
Commit: http://git-wip-us.apache.org/repos/asf/brooklyn-server/commit/ac727fdf
Tree: http://git-wip-us.apache.org/repos/asf/brooklyn-server/tree/ac727fdf
Diff: http://git-wip-us.apache.org/repos/asf/brooklyn-server/diff/ac727fdf
Branch: refs/heads/master
Commit: ac727fdf1d0108858ad60ce451d4b63b0f6e9777
Parents: 6e16116
Author: Aled Sage <al...@gmail.com>
Authored: Sat Jul 9 00:35:34 2016 +0100
Committer: Aled Sage <al...@gmail.com>
Committed: Sat Jul 9 11:01:38 2016 +0100
----------------------------------------------------------------------
.../brooklyn/camp/brooklyn/ConfigYamlTest.java | 21 ++++++++++++++++++--
1 file changed, 19 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/brooklyn-server/blob/ac727fdf/camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/ConfigYamlTest.java
----------------------------------------------------------------------
diff --git a/camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/ConfigYamlTest.java b/camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/ConfigYamlTest.java
index 867122f..19c81d8 100644
--- a/camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/ConfigYamlTest.java
+++ b/camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/ConfigYamlTest.java
@@ -182,7 +182,16 @@ public class ConfigYamlTest extends AbstractYamlTest {
assertEquals(entity.config().get(TestEntity.CONF_SET_PLAIN), ImmutableSet.of("myOther"));
}
- @Test
+ /**
+ * TODO The {@code entity.config().getNonBlocking()} can return absent. When it's called with
+ * a deferred supplier value, it will kick off a task and then wait just a few millis for that
+ * task to execute deferredSupplier.get(). If it times out, then it returns Maybe.absent.
+ * However, on apache jenkins the machine is often slow so the task doesn't complete in the
+ * given number of millis (even though deferredSupplier.get() doesn't need to block for anything).
+ * Same for {@link #testDeferredSupplierToAttributeWhenReadyInSpecialTypes()}.
+ * See https://issues.apache.org/jira/browse/BROOKLYN-272.
+ */
+ @Test(groups="Broken")
public void testDeferredSupplierToAttributeWhenReady() throws Exception {
String yaml = Joiner.on("\n").join(
"services:",
@@ -210,8 +219,16 @@ public class ConfigYamlTest extends AbstractYamlTest {
/**
* This tests config keys of type {@link org.apache.brooklyn.core.config.MapConfigKey}, etc.
* For plain maps, see {@link #testDeferredSupplierToAttributeWhenReadyInPlainCollections()}.
+ *
+ * TODO The {@code entity.config().getNonBlocking()} can return absent. When it's called with
+ * a deferred supplier value, it will kick off a task and then wait just a few millis for that
+ * task to execute deferredSupplier.get(). If it times out, then it returns Maybe.absent.
+ * However, on apache jenkins the machine is often slow so the task doesn't complete in the
+ * given number of millis (even though deferredSupplier.get() doesn't need to block for anything).
+ * Same for {@link #testDeferredSupplierToAttributeWhenReady()}.
+ * See https://issues.apache.org/jira/browse/BROOKLYN-272.
*/
- @Test
+ @Test(groups="Broken")
public void testDeferredSupplierToAttributeWhenReadyInSpecialTypes() throws Exception {
String yaml = Joiner.on("\n").join(
"services:",