You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/03 10:23:33 UTC
[GitHub] [arrow-rs] tustvold opened a new issue, #2294: JsonEqual for DictionaryArray Only Compares Keys
tustvold opened a new issue, #2294:
URL: https://github.com/apache/arrow-rs/issues/2294
**Describe the bug**
<!--
A clear and concise description of what the bug is.
-->
```
impl<T: ArrowPrimitiveType> JsonEqual for DictionaryArray<T> {
fn equals_json(&self, json: &[&Value]) -> bool {
// todo: this is wrong: we must test the values also
self.keys().equals_json(json)
}
}
```
**To Reproduce**
<!--
Steps to reproduce the behavior:
-->
**Expected behavior**
<!--
A clear and concise description of what you expected to happen.
-->
**Additional context**
<!--
Add any other context about the problem here.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold closed issue #2294: JsonEqual for DictionaryArray Only Compares Keys
Posted by GitBox <gi...@apache.org>.
tustvold closed issue #2294: JsonEqual for DictionaryArray Only Compares Keys
URL: https://github.com/apache/arrow-rs/issues/2294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on issue #2294: JsonEqual for DictionaryArray Only Compares Keys
Posted by GitBox <gi...@apache.org>.
tustvold commented on issue #2294:
URL: https://github.com/apache/arrow-rs/issues/2294#issuecomment-1220759059
JsonEqual was removed in #2296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org