[GitHub] taegeonum closed pull request #165: [NEMO-221] Confusing error messages for a failure at the client-side …

[GitBox <gi...@apache.org>]

taegeonum closed pull request #165: [NEMO-221] Confusing error messages for a failure at the client-side …
URL: https://github.com/apache/incubator-nemo/pull/165
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/runtime/master/src/main/java/org/apache/nemo/runtime/master/ClientRPC.java b/runtime/master/src/main/java/org/apache/nemo/runtime/master/ClientRPC.java
index f17f284ae..213f9a1b9 100644
--- a/runtime/master/src/main/java/org/apache/nemo/runtime/master/ClientRPC.java
+++ b/runtime/master/src/main/java/org/apache/nemo/runtime/master/ClientRPC.java
@@ -58,11 +58,16 @@
   private ClientRPC(final TransportFactory transportFactory,
                     final LocalAddressProvider localAddressProvider,
                     @Parameter(JobConf.ClientSideRPCServerHost.class) final String clientHost,
-                    @Parameter(JobConf.ClientSideRPCServerPort.class) final int clientPort) throws IOException {
+                    @Parameter(JobConf.ClientSideRPCServerPort.class) final int clientPort) {
     transport = transportFactory.newInstance(localAddressProvider.getLocalAddress(),
         0, new SyncStage<>(new RPCEventHandler()), null, RETRY_COUNT, RETRY_TIMEOUT);
     final SocketAddress clientAddress = new InetSocketAddress(clientHost, clientPort);
-    link = transport.open(clientAddress, ENCODER, LINK_LISTENER);
+    try {
+      link = transport.open(clientAddress, ENCODER, LINK_LISTENER);
+    } catch (final IOException e) {
+      throw new IllegalStateException("Failed to setup an RPC connection to the Client. "
+        + "A failure at the client-side is suspected.");
+    }
   }
 
   /**


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services