You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by John Sirois <jo...@gmail.com> on 2015/11/02 17:37:30 UTC
Re: Review Request 39784: Upgrade Aurora to pants 0.0.55.
> On Oct. 29, 2015, 4:24 p.m., Zameer Manji wrote:
> > Would you also mind updating the commit message to point to the pants changelog?
Will do.
> On Oct. 29, 2015, 4:24 p.m., Zameer Manji wrote:
> > BUILD.tools, line 1
> > <https://reviews.apache.org/r/39784/diff/1/?file=1112517#file1112517line1>
> >
> > Aurora only uses pants for Python code. If we need to specify these JVM artifacts for it to work right now, can you please maintain the reference to issue 867?
Did not mean to nuke that - will restore.
> On Oct. 29, 2015, 4:24 p.m., Zameer Manji wrote:
> > pants.ini, line 14
> > <https://reviews.apache.org/r/39784/diff/1/?file=1112523#file1112523line14>
> >
> > Is this comment relevant anymore? If not mind removing it?
I'll kill it, its not a lie, but not particularaly useful.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39784/#review104484
-----------------------------------------------------------
On Oct. 29, 2015, 4:05 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39784/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2015, 4:05 p.m.)
>
>
> Review request for Aurora, Joe Smith, Bill Farner, and Zameer Manji.
>
>
> Bugs: AURORA-1499
> https://issues.apache.org/jira/browse/AURORA-1499
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This also brings Aurora up to pex 1.1.0 and switches to the pants
> setup script; an equivalent to gradlew. Of note, the script is checked
> in with chmod 555, its not intended to be edited.
>
> Although pants now includes checkstyle built in, conversion to use it is
> left for follow-on work.
>
> Also adapt make-pycharm-virtualenv which previously relied on the local
> bootstrapping of pants - now hidden away by the pants setup script.
>
> .pantsversion | 1 -
> 3rdparty/python/requirements.txt | 2 +-
> BUILD | 25 -------------
> BUILD.tools | 19 ++++++++--
> build-support/jenkins/build.sh | 2 +-
> build-support/pants_requirements.txt | 30 ---------------
> build-support/python/make-pycharm-virtualenv | 11 +++++-
> build-support/python/update-pants-requirements | 34 -----------------
> pants | 102 +++++++++++++++++++++++++++++++++++++++-----------
> pants.ini | 63 ++-----------------------------
> src/main/python/apache/aurora/tools/BUILD | 2 +-
> src/main/python/apache/thermos/observer/BUILD | 2 +-
> 12 files changed, 114 insertions(+), 179 deletions(-)
>
>
> Diffs
> -----
>
> .pantsversion 78bae5bb6d254d014e35be0b828497f1509d80bd
> 3rdparty/python/requirements.txt 1eeb36dee1a0ebd33999bbb3327338a51cba00d7
> BUILD 7de0c74b03ba609576867ba96885858c0908f2e9
> BUILD.tools 75698a5ded7914a4d22ab7ae769d9ed1576531e4
> build-support/jenkins/build.sh 5606bb157cb117a588f363382d7c8841ae957138
> build-support/pants_requirements.txt fad8da5ce4c03f25554394bc628d4fbb0fe6cd69
> build-support/python/make-pycharm-virtualenv d7bd41835bcd9a8fe62ea522a177bfa7830a897b
> build-support/python/update-pants-requirements 82f7c5136fad52f4bc2a458beb5f34f0cc7f6cec
> pants 6f3526ef76fc37e3215b0673bcb1725d205a1c95
> pants.ini dd4ba668586ee5bd1c888f315429e661adb6a480
> src/main/python/apache/aurora/tools/BUILD e5ac75838cbe98bbef4e35f6f300b6a6df5e7de5
> src/main/python/apache/thermos/observer/BUILD d7eedabc0930711530b45ac98a1159e69d1a0c00
>
> Diff: https://reviews.apache.org/r/39784/diff/
>
>
> Testing
> -------
>
> Locally: `./pants test.pytest --no-fast src/test/python:: -- -v`
>
> Also generated a pycharm project via:
> `./build-support/python/make-pycharm-virtualenv`
> Confirmed library source linking worked as did running unit tests
> via the IDE.
>
> Also grepped for pants commands in the repo, found `binary` and `setup-py`
> and confirmed these worked.
>
>
> Thanks,
>
> John Sirois
>
>