You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Valentin Valchev (JIRA)" <ji...@apache.org> on 2010/04/07 11:24:33 UTC

[jira] Created: (FELIX-2256) Some small visual defects in the WebConsole

Some small visual defects in the WebConsole
-------------------------------------------

                 Key: FELIX-2256
                 URL: https://issues.apache.org/jira/browse/FELIX-2256
             Project: Felix
          Issue Type: Bug
          Components: Web Console
    Affects Versions: webconsole-3.0.0
            Reporter: Valentin Valchev




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-2256) Some small visual defects in the WebConsole

Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-2256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854500#action_12854500 ] 

Valentin Valchev commented on FELIX-2256:
-----------------------------------------

In Ref. 931546 fixed visual defect 1 & 2 - log & bundles columns

> Some small visual defects in the WebConsole
> -------------------------------------------
>
>                 Key: FELIX-2256
>                 URL: https://issues.apache.org/jira/browse/FELIX-2256
>             Project: Felix
>          Issue Type: Bug
>          Components: Web Console
>    Affects Versions: webconsole-3.0.0
>            Reporter: Valentin Valchev
>         Attachments: bomfix.patch, logo_issue.png, visual_bug.JPG, visual_bug1.JPG, visual_bug2.JPG
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-2256) Some small visual defects in the WebConsole

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-2256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854478#action_12854478 ] 

Felix Meschberger commented on FELIX-2256:
------------------------------------------

In Rev. 931529 fixed an issue with the log image height: If the log provided by a branding plugin is too high it extends into the top navigation area. By setting the img tag size to the height of the #lead <DIV> minus the top padding allows the browser to scale down the image as needed.

> Some small visual defects in the WebConsole
> -------------------------------------------
>
>                 Key: FELIX-2256
>                 URL: https://issues.apache.org/jira/browse/FELIX-2256
>             Project: Felix
>          Issue Type: Bug
>          Components: Web Console
>    Affects Versions: webconsole-3.0.0
>            Reporter: Valentin Valchev
>         Attachments: bomfix.patch, visual_bug.JPG, visual_bug1.JPG, visual_bug2.JPG
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-2256) Some small visual defects in the WebConsole

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-2256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854449#action_12854449 ] 

Felix Meschberger commented on FELIX-2256:
------------------------------------------

The BOM patch sounds like ok. 

According to http://www.unicode.org/faq/utf_bom.html#BOM the BOM is a single fixed character U+FFEF, which should be uniquely encoded in UTF-8 files. Thus I suspect we need only test for this single character instead of other byte variations ?

Somehting like:

   if (string.charAt(0) == '\uFFEF') string = string.substring(1);


> Some small visual defects in the WebConsole
> -------------------------------------------
>
>                 Key: FELIX-2256
>                 URL: https://issues.apache.org/jira/browse/FELIX-2256
>             Project: Felix
>          Issue Type: Bug
>          Components: Web Console
>    Affects Versions: webconsole-3.0.0
>            Reporter: Valentin Valchev
>         Attachments: bomfix.patch, visual_bug.JPG, visual_bug1.JPG, visual_bug2.JPG
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FELIX-2256) Some small visual defects in the WebConsole

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger updated FELIX-2256:
-------------------------------------

    Attachment: logo_issue.png

Logo issue fixed by Rev. 931529

> Some small visual defects in the WebConsole
> -------------------------------------------
>
>                 Key: FELIX-2256
>                 URL: https://issues.apache.org/jira/browse/FELIX-2256
>             Project: Felix
>          Issue Type: Bug
>          Components: Web Console
>    Affects Versions: webconsole-3.0.0
>            Reporter: Valentin Valchev
>         Attachments: bomfix.patch, logo_issue.png, visual_bug.JPG, visual_bug1.JPG, visual_bug2.JPG
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (FELIX-2256) Some small visual defects in the WebConsole

Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Valentin Valchev reassigned FELIX-2256:
---------------------------------------

    Assignee: Valentin Valchev

> Some small visual defects in the WebConsole
> -------------------------------------------
>
>                 Key: FELIX-2256
>                 URL: https://issues.apache.org/jira/browse/FELIX-2256
>             Project: Felix
>          Issue Type: Bug
>          Components: Web Console
>    Affects Versions: webconsole-3.0.0
>            Reporter: Valentin Valchev
>            Assignee: Valentin Valchev
>         Attachments: bomfix.patch, logo_issue.png, visual_bug.JPG, visual_bug1.JPG, visual_bug2.JPG
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-2256) Some small visual defects in the WebConsole

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-2256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854468#action_12854468 ] 

Felix Meschberger commented on FELIX-2256:
------------------------------------------

Probably not, because UTF-8 is not succeptible to the same kind of endianness as is UTF-16. Thus the character decoder should properly return the correct BOM value (if it returns the BOM value at all)

> Some small visual defects in the WebConsole
> -------------------------------------------
>
>                 Key: FELIX-2256
>                 URL: https://issues.apache.org/jira/browse/FELIX-2256
>             Project: Felix
>          Issue Type: Bug
>          Components: Web Console
>    Affects Versions: webconsole-3.0.0
>            Reporter: Valentin Valchev
>         Attachments: bomfix.patch, visual_bug.JPG, visual_bug1.JPG, visual_bug2.JPG
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FELIX-2256) Some small visual defects in the WebConsole

Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Valentin Valchev updated FELIX-2256:
------------------------------------

    Attachment: bomfix.patch

I've attached a patch that would fix the BOM problem.

WDYT?

> Some small visual defects in the WebConsole
> -------------------------------------------
>
>                 Key: FELIX-2256
>                 URL: https://issues.apache.org/jira/browse/FELIX-2256
>             Project: Felix
>          Issue Type: Bug
>          Components: Web Console
>    Affects Versions: webconsole-3.0.0
>            Reporter: Valentin Valchev
>         Attachments: bomfix.patch, visual_bug.JPG, visual_bug1.JPG, visual_bug2.JPG
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-2256) Some small visual defects in the WebConsole

Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-2256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854493#action_12854493 ] 

Valentin Valchev commented on FELIX-2256:
-----------------------------------------

Actually for me - the character is '\uFEFF'.
I'm not quite sure how different VMs are implemented. If they don't return the same value and reverse for some reason the bytes, one switch statement is not quite CPU intensive task and will work in all cases ;)

> Some small visual defects in the WebConsole
> -------------------------------------------
>
>                 Key: FELIX-2256
>                 URL: https://issues.apache.org/jira/browse/FELIX-2256
>             Project: Felix
>          Issue Type: Bug
>          Components: Web Console
>    Affects Versions: webconsole-3.0.0
>            Reporter: Valentin Valchev
>         Attachments: bomfix.patch, logo_issue.png, visual_bug.JPG, visual_bug1.JPG, visual_bug2.JPG
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (FELIX-2256) Some small visual defects in the WebConsole

Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Valentin Valchev resolved FELIX-2256.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: webconsole-3.0.2

committed the original patch with the switch - just to make sure that it will work.


> Some small visual defects in the WebConsole
> -------------------------------------------
>
>                 Key: FELIX-2256
>                 URL: https://issues.apache.org/jira/browse/FELIX-2256
>             Project: Felix
>          Issue Type: Bug
>          Components: Web Console
>    Affects Versions: webconsole-3.0.0
>            Reporter: Valentin Valchev
>            Assignee: Valentin Valchev
>             Fix For: webconsole-3.0.2
>
>         Attachments: bomfix.patch, logo_issue.png, visual_bug.JPG, visual_bug1.JPG, visual_bug2.JPG
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-2256) Some small visual defects in the WebConsole

Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-2256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854466#action_12854466 ] 

Valentin Valchev commented on FELIX-2256:
-----------------------------------------

Hmm, i think that we should consider the endiannes so it can also be EFFF


> Some small visual defects in the WebConsole
> -------------------------------------------
>
>                 Key: FELIX-2256
>                 URL: https://issues.apache.org/jira/browse/FELIX-2256
>             Project: Felix
>          Issue Type: Bug
>          Components: Web Console
>    Affects Versions: webconsole-3.0.0
>            Reporter: Valentin Valchev
>         Attachments: bomfix.patch, visual_bug.JPG, visual_bug1.JPG, visual_bug2.JPG
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FELIX-2256) Some small visual defects in the WebConsole

Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Valentin Valchev updated FELIX-2256:
------------------------------------

    Attachment: visual_bug2.JPG
                visual_bug1.JPG
                visual_bug.JPG

These issues are reported by ProSyst testing team.

The first issue I beleive is that InputStreamReader is unable to handle UTF BOM at the beginning of the template files.

The other issues can be easily fixed in the CSS files.

> Some small visual defects in the WebConsole
> -------------------------------------------
>
>                 Key: FELIX-2256
>                 URL: https://issues.apache.org/jira/browse/FELIX-2256
>             Project: Felix
>          Issue Type: Bug
>          Components: Web Console
>    Affects Versions: webconsole-3.0.0
>            Reporter: Valentin Valchev
>         Attachments: visual_bug.JPG, visual_bug1.JPG, visual_bug2.JPG
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.