You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@heron.apache.org by sa...@apache.org on 2022/07/20 23:58:09 UTC

[incubator-heron] 01/03: [Tests] K8s Shim cleanup.

This is an automated email from the ASF dual-hosted git repository.

saadurrahman pushed a commit to branch saadurrahman/3846-Refactoring-K8s-Shim-dev
in repository https://gitbox.apache.org/repos/asf/incubator-heron.git

commit 8d32fa472c3f363f27311399d2334e672ab970dd
Author: Saad Ur Rahman <sa...@apache.org>
AuthorDate: Wed Jul 20 19:56:50 2022 -0400

    [Tests] K8s Shim cleanup.
---
 .../heron/scheduler/kubernetes/KubernetesShimTest.java   | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/heron/schedulers/tests/java/org/apache/heron/scheduler/kubernetes/KubernetesShimTest.java b/heron/schedulers/tests/java/org/apache/heron/scheduler/kubernetes/KubernetesShimTest.java
index 04b57dcfc47..d713d823466 100644
--- a/heron/schedulers/tests/java/org/apache/heron/scheduler/kubernetes/KubernetesShimTest.java
+++ b/heron/schedulers/tests/java/org/apache/heron/scheduler/kubernetes/KubernetesShimTest.java
@@ -409,11 +409,11 @@ public class KubernetesShimTest {
     final Config testConfig = Config.newBuilder()
         .put(POD_TEMPLATE_LOCATION_EXECUTOR, CONFIGMAP_POD_TEMPLATE_NAME)
         .build();
-    final KubernetesShim v1Controller = new KubernetesShim(testConfig, RUNTIME);
+    final KubernetesShim kubernetesShim = new KubernetesShim(testConfig, RUNTIME);
     final Pair<String, String> expected = new Pair<>(CONFIGMAP_NAME, POD_TEMPLATE_NAME);
 
     // Correct parsing
-    final Pair<String, String> actual = v1Controller.getPodTemplateLocation(true);
+    final Pair<String, String> actual = kubernetesShim.getPodTemplateLocation(true);
     Assert.assertEquals(expected, actual);
   }
 
@@ -422,8 +422,8 @@ public class KubernetesShimTest {
     expectedException.expect(TopologySubmissionException.class);
     final Config testConfig = Config.newBuilder()
         .put(POD_TEMPLATE_LOCATION_EXECUTOR, ".POD-TEMPLATE-NAME").build();
-    KubernetesShim v1Controller = new KubernetesShim(testConfig, RUNTIME);
-    v1Controller.getPodTemplateLocation(true);
+    KubernetesShim kubernetesShim = new KubernetesShim(testConfig, RUNTIME);
+    kubernetesShim.getPodTemplateLocation(true);
   }
 
   @Test
@@ -431,8 +431,8 @@ public class KubernetesShimTest {
     expectedException.expect(TopologySubmissionException.class);
     final Config testConfig = Config.newBuilder()
         .put(POD_TEMPLATE_LOCATION_EXECUTOR, "CONFIGMAP-NAME.").build();
-    KubernetesShim v1Controller = new KubernetesShim(testConfig, RUNTIME);
-    v1Controller.getPodTemplateLocation(true);
+    KubernetesShim kubernetesShim = new KubernetesShim(testConfig, RUNTIME);
+    kubernetesShim.getPodTemplateLocation(true);
   }
 
   @Test
@@ -440,8 +440,8 @@ public class KubernetesShimTest {
     expectedException.expect(TopologySubmissionException.class);
     final Config testConfig = Config.newBuilder()
         .put(POD_TEMPLATE_LOCATION_EXECUTOR, "CONFIGMAP-NAMEPOD-TEMPLATE-NAME").build();
-    KubernetesShim v1Controller = new KubernetesShim(testConfig, RUNTIME);
-    v1Controller.getPodTemplateLocation(true);
+    KubernetesShim kubernetesShim = new KubernetesShim(testConfig, RUNTIME);
+    kubernetesShim.getPodTemplateLocation(true);
   }
 
   @Test