You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/28 17:14:58 UTC
[GitHub] [arrow] lidavidm opened a new pull request #7298: ARROW-8975: [FlightRPC][C++] try to fix MacOS flaky tests
lidavidm opened a new pull request #7298:
URL: https://github.com/apache/arrow/pull/7298
This seems OK in CI and should speed up the build as we no longer have to compile Protobuf and gRPC. I'm still a bit bothered since it's unclear upstream whether the root issue is truly fixed or not; if we see any more failures, we should just disable tests using TLS entirely on MacOS.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kiszk commented on pull request #7298: ARROW-8975: [FlightRPC][C++] try to fix MacOS flaky tests
Posted by GitBox <gi...@apache.org>.
kiszk commented on pull request #7298:
URL: https://github.com/apache/arrow/pull/7298#issuecomment-635710164
I am curious why the link error at `arrow-flight-test` occurs at https://travis-ci.org/github/apache/arrow/jobs/692253254#L1141.
Do we need a fix like #7266?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #7298: ARROW-8975: [FlightRPC][C++] try to fix MacOS flaky tests
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #7298:
URL: https://github.com/apache/arrow/pull/7298#issuecomment-635939130
> I am curious why the link error at `arrow-flight-test` occurs at https://travis-ci.org/github/apache/arrow/jobs/692253254#L1141.
> Do we need a fix like #7266?
I think this is because we are failing to link zlib. When we build gRPC from scratch, we provide zlib to gRPC's build, but we don't actually add a dependency on zlib: https://github.com/apache/arrow/blob/75315f5496d09744fbf75680f2302496e5b48aa6/cpp/cmake_modules/ThirdpartyToolchain.cmake#L2065-L2066
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #7298: ARROW-8975: [FlightRPC][C++] try to fix MacOS flaky tests
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #7298:
URL: https://github.com/apache/arrow/pull/7298#issuecomment-635952431
By explicitly linking to zlib, the s390x build passes again, though tests fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7298: ARROW-8975: [FlightRPC][C++] try to fix MacOS flaky tests
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7298:
URL: https://github.com/apache/arrow/pull/7298#issuecomment-635482855
https://issues.apache.org/jira/browse/ARROW-8975
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #7298: ARROW-8975: [FlightRPC][C++] try to fix MacOS flaky tests
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #7298:
URL: https://github.com/apache/arrow/pull/7298#issuecomment-635666766
They should be unrelated; this should only affect Flight, or MacOS builds.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] fsaintjacques commented on a change in pull request #7298: ARROW-8975: [FlightRPC][C++] try to fix MacOS flaky tests
Posted by GitBox <gi...@apache.org>.
fsaintjacques commented on a change in pull request #7298:
URL: https://github.com/apache/arrow/pull/7298#discussion_r432476648
##########
File path: cpp/src/arrow/flight/flight_test.cc
##########
@@ -1556,13 +1556,14 @@ TEST_F(TestBasicAuthHandler, CheckPeerIdentity) {
ASSERT_EQ(result->body->ToString(), "user");
}
-#ifdef __APPLE__
-// ARROW-7701: this test is flaky on MacOS and segfaults (due to gRPC
-// bug?)
-TEST_F(TestTls, DISABLED_DoAction) {
-#else
TEST_F(TestTls, DoAction) {
-#endif
+ // Manually initialize gRPC to try to ensure some thread-locals get
+ // initialized.
+ // https://github.com/grpc/grpc/issues/13856
+ // https://github.com/grpc/grpc/issues/20311
+ // In general, gRPC on MacOS struggles with TLS (both in the sense
+ // of thread-locals and encryption)
+ grpc_init();
Review comment:
Can you move this in the test's fixture setup?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kiszk commented on pull request #7298: ARROW-8975: [FlightRPC][C++] try to fix MacOS flaky tests
Posted by GitBox <gi...@apache.org>.
kiszk commented on pull request #7298:
URL: https://github.com/apache/arrow/pull/7298#issuecomment-635973498
@lidavidm Thank you very much. These test failures occur at the current master.
```
The following tests FAILED:
63 - gandiva-decimal-test (Failed)
64 - gandiva-decimal-single-test (Failed)
```
We are waiting for morning #7256 to fix them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #7298: ARROW-8975: [FlightRPC][C++] try to fix MacOS flaky tests
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7298:
URL: https://github.com/apache/arrow/pull/7298#issuecomment-635630922
It seems that `arrow-threading-utility-test` is stuck in https://ci.ursalabs.org/#/builders/68/builds/9522 .
It's unrelated to this change, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #7298: ARROW-8975: [FlightRPC][C++] try to fix MacOS flaky tests
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #7298:
URL: https://github.com/apache/arrow/pull/7298#discussion_r432485095
##########
File path: cpp/src/arrow/flight/flight_test.cc
##########
@@ -1556,13 +1556,14 @@ TEST_F(TestBasicAuthHandler, CheckPeerIdentity) {
ASSERT_EQ(result->body->ToString(), "user");
}
-#ifdef __APPLE__
-// ARROW-7701: this test is flaky on MacOS and segfaults (due to gRPC
-// bug?)
-TEST_F(TestTls, DISABLED_DoAction) {
-#else
TEST_F(TestTls, DoAction) {
-#endif
+ // Manually initialize gRPC to try to ensure some thread-locals get
+ // initialized.
+ // https://github.com/grpc/grpc/issues/13856
+ // https://github.com/grpc/grpc/issues/20311
+ // In general, gRPC on MacOS struggles with TLS (both in the sense
+ // of thread-locals and encryption)
+ grpc_init();
Review comment:
Done, thanks for the catch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] fsaintjacques closed pull request #7298: ARROW-8975: [FlightRPC][C++] try to fix MacOS flaky tests
Posted by GitBox <gi...@apache.org>.
fsaintjacques closed pull request #7298:
URL: https://github.com/apache/arrow/pull/7298
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org