You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "userhimanshuverma (via GitHub)" <gi...@apache.org> on 2025/04/29 08:19:43 UTC
[PR] KNOX-3139: Add Support for Apache Pinot Integration in Knox [knox]
userhimanshuverma opened a new pull request, #1034:
URL: https://github.com/apache/knox/pull/1034
### Title:
Add Apache Pinot Integration to Apache Knox
### Description:
This PR introduces integration support for **Apache Pinot** within **Apache Knox**. The following key changes are included:
- Added a **rewrite file** for Pinot API routing.
- Created a **service definition file** for Pinot under Knox services.
- Added a **service icon/image** for Pinot in the Knox Admin UI.
This integration will enable secure, proxied access to Pinot APIs through Knox, aligning with Knox’s goal of providing perimeter security for big data ecosystems.
### Additional Notes:
- Verified basic routing and API proxy functionality via Knox gateway.
- Followed the existing patterns for service and rewrite configurations.
- Open for feedback regarding naming conventions, service configuration improvements, and image standards.
Looking forward to reviews and suggestions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KNOX-3139: Add Support for Apache Pinot Integration in Knox [knox]
Posted by "userhimanshuverma (via GitHub)" <gi...@apache.org>.
userhimanshuverma commented on PR #1034:
URL: https://github.com/apache/knox/pull/1034#issuecomment-2837971895
@pzampino @moresandeep Could you please review this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KNOX-3139: Add Support for Apache Pinot Integration in Knox [knox]
Posted by "smolnar82 (via GitHub)" <gi...@apache.org>.
smolnar82 commented on PR #1034:
URL: https://github.com/apache/knox/pull/1034#issuecomment-2841524373
Hi @moresandeep - when you have some spare time, can you please look at the service definition files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KNOX-3139: Add Support for Apache Pinot Integration in Knox [knox]
Posted by "moresandeep (via GitHub)" <gi...@apache.org>.
moresandeep commented on PR #1034:
URL: https://github.com/apache/knox/pull/1034#issuecomment-2841933055
> Hi @moresandeep, I included that rule intentionally to ensure compatibility with both URL formats:
>
> * `https://{hostname}:{port}/gateway/default/pinot/`
> * `https://{hostname}:{port}/gateway/default/pinot`
>
> This helps avoid any issues with or without the trailing slash.
Ahh, i see, sorry i missed that `/` thanks! I'll merge the patch. Please resolve the bug when it gets merged :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KNOX-3139: Add Support for Apache Pinot Integration in Knox [knox]
Posted by "moresandeep (via GitHub)" <gi...@apache.org>.
moresandeep commented on code in PR #1034:
URL: https://github.com/apache/knox/pull/1034#discussion_r2068426998
##########
gateway-service-definitions/src/main/resources/services/pinot/1.3.0/rewrite.xml:
##########
@@ -0,0 +1,147 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+
+
+<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
+<rules>
+
+ <!-- Root -->
+ <rule name="PINOT/inbound/ui-root" pattern="*://*:*/**/*/pinot/">
+ <rewrite template="{$serviceUrl[PINOT]}/"/>
+ </rule>
+
+ <rule name="PINOT/inbound/ui-rootu" pattern="*://*:*/**/*/pinot">
Review Comment:
Looks like this is a duplicate rule and can be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KNOX-3139: Add Support for Apache Pinot Integration in Knox [knox]
Posted by "userhimanshuverma (via GitHub)" <gi...@apache.org>.
userhimanshuverma commented on PR #1034:
URL: https://github.com/apache/knox/pull/1034#issuecomment-2841673202
Hi @moresandeep, I included that rule intentionally to ensure compatibility with both URL formats:
- `https://{hostname}:{port}/gateway/default/pinot/`
- `https://{hostname}:{port}/gateway/default/pinot`
This helps avoid any issues with or without the trailing slash.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KNOX-3139: Add Support for Apache Pinot Integration in Knox [knox]
Posted by "smolnar82 (via GitHub)" <gi...@apache.org>.
smolnar82 commented on PR #1034:
URL: https://github.com/apache/knox/pull/1034#issuecomment-2840091205
@userhimanshuverma - you are missing the Apache license in your new rewrite/service XML files -> that's why the build is failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KNOX-3139: Add Support for Apache Pinot Integration in Knox [knox]
Posted by "moresandeep (via GitHub)" <gi...@apache.org>.
moresandeep merged PR #1034:
URL: https://github.com/apache/knox/pull/1034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KNOX-3139: Add Support for Apache Pinot Integration in Knox [knox]
Posted by "userhimanshuverma (via GitHub)" <gi...@apache.org>.
userhimanshuverma commented on PR #1034:
URL: https://github.com/apache/knox/pull/1034#issuecomment-2840998263
@smolnar82 I have updated the files. please have a look once
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org