You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "zhangshenghang (via GitHub)" <gi...@apache.org> on 2026/06/29 15:24:05 UTC

[PR] [Fix][API] Support dotted opaque table names [seatunnel]

zhangshenghang opened a new pull request, #11220:
URL: https://github.com/apache/seatunnel/pull/11220

   ### Purpose
   
   Fixes #9966.
   
   Kafka topics can legally contain multiple dots, for example `reg.country.user_activity.activity`. SeaTunnel can create a `TablePath` with that full topic as an opaque table name, but later code may parse the string form again through `TablePath.of(String)`. The previous parser rejected names with more than three dot-separated parts, which caused jobs using these topic names to fail with:
   
   `Cannot get split 'reg.country.user_activity.activity' to get databaseName and tableName`
   
   ### Changes
   
   - Keep the existing parsing behavior for one, two, and three-part table paths.
   - Treat names with more than three dot-separated parts as opaque table names instead of rejecting them.
   - Add API coverage for dotted opaque table names.
   - Add Kafka source config coverage for a topic with multiple dots.
   
   ### Tests
   
   - `./mvnw spotless:apply`
   - `git diff --check`
   - `./mvnw -pl seatunnel-api -Dtest=TablePathTest test -Dskip.spotless=true`
   - `./mvnw -pl seatunnel-api install -DskipTests -Dskip.spotless=true`
   - `./mvnw -pl seatunnel-connectors-v2/connector-kafka -Dtest=KafkaSourceConfigTest test -Dskip.spotless=true`
   
   Note: `./mvnw -q -DskipTests verify` was started but produced no output for an extended period and was interrupted locally. A narrower `-am` verification attempt was blocked by an unrelated local `seatunnel-config-shade` compilation issue.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix][API] Support dotted opaque table names [seatunnel]

Posted by "davidzollo (via GitHub)" <gi...@apache.org>.
davidzollo merged PR #11220:
URL: https://github.com/apache/seatunnel/pull/11220


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix][API] Support dotted opaque table names [seatunnel]

Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11220:
URL: https://github.com/apache/seatunnel/pull/11220#issuecomment-4845333968

   Thanks for the update. I rechecked the current head against the latest `dev`, and this branch is still behind upstream.
   
   - base branch: `dev`
   - head SHA: `279b0d8924065359b3527a17b6886c089eccbcc3`
   - compare status: `diverged`
   - ahead_by: `2`
   - behind_by: `4`
   - mergeable_state: `unknown`
   - CI / merge gate snapshot: `failing` (failing: `Build [failure]`)
   
   Because the PR is still behind the latest base, any CI result and merge gate signal here is mixed with upstream drift. The lowest-cost next step is to sync with the latest `dev` and rerun CI first. If anything still fails after the sync, I'm happy to take another look on top of the updated head.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org