You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "liviazhu-db (via GitHub)" <gi...@apache.org> on 2024/11/01 00:06:11 UTC

Re: [PR] [SS] [SPARK-50163] Fix the RocksDB extra acquireLock release due to the completion listener [spark]

liviazhu-db commented on code in PR #48697:
URL: https://github.com/apache/spark/pull/48697#discussion_r1825295966


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBSuite.scala:
##########
@@ -2240,6 +2240,166 @@ class RocksDBSuite extends AlsoTestWithChangelogCheckpointingEnabled with Shared
     }
   }
 
+  test("Rocks DB task completion listener does not double unlock acquireThread") {
+    // Create a custom ExecutionContext with 3 threads

Review Comment:
   Oh sorry, actually fixed now 😆 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org